MIME-Version: 1.0
References: 
 <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
In-Reply-To: 
 <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 10 Apr 2026 23:46:39 +0900
Message-ID: 
 <CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
To: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwEuEd2StEYuP9vj%2BjCFT%3DhQbX8xcQeq8%3DKj8r9xT3vmyg%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 10, 2026 at 3:11=E2=80=AFPM vignesh C <vignesh21@gmail.com> wro=
te:
>
> Hi,
>
> This small cleanup patch updates src/bin/pg_waldump/archive_waldump.c
> to use the recently introduced XLogRecPtrIsValid() helper instead of
> negating XLogRecPtrIsInvalid(). The current code uses double-negative
> checks such as:
> Assert(!XLogRecPtrIsInvalid(privateInfo->startptr));
> if (!XLogRecPtrIsInvalid(privateInfo->endptr))
>
> This patch changes them to:
> Assert(XLogRecPtrIsValid(privateInfo->startptr));
> if (XLogRecPtrIsValid(privateInfo->endptr))
>
> This improves readability without changing behavior. The attached
> patch has the changes for the same.

Commit a2b02293bc6 switched various places to use XLogRecPtrIsValid(),
but it looks like later commits accidentally introduced uses of
XLogRecPtrIsInvalid() again. So +1 for this change.

Also, that commit replaced direct comparisons with InvalidXLogRecPtr with
XLogRecPtrIsValid(). I noticed two such comparisons [1]. Should these be
updated as well?

Regards,

[1]
$ git grep -E "[=3D\!]=3D InvalidXLogRecPtr"
src/backend/commands/repack_worker.c:   Assert(ctx->reader->EndRecPtr
!=3D InvalidXLogRecPtr);
src/backend/replication/walreceiver.c:  applyPtr =3D (latestApplyPtr =3D=3D
InvalidXLogRecPtr) ?

--=20
Fujii Masao