MIME-Version: 1.0
References: 
 <CAHg+QDdej0c0gWJi2FnbirzhgzyZNPiTwC1P5B_-dSNCzq-91A@mail.gmail.com>
 <CACJufxEYGY5twGooBDU4ttpb0SOQuOb8dYKoBsEML8dObAf4ZQ@mail.gmail.com>
In-Reply-To: 
 <CACJufxEYGY5twGooBDU4ttpb0SOQuOb8dYKoBsEML8dObAf4ZQ@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 18 May 2026 22:22:13 +0900
Message-ID: 
 <CAHGQGwEvUj+ycr5vYMPQhZ8gk1of4HiSGfKVBJ15nA8d3MyDhQ@mail.gmail.com>
Subject: Re: COPY FROM ON_ERROR SET_NULL bypasses domain NOT NULL with partial
 column list
To: jian he <jian.universality@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwEvUj%2Bycr5vYMPQhZ8gk1of4HiSGfKVBJ15nA8d3MyDhQ%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 17, 2026 at 12:59=E2=80=AFPM jian he <jian.universality@gmail.c=
om> wrote:
>
> On Fri, Apr 17, 2026 at 1:09=E2=80=AFAM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> >
> > HI hackers,
> >
> > domain_with_constraint[] was allocated with list_length(attnumlist)
> > elements and indexed sequentially via foreach_current_index(), but
> > copyfromparse.c accesses it via attnum - 1 (physical attribute index).
> > With a partial column list targeting high-numbered columns, this caused
> > an out-of-bounds read that bypassed domain NOT NULL checks, silently
> > inserting NULL into NOT NULL domain columns.
> >
> > Fix by allocating with num_phys_attrs and indexing by attnum - 1,
> > consistent with all other per-column arrays in BeginCopyFrom().
> >
> > Patch is attached, and added a new test case to cover this scenario.
> >
>
> The patch looks good to me.
> I simplified the tests.

The patch looks good to me. Barring any objections, I will commit it.

Regards,

--=20
Fujii Masao