public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Ayush Tiwari <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_recvlogical: send final feedback on SIGINT/SIGTERM exit
Date: Wed, 8 Jul 2026 12:21:32 +0900
Message-ID: <CAHGQGwF6z8Df19WPX8ufbDvGBT7_5CEkxk7Q1K1LMwqPHbccFg@mail.gmail.com> (raw)
In-Reply-To: <CAJTYsWVftJZdWXrppHZ+u-zN__J6ae01AS=scNnLUFXGS_cFYQ@mail.gmail.com>
References: <CAHGQGwE83z9O=X7ADMsSa3e1EuP3_GgqHjFt5SmPDNxZo_wgJA@mail.gmail.com>
	<CAJTYsWVftJZdWXrppHZ+u-zN__J6ae01AS=scNnLUFXGS_cFYQ@mail.gmail.com>

On Mon, Jun 15, 2026 at 10:42 PM Ayush Tiwari
<[email protected]> wrote:
>
> Hi,
>
> On Fri, 29 May 2026 at 05:42, Fujii Masao <[email protected]> wrote:
>>
>>
>> Currently, when pg_recvlogical exits due to SIGINT or SIGTERM, it can
>> terminate after writing decoded output locally but before sending feedback
>> that reflects the latest written position to the server. If pg_recvlogical
>> is restarted after that, the server-side logical replication slot may still
>> remain behind those already-written changes, and the same decoded data can
>> be sent again.
>>
>> Attached patch makes pg_recvlogical send final feedback once more during
>> SIGINT/SIGTERM exit, before sending CopyDone. That gives the server one more
>> chance to advance the slot far enough to avoid resending already-written
>> data after pg_recvlogical is restarted.
>
>
> Thanks for the patch!
>
> The problem statement and solution makes sense to me.
>
> I applied v1 and tried it locally.  It builds cleanly and the new block in
> 030_pg_recvlogical.pl passes.  As a sanity check I reverted just the
> prepareToTerminate() change and kept the test: the "does not duplicate decoded
> changes after signal shutdown" assertion then fails (the row is decoded twice
> on the restart), so the test is clearly exercising the fix too. I don't see any
> downside of having the fix attached.

Thanks for the review! I've pushed the patch.

Regards,

-- 
Fujii Masao

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pg_recvlogical: send final feedback on SIGINT/SIGTERM exit
  In-Reply-To: <CAHGQGwF6z8Df19WPX8ufbDvGBT7_5CEkxk7Q1K1LMwqPHbccFg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox