MIME-Version: 1.0
References: 
 <CAKFQuwawy1e6YR4S=j+y7pXqg_Dw1WBVrgvf=BP3d1_aSfe_+Q@mail.gmail.com>
 <CACJufxGEHmijmP-QqvrmqU6cxmhgpdjY7ewQBQ=E9NmdyEcqmw@mail.gmail.com>
 <f5ebfa4b318e97c41c0919304b94c77f@oss.nttdata.com>
 <CACJufxG=em0PHZvy1EAZ+vxPZ8UA68MfQ-Hji+h+WgnWNpqmVQ@mail.gmail.com>
 <CACJufxF0c3k5O8up9NOY-m02nyJ0f6N1tKxZwjCewTqvvFmbLw@mail.gmail.com>
 <CACJufxHr-LBV2pB9m64mA=1pgVMM4LvUn+-MzpeViWV=Ks_cyg@mail.gmail.com>
 <901967e5-e5dc-42c6-b2bf-fb3a49d7e787@gmail.com>
 <CACJufxEs_VBV39gYHnpLFOMcUaUD-ADAst_ePTCgmoDR8O=ekg@mail.gmail.com>
 <DFUHPCSP86G0.11VU7FGWRRXM2@gmail.com>
 <CACJufxGYPXQ_Jz1avF5eSh_XJRsxhPSUZ+=RzG3Hz4_XNAc32g@mail.gmail.com>
 <4c540fe3-495c-4bbf-8dcf-2c1e2b88bc3d@gmail.com>
 <CACJufxHFwQMw1As+QFk+fA7S8ZxRG2wOvHcvmsWuj2XJ+W6d_A@mail.gmail.com>
 <DG7WARDX1TY0.2VX3Q7QHSCXE9@gmail.com>
 <CACJufxGUP09S7a2akQ4GD62-Rf2bcV52cqnw4qqBOXcn9bmxCA@mail.gmail.com>
 <6f973222-f306-43af-9df5-38673fe3f7d6@eisentraut.org>
 <CACJufxG-bN_3-0qG2NsY2+07gMWwYkT1VNB1xfbxt9i-ZAyh9w@mail.gmail.com>
 <5e126dbb-9535-4de4-ad3b-187e475aa6b5@eisentraut.org>
 <CAHGQGwGmPc6aHpA5=WxKreiDePiOEitfOFsW2dSo5m81xWXgRA@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwGmPc6aHpA5=WxKreiDePiOEitfOFsW2dSo5m81xWXgRA@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 13 Mar 2026 11:57:13 +0900
Message-ID: 
 <CAHGQGwFTRgYXS0V7=e3AYox5PVbMU034BQoxZkX7kMyp5beLMw@mail.gmail.com>
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
To: Peter Eisentraut <peter@eisentraut.org>
Cc: jian he <jian.universality@gmail.com>,
	Matheus Alcantara <matheusssilv97@gmail.com>,
 torikoshia <torikoshia@oss.nttdata.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Jim Jones <jim.jones@uni-muenster.de>,
 Kirill Reshke <reshkekirill@gmail.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
 Yugo NAGATA <nagata@sraoss.co.jp>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwFTRgYXS0V7%3De3AYox5PVbMU034BQoxZkX7kMyp5beLMw%40mail.gmail.com>
Precedence: bulk

On Wed, Mar 4, 2026 at 10:25=E2=80=AFPM Fujii Masao <masao.fujii@gmail.com>=
 wrote:
>
> On Tue, Mar 3, 2026 at 3:38=E2=80=AFPM Peter Eisentraut <peter@eisentraut=
.org> wrote:
> > Thanks, committed.
>
> Thanks for committing the patch!
>
> With this change, ON_ERROR =3D 'set_null' can now be used with foreign ta=
bles
> backed by file_fdw. However, unlike ON_ERROR =3D 'ignore', there is curre=
ntly
> no regression test covering this behavior in file_fdw.
>
> How about adding a regression test to ensure that file_fdw works correctl=
y
> with ON_ERROR =3D 'set_null', and to improve test coverage? Patch attache=
d.

Barring any objections, I will commit the patch.

Regards,

--=20
Fujii Masao