MIME-Version: 1.0
References: <E1w7pJ5-002Q6p-10@gemulon.postgresql.org>
 <CA+TgmoYsu2+YAo9eLGkDp5VP-pfQ-jOoX382vS4THKHeRTNgew@mail.gmail.com>
 <CAHGQGwEhtaT6qe5fN--t6HhTwBvBoZUukx-NVPpEMG9uFWHHvw@mail.gmail.com>
 <CA+TgmoYwebE37qZwcNE9MKT4rt3ymP2s1M6KyRK_MGkxCYZMeg@mail.gmail.com>
 <CAHGQGwFARNb_2J1Skvw5RQSsyhqUqWQgQJNDhP+v-7fzinLfOw@mail.gmail.com>
 <CA+TgmoZ2+HQess2QSuZp1si17CDHw165PQROaFq0skcKJS20-g@mail.gmail.com>
 <CAHGQGwFf+cpgw3T=NsGF8cxm4zx74AMCdajDda2Z7OXq9YM1mQ@mail.gmail.com>
 <CAA4eK1+VwGQb5T7xH5AXS0XknGGCAVZQLbBcjq9DZikJhViX2g@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1+VwGQb5T7xH5AXS0XknGGCAVZQLbBcjq9DZikJhViX2g@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Tue, 7 Apr 2026 12:51:32 +0900
Message-ID: 
 <CAHGQGwFUbZWXW=y_XFJQatSkW8UFX1js=9g-JoZN9+go_j5KKg@mail.gmail.com>
Subject: Re: pgsql: Reduce log level of some logical decoding messages from
 LOG to D
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwFUbZWXW%3Dy_XFJQatSkW8UFX1js%3D9g-JoZN9%2Bgo_j5KKg%40mail.gmail.com>
Precedence: bulk

On Tue, Apr 7, 2026 at 12:18=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.co=
m> wrote:
>
> On Tue, Apr 7, 2026 at 8:34=E2=80=AFAM Fujii Masao <masao.fujii@gmail.com=
> wrote:
> >
> > On Tue, Apr 7, 2026 at 1:16=E2=80=AFAM Robert Haas <robertmhaas@gmail.c=
om> wrote:
> > > > But probably are you suggesting making this behavior the default? I=
f yes,
> > > > one straightforward approach to implement that would be to log thes=
e messages
> > > > at LOG when AmWalSenderProcess() or AmLogicalSlotSyncWorkerProcess(=
) is true,
> > > > and at DEBUG1 otherwise.
> > >
> > > Yeah.
> >
> > OK, I've prepared a patch to implement this. Patch attached.
> > It introduces a LogicalDecodingLogLevel() macro to choose the log level
> > based on context, but the name may not be ideal, so suggestions are wel=
come.
> >
>
> How about adding repack_worker to that check as well? See 28d534e2ae.

Thanks for the info!

It may be better to use DEBUG1 when AmRegularBackendProcess() is true
and LOG otherwise, rather than checking AmWalSenderProcess() or
AmLogicalSlotSyncWorkerProcess(). This would also cover any future
background processes that use logical decoding.

Regards,

--=20
Fujii Masao