public inbox for [email protected]  

help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: Chao Li <[email protected]>
Cc: getiancheng <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Release postmaster working memory context in slotsync worker
Date: Mon, 6 Apr 2026 23:09:49 +0900
Message-ID: <CAHGQGwFWLN=-O3A7uBjmgYJt7Q9DMvn05C_aM7HMXg6DiSV_9Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHGQGwHO05JaUpgKF8FBDmPdBUJsK22axRRcgmAUc2Jyi8OK8g@mail.gmail.com>
	<ukpuo66v3k5z5cpwfbofa3zwdgdb53thbxemgqvtsnf7gdf5ew@ixgj5hs4bwu6>
	<[email protected]>
	<CAHGQGwFu0tam9i2UxRHY+mrB-0YZVfWZPheKYy5V2KfB-WxuGQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Thu, Mar 19, 2026 at 5:16 PM Chao Li <[email protected]> wrote:
> Still, the current phrasing seems a bit too strong to me. Strictly speaking, the memory is already inherited at fork time, so this is not making access impossible in an absolute sense. What this patch really does is remove the inherited PostmasterContext, so the child no longer retains that postmaster-private data through that context.
>
> Maybe we could phrase in some way like: "so that it no longer retains access to postmaster-private data through PostmasterContext”.

Thanks for the review! I've pushed the patch.
Per your and Tiancheng's suggestions, I just used "prevent unintended use"
in the commit message.

Regards,

-- 
Fujii Masao





view thread (3+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Release postmaster working memory context in slotsync worker
  In-Reply-To: <CAHGQGwFWLN=-O3A7uBjmgYJt7Q9DMvn05C_aM7HMXg6DiSV_9Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox