MIME-Version: 1.0
References: <ak8MeTS9QBmz6DKt@nathan> <ak8d1aEHqtAdHi7k@paquier.xyz>
In-Reply-To: <ak8d1aEHqtAdHi7k@paquier.xyz>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 9 Jul 2026 13:22:52 +0900
Message-ID: 
 <CAHGQGwFojD_ibHvvHoYnQzomQvac2CvfS1hOHr+y46pNq6ZGFg@mail.gmail.com>
Subject: Re: remove WaitEventCustomCounterData
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwFojD_ibHvvHoYnQzomQvac2CvfS1hOHr%2By46pNq6ZGFg%40mail.gmail.com>
Precedence: bulk

On Thu, Jul 9, 2026 at 1:04=E2=80=AFPM Michael Paquier <michael@paquier.xyz=
> wrote:
>
> On Wed, Jul 08, 2026 at 09:50:33PM -0500, Nathan Bossart wrote:
> > While trying to understand the extent of our spinlock usage, I noticed =
that
> > WaitEventCustomCounterData->mutex is unnecessary because the counter is
> > only ever accessed with WaitEventCustomLock held exclusively.  So, here=
's a
> > patch to simplify matters a bit.  Thoughts?
>
> Indeed.  This removal sounds good to me, thanks.

#include "storage/spin.h" seems no longer needed in wait_event.c,
since the patch removes the last use of the spinlock code there.
So we can remove that include as well?

Regards,

--=20
Fujii Masao