MIME-Version: 1.0
References: <f14463ab-990b-4ae9-a177-998d2677aae0@pgbackrest.org>
 <CAHGQGwEnakTrosMp3Y=Trya4MTC-h8Lqx3FDU1mOALRQ0rz59Q@mail.gmail.com>
 <9e8b7ee9-4a16-477a-baa5-0cdf37a04798@pgbackrest.org>
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 5 Mar 2026 01:19:17 +0900
Message-ID: 
 <CAHGQGwFpq5D6z+NcPhZuSazkX_PjMFE3UNKwnypNs4FRT7brDw@mail.gmail.com>
Subject: Re: Improve checks for GUC recovery_target_xid
To: David Steele <david@pgbackrest.org>
Cc: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwFpq5D6z%2BNcPhZuSazkX_PjMFE3UNKwnypNs4FRT7brDw%40mail.gmail.com>
Precedence: bulk

On Thu, Mar 5, 2026 at 12:41=E2=80=AFAM Fujii Masao <masao.fujii@gmail.com>=
 wrote:
> My earlier comment was based on my misunderstanding. I thought that only
> 32-bit transaction IDs were allowed for recovery_target_xid, and therefor=
e
> values larger than 2^32 should be rejected.
>
> However, recovery_target_xid currently accepts both 32-bit XIDs and 64-bi=
t
> full transaction IDs (epoch + 32-bit XID). When a 64-bit value is specifi=
ed,
> only the 32-bit XID portion is used as the recovery target.
> Given this behavior, your change seems to make sense.

I'm tempted to clarify this behavior by adding something like
the following text to the description of recovery_target_xid
in config.sgml...:

-------------------------------
The value can be specified as either a 32-bit transaction ID or a 64-bit
transaction ID (consisting of an epoch and a 32-bit ID), such as the value
returned by pg_current_xact_id(). When a 64-bit transaction ID is provided,
only its 32-bit transaction ID portion is used as the recovery target.
For example, the values 4294968296 (epoch 1) and 8589935592 (epoch 2)
both refer to the same 32-bit transaction ID, 1000.

The effective transaction ID (the 32-bit portion) must be greater than
or equal to 3.
-------------------------------

Regards,


--=20
Fujii Masao