MIME-Version: 1.0
References: <vf4hbwrotvhbgcnknrqmfbqlu75oyjkmausvy66ic7x7vuhafx@e4rvwavtjswo>
 <20260305185203.76.noahmisch@microsoft.com>
 <2nctrio6nf4efkumjp77nx2hs5poi7vvg6avq3ftb6ssprtcog@wzuehzrfisez>
 <0d2e13f5-45eb-4ab1-9bce-cffb9e5754ac@vondra.me>
In-Reply-To: <0d2e13f5-45eb-4ab1-9bce-cffb9e5754ac@vondra.me>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 13 Mar 2026 20:33:50 +0900
Message-ID: 
 <CAHGQGwFrBJGyLk_aGUvT8902u3sQ1KKOeq7WREycqPnJ0n7zPw@mail.gmail.com>
Subject: Re: gistGetFakeLSN() can return incorrect LSNs
To: Tomas Vondra <tomas@vondra.me>
Cc: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
 pgsql-hackers@postgresql.org,
	Tomas Vondra <tv@fuzzy.cz>, Peter Geoghegan <pg@bowt.ie>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwFrBJGyLk_aGUvT8902u3sQ1KKOeq7WREycqPnJ0n7zPw%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 13, 2026 at 8:12=E2=80=AFPM Tomas Vondra <tomas@vondra.me> wrot=
e:
>
> On 3/5/26 21:25, Andres Freund wrote:
> > Hi,
> >
> > On 2026-03-05 10:52:03 -0800, Noah Misch wrote:
> >> On Thu, Mar 05, 2026 at 12:10:11PM -0500, Andres Freund wrote:
> >>> Tomas encountered a crash with the index prefetching patchset. One of=
 the
> >>> patches included therein is a generalization of the gistGetFakeLSN()
> >>> mechanism, which is then used by other indexes as well.  That trigger=
ed an
> >>> occasional, hard to locally reproduce, ERROR or PANIC in CI, about
> >>>
> >>>   ERROR: xlog flush request 0/01BD2018 is not satisfied --- flushed o=
nly to 0/01BD2000
> >>
> >>> To be safe, this code would need to use a version of GetXLogInsertRec=
Ptr()
> >>> that does use XLogBytePosToEndRecPtr() instead of XLogBytePosToRecPtr=
().
> >>
> >> I agree.  Thanks for diagnosing it.  Feel free to move forward with th=
at
> >> strategy, or let me know if you'd like me to do it.
> >
> > I'd appreciate if you could do it.
> >
>
> Here's a fix for master (and backpatching). It introduces a new function
> GetXLogInsertEndRecPtr() and then uses that in gistGetFakeLSN(). I still
> need to test this a bit more, but it did fix the issue in our dev branch
> (where we saw regular failures). So I'm 99% sure it's fine.
>
> After writing the fix I had the idea to grep for GetXLogInsertRecPtr
> calls that might have similar issue (being passed to XLogFlush), and
> sure enough walsender does this:
>
>     XLogFlush(GetXLogInsertRecPtr());
>
> Which AFAICS has the same issue, right? Funnily enough, this is a very
> new call, from 2026/03/06. Before 6eedb2a5fd88 walsender might flush not
> far enough, now it may be flushing too far ;-) AFAIK it should call the
> same GetXLogInsertEndRecPtr() once we have it.

Yes, this is already being discussed at [1], and Anthonin has also proposed
a patch there that adds GetXLogInsertEndRecPtr().

Regards,

[1] https://postgr.es/m/vzguaguldbcyfbyuq76qj7hx5qdr5kmh67gqkncyb2yhsygrdt@=
dfhcpteqifux


--=20
Fujii Masao