MIME-Version: 1.0
References: 
 <CAHGQGwHFKF+x4E+SqedMCnmLCitxjTUUtSyL_+mMeuq-GbEt6w@mail.gmail.com>
 <CAO6_Xqp+ADb6KZVWLMALu3xmwVUEO8S1EiCnp38mG6BrHrEnuA@mail.gmail.com>
 <CAO6_XqqKDV+AuP=Gf4kRKPqzyYTsOyGd3LE8Jqkwi7EMPJpbhA@mail.gmail.com>
 <CAHGQGwHc5yH4Nxp59KXJP0kAr61j3W7QeSKT2HxVjZa3OrLzmg@mail.gmail.com>
 <CAO6_Xqq1h6kggb1o206rgouPS0H5jnjahzZ0We-9ggnBjB2JsA@mail.gmail.com>
 <CAHGQGwFJnNUOMiW9wR-2WjSKzzj0wV8p55J8bnJ6mik=z0oFPQ@mail.gmail.com>
 <2631a3c3-5e60-4a1a-9e20-377024322602@gmail.com>
 <CAO6_Xqq73TPa3M6nQ7RqRhKkcphy1JX7aNGTYy-x_Sn+6a8Z_Q@mail.gmail.com>
 <CAHGQGwGvnpN=2bo+F7H90YLFcx9=SazwLkcx+0gEcrbQy5NVZg@mail.gmail.com>
 <CAHGQGwECpyJtMqkCEvyqgZDiwAeMj3RKobui7jONrDd35W0x3Q@mail.gmail.com>
 <vzguaguldbcyfbyuq76qj7hx5qdr5kmh67gqkncyb2yhsygrdt@dfhcpteqifux>
 <CAO6_Xqq=-KnxrFQvmyF++XH4ngtXVhcDB979rEn6SPtUhSmNYg@mail.gmail.com>
 <CAHGQGwGpfEsBJBLQDou7xccnb0tj1T_NQv2gZfuQfgzn_b=RsQ@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwGpfEsBJBLQDou7xccnb0tj1T_NQv2gZfuQfgzn_b=RsQ@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 16 Mar 2026 14:39:24 +0900
Message-ID: 
 <CAHGQGwFsuPcC7Aov73FTqMC5LEOdZ6uoWno5BR1HX2LnZRNKBw@mail.gmail.com>
Subject: Re: Shutdown indefinitely stuck due to unflushed FPI_FOR_HINT record
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Andres Freund <andres@anarazel.de>,
 Alexander Lakhin <exclusion@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000020f80064d1da547"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwFsuPcC7Aov73FTqMC5LEOdZ6uoWno5BR1HX2LnZRNKBw%40mail.gmail.com>
Precedence: bulk

--000000000000020f80064d1da547
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 13, 2026 at 2:24=E2=80=AFAM Fujii Masao <masao.fujii@gmail.com>=
 wrote:
> Thanks for investigating the issue and making the patch!
> It looks good to me.

Since Tomas added GetXLogInsertEndRecPtr() in commit b1f14c96720,
I updated the patch to use it. Patch attached.
Barring any objections, I will commit it.

-       XLogFlush(GetXLogWriteRecPtr());
+       XLogFlush(GetXLogInsertEndRecPtr());

I excluded the above change from the patch because it seems like a separate
issue. I also wonder whether this code could cause an error in XLogFlush()
even when GetXLogWriteRecPtr() is used.

Regards,

--=20
Fujii Masao

--000000000000020f80064d1da547
Content-Type: application/octet-stream;
	name="v2-0001-Fix-WAL-flush-LSN-used-by-logical-walsender-durin.patch"
Content-Disposition: attachment;
	filename="v2-0001-Fix-WAL-flush-LSN-used-by-logical-walsender-durin.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmsr771g0>
X-Attachment-Id: f_mmsr771g0

RnJvbSBhYmFmZWU4ZDA2MzU4ZjlhMzYyMzczODk5YzMzMGQwMTBkMjA4MDRhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IE1vbiwgMTYgTWFyIDIwMjYgMTM6MTU6MTMgKzA5MDAKU3ViamVjdDogW1BBVENIIHYyXSBG
aXggV0FMIGZsdXNoIExTTiB1c2VkIGJ5IGxvZ2ljYWwgd2Fsc2VuZGVyIGR1cmluZwogc2h1dGRv
d24KCkNvbW1pdCA2ZWVkYjJhNWZkOCBtYWRlIHRoZSBsb2dpY2FsIHdhbHNlbmRlciBjYWxsClhM
b2dGbHVzaChHZXRYTG9nSW5zZXJ0UmVjUHRyKCkpIHRvIGVuc3VyZSB0aGF0IGFsbCBwZW5kaW5n
IFdBTCBpcyBmbHVzaGVkLApmaXhpbmcgYSBwdWJsaXNoZXIgc2h1dGRvd24gaGFuZy4gSG93ZXZl
ciwgaWYgdGhlIGxhc3QgV0FMIHJlY29yZCBlbmRzIGF0CmEgcGFnZSBib3VuZGFyeSwgR2V0WExv
Z0luc2VydFJlY1B0cigpIGNhbiByZXR1cm4gYW4gTFNOIHBvaW50aW5nIHBhc3QKdGhlIHBhZ2Ug
aGVhZGVyLCB3aGljaCBjYW4gY2F1c2UgWExvZ0ZsdXNoKCkgdG8gcmVwb3J0IGFuIGVycm9yLgoK
QSBzaW1pbGFyIGlzc3VlIHByZXZpb3VzbHkgZXhpc3RlZCBpbiB0aGUgR2lTVCBjb2RlLiBDb21t
aXQgYjFmMTRjOTY3MjAKaW50cm9kdWNlZCBHZXRYTG9nSW5zZXJ0RW5kUmVjUHRyKCksIHdoaWNo
IHJldHVybnMgYSBzYWZlIFdBTCBpbnNlcnRpb24gZW5kCmxvY2F0aW9uIChyZXR1cm5pbmcgdGhl
IHN0YXJ0IG9mIHRoZSBwYWdlIHdoZW4gdGhlIGxhc3QgcmVjb3JkIGVuZHMgYXQgYSBwYWdlCmJv
dW5kYXJ5KSwgYW5kIHVwZGF0ZWQgdGhlIEdpU1QgY29kZSB0byB1c2UgaXQgd2l0aCBYTG9nRmx1
c2goKS4KClRoaXMgY29tbWl0IGZpeGVzIHRoZSBpc3N1ZSBieSBtYWtpbmcgdGhlIGxvZ2ljYWwg
d2Fsc2VuZGVyIHVzZQpYTG9nRmx1c2goR2V0WExvZ0luc2VydEVuZFJlY1B0cigpKSB3aGVuIGZs
dXNoaW5nIHBlbmRpbmcgV0FMIGR1cmluZyBzaHV0ZG93bi4KCkJhY2twYXRjaCB0byBhbGwgc3Vw
cG9ydGVkIHZlcnNpb25zLgoKUmVwb3J0ZWQtYnk6IEFuZHJlcyBGcmV1bmQgPGFuZHJlc0BhbmFy
YXplbC5kZT4KQXV0aG9yOiBBbnRob25pbiBCb25uZWZveSA8YW50aG9uaW4uYm9ubmVmb3lAZGF0
YWRvZ2hxLmNvbT4KUmV2aWV3ZWQtYnk6IEZ1amlpIE1hc2FvIDxtYXNhby5mdWppaUBnbWFpbC5j
b20+CkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vdnpndWFndWxkYmN5ZmJ5dXE3NnFq
N2h4NXFkcjVrbWg2N2dxa25jeWIyeWhzeWdyZHRAZGZoY3B0ZXFpZnV4Ci0tLQogc3JjL2JhY2tl
bmQvcmVwbGljYXRpb24vd2Fsc2VuZGVyLmMgfCA4ICsrKysrKystCiAxIGZpbGUgY2hhbmdlZCwg
NyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQv
cmVwbGljYXRpb24vd2Fsc2VuZGVyLmMgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi93YWxzZW5k
ZXIuYwppbmRleCAzNzZmZjQ2MzQwZC4uMDgyNTMxMDNjYjMgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNr
ZW5kL3JlcGxpY2F0aW9uL3dhbHNlbmRlci5jCisrKyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9u
L3dhbHNlbmRlci5jCkBAIC0xODkwLDkgKzE4OTAsMTUgQEAgV2FsU25kV2FpdEZvcldhbChYTG9n
UmVjUHRyIGxvYykKIAkJICogSWYgd2UncmUgc2h1dHRpbmcgZG93biwgdHJpZ2dlciBwZW5kaW5n
IFdBTCB0byBiZSB3cml0dGVuIG91dCwKIAkJICogb3RoZXJ3aXNlIHdlJ2QgcG9zc2libHkgZW5k
IHVwIHdhaXRpbmcgZm9yIFdBTCB0aGF0IG5ldmVyIGdldHMKIAkJICogd3JpdHRlbiwgYmVjYXVz
ZSB3YWx3cml0ZXIgaGFzIHNodXQgZG93biBhbHJlYWR5LgorCQkgKgorCQkgKiBOb3RlIHRoYXQg
R2V0WExvZ0luc2VydEVuZFJlY1B0cigpIGlzIHVzZWQgdG8gb2J0YWluIHRoZSBXQUwgZmx1c2gK
KwkJICogcmVxdWVzdCBsb2NhdGlvbiBpbnN0ZWFkIG9mIEdldFhMb2dJbnNlcnRSZWNQdHIoKS4g
QmVjYXVzZSBpZiB0aGUKKwkJICogbGFzdCBXQUwgcmVjb3JkIGVuZHMgYXQgYSBwYWdlIGJvdW5k
YXJ5LCBHZXRYTG9nSW5zZXJ0UmVjUHRyKCkgY2FuCisJCSAqIHJldHVybiBhbiBMU04gcG9pbnRp
bmcgcGFzdCB0aGUgcGFnZSBoZWFkZXIsIHdoaWNoIG1heSBjYXVzZQorCQkgKiBYTG9nRmx1c2go
KSB0byByZXBvcnQgYW4gZXJyb3IuCiAJCSAqLwogCQlpZiAoZ290X1NUT1BQSU5HICYmICFSZWNv
dmVyeUluUHJvZ3Jlc3MoKSkKLQkJCVhMb2dGbHVzaChHZXRYTG9nSW5zZXJ0UmVjUHRyKCkpOwor
CQkJWExvZ0ZsdXNoKEdldFhMb2dJbnNlcnRFbmRSZWNQdHIoKSk7CiAKIAkJLyoKIAkJICogVG8g
YXZvaWQgdGhlIHNjZW5hcmlvIHdoZXJlIHN0YW5kYnlzIG5lZWQgdG8gY2F0Y2ggdXAgdG8gYSBu
ZXdlcgotLSAKMi41MS4yCgo=
--000000000000020f80064d1da547--