Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUxSf-001ZEt-0A for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jun 2026 02:05:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wUxSb-004LwG-34 for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jun 2026 02:05:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUxSb-004Lw7-1y for pgsql-hackers@lists.postgresql.org; Thu, 04 Jun 2026 02:05:29 +0000 Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wUxSZ-000000019sY-0Qwd for pgsql-hackers@lists.postgresql.org; Thu, 04 Jun 2026 02:05:29 +0000 Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-43f5927e70aso98746fac.1 for ; Wed, 03 Jun 2026 19:05:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780538725; cv=none; d=google.com; s=arc-20240605; b=M/dT0wc79Wb2Zb5PvZjD9u4/CmrEhkwURY3YC36hRjnLwUWY4fROfx/2lA3wshkfSY 09dtZuB4uHnAJ+7SLKnWwsfITg2Tlml9b/AqLNV/hSFryF8K6NOwD0d6LbsXMNGHdd1e hfhqKlvDHM7Qdo1t7rKgRgx4oMDT5jwwZX2m8lRR7vWHWIuKYi5jPC55ROLjz1Oljve6 WrrWMCvi1VCfqaHWwccVNLpuh++2sQRZOHcZaxHHEHr9UVCBTsrkSKUSdi0grJVWRF8e m7wYXeVRHIQr4MgKp1F/oLlXV6zGUlLFLY7Jk7zb1zara6v15zeRrkbgz/LxIizinLCl KSvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=gnbtV4QNOAneY67auIlUiyGUuFvWdOtIFWcWiSaOR/M=; fh=n0ROu496oAXvJi5GktYrQMRYjFku+obV+Yitja4bBpA=; b=duuEsXUZbJMX8lxzhcGNAvl71weEHDMyPrwWwQ7GvKWlcPQhYayyXfolLy0EM7Rqr2 9gNDhw0wcd8e6ODFH74l50gaLGq4zDzYAxOW8yxG/JlbkY/hbXQlkhbo1SosH3Da1aqY InHSLbBjkYAgpW06BlWQ/49enDxkYn1cK00vsux3iPyD9e1BtdKh7UR9bW2ecTSB7Zuv M/ugGtepVAe1yEpBjJETy0hK69/hbLQ17u88PPFE4utCID3UwvEd0PpVrLulanM8BdS7 sZPralpJ9ANwIMn2xQsDLdBTsyIL7bDsLtVOPzAfyYRTrzHi7jgg7c1FZ7R+DEMFJkr/ x9OA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780538725; x=1781143525; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gnbtV4QNOAneY67auIlUiyGUuFvWdOtIFWcWiSaOR/M=; b=Kdrw8HL3IrW1xTDPhyjle0hZhiooGlY15xlgYhFP3rGpNbBdUqpAVDzbZyfnM0hdQR knqNQDAAY5ZQKrylH35q9CZrLHgIMJx7A9QvdgsJYHeltUUw2NiQ4ubkj1f36dUcFJBz TuRjxv29a+DomNQCUZKE8bgACuLn9S5DM3+XTgyuao33lQJNulVOFYHv18HPTgd/KhSG TNc21Bk6CZ5dTNejb1RMPJth8mfTuTbDfRFfyTKw6uKbbAQnvBbrhdTUZxC9Zygku3cF HE0aB4GQOTMapKDEo8AQQgkeT6rv1K7CbIksvyIiayMBXBlq5jROkaPwzNMx85tUviMS jJfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780538725; x=1781143525; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gnbtV4QNOAneY67auIlUiyGUuFvWdOtIFWcWiSaOR/M=; b=X8ug4Z/KTwE8ZqHUCsS4saeCU4gLYyKLqKRtI7UtKeh/r3rM2i0DE3RmbWpFUq26p5 qJ4dNyjEoT6jpXmu/1CXFaUQhyqz93eYZHEjimlWjZiaBAlXGs6hNBzkzQ4l1xSjtcHG zdVslMjX3HMYft3bbh0BU1R/hP+BVkdqtz4yFbfm1Da+7kA8BOF7qp6pFV8kUq4/pyh7 QgaeOOBO+Ut1cb5Qt0f3VEqXG3P3x97ZCQ3Htce7n8qpxnru/57KC7tioJpiDL9qyjBG SwMdMfcoqqUVQXaJsdspD3ik8hMMOt9WMRlzBObYb/Bq0AfjToP2H71UZ5kiVRmN2nPC xNqA== X-Forwarded-Encrypted: i=1; AFNElJ9zas0BI6+AG96F4wM1joDKomlxjjtPEgIJD66ARiRJRZu1lawMiVOsbBx0K60a5iE6JQvYmpOF8+1Ss/kr@lists.postgresql.org X-Gm-Message-State: AOJu0Ywk5xhibkH8Fge41akMucIEGDG+9vEFTbM8aepKCvYdIbkyxGaJ VyNYUHeXM2gBVHct0T17pWWves05aEb/8pu7eg7O6QbhGMfou8RqiOttYlrvPZboqvJVB6YsRel 7iw8IIR1aYwb3z1uEPSVaGSe5ySVCLRFZRxex3Zk= X-Gm-Gg: Acq92OHKATIvjB7ANAlm0L2leEpwUiUIsojgH4yJTB1jKtr6zx3++/y6CoQ4VS4qkfE FhAmKw0Y9vGjWUK2QiGsx99PB1Hng16Q5wgFlZPOIVtX3H38GG0jAH0V+Nzweuu66wu2b6I2Rt9 F33WIZnfmigDL1Jm1TIBDldXk4wUy+Ero+p4geRKAijQGOCKgY7LFOE+XxV+8/zIXEZvncbo+SE T2Kta+O1Q2RWGRIp0KQh8hLclN8P9QXjJyVYmcIWfr7GSdYIX9iOn9HDYALgaR4jf4LNBNOxR5m p5CK7n3HRsiB4A3UvgViwErQD96r/nbqfCzjnWoR4GUz+4t/tO4= X-Received: by 2002:a05:6820:221a:b0:696:1a25:fdc9 with SMTP id 006d021491bc7-69e47f2e023mr3481136eaf.28.1780538724651; Wed, 03 Jun 2026 19:05:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Fujii Masao Date: Thu, 4 Jun 2026 11:05:11 +0900 X-Gm-Features: AVHnY4JZhG2iEEBn6vtwOKVDYUP_PfqTem923o9g_6aQo7hx0CvxgTWJ3L08ylI Message-ID: Subject: Re: Fix column privileges for pg_subscription.subwalrcvtimeout To: Amit Kapila Cc: Nisha Moond , PostgreSQL Hackers Content-Type: multipart/mixed; boundary="000000000000315ffb065363fadf" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000315ffb065363fadf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 2, 2026 at 11:56=E2=80=AFAM Amit Kapila wrote: > > BTW, should we add a regression test for column privileges on pg_subscr= iption > > to help catch similar issues in the future? > > > > +1. It makes sense because I noticed that patch authors previously > also omitted this part though in most cases those are caught in > review. Agreed. I've added the regression test to the patch. Attached is the updated version. Regards, --=20 Fujii Masao --000000000000315ffb065363fadf Content-Type: application/octet-stream; name="v2-0001-Fix-pg_subscription-column-privileges-for-subwalr.patch" Content-Disposition: attachment; filename="v2-0001-Fix-pg_subscription-column-privileges-for-subwalr.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mpyuru6x0 RnJvbSBlOTE2N2M5MDI3MDE3YTA1MzMxMWE2NmRmMzk1YjkxNGUyZTJiMTFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaXNoYSBNb29uZCA8bmlzaGEubW9vbmQ0MTJAZ21haWwuY29t PgpEYXRlOiBNb24sIDEgSnVuIDIwMjYgMTg6NDM6NDIgKzA1MzAKU3ViamVjdDogW1BBVENIIHYy XSBGaXggcGdfc3Vic2NyaXB0aW9uIGNvbHVtbiBwcml2aWxlZ2VzIGZvciBzdWJ3YWxyY3Z0aW1l b3V0CgpUaGUgc3Vid2FscmN2dGltZW91dCBjb2x1bW4gd2FzIGFkZGVkIGJ5IGNvbW1pdCBmYjgw ZjM4LCBidXQgdGhlCmNvbHVtbi1sZXZlbCBwcml2aWxlZ2VzIG9uIHBnX3N1YnNjcmlwdGlvbiB3 ZXJlIG5vdCB1cGRhdGVkLiBBcyBhCnJlc3VsdCwgbm9uLXN1cGVydXNlcnMgY2Fubm90IHJlYWQg dGhlIGNvbHVtbiwgdW5saWtlIHRoZSBvdGhlcgpwdWJsaWNseSByZWFkYWJsZSBwZ19zdWJzY3Jp cHRpb24gY29sdW1ucy4KClRoaXMgY29tbWl0IGdyYW50cyBTRUxFQ1QgcHJpdmlsZWdlIG9uIHN1 YndhbHJjdnRpbWVvdXQgdG8gUFVCTElDLgoKQXV0aG9yOiBOaXNoYSBNb29uZCA8bmlzaGEubW9v bmQ0MTJAZ21haWwuY29tPgpSZXZpZXdlZC1ieTogQW1pdCBLYXBpbGEgPGFtaXQua2FwaWxhMTZA Z21haWwuY29tPgpSZXZpZXdlZC1ieTogRnVqaWkgTWFzYW8gPG1hc2FvLmZ1amlpQGdtYWlsLmNv bT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS9DQUJkQXJNNHVBPTZuQTBCdW5Kd3Vk aUVvWTFCY1dVU19val8ycGtFcV9kLVlkaUJKaHdAbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvYmFj a2VuZC9jYXRhbG9nL3N5c3RlbV92aWV3cy5zcWwgICAgICAgfCAgMyArKy0KIHNyYy90ZXN0L3Jl Z3Jlc3MvZXhwZWN0ZWQvc3Vic2NyaXB0aW9uLm91dCB8IDE1ICsrKysrKysrKysrKysrKwogc3Jj L3Rlc3QvcmVncmVzcy9zcWwvc3Vic2NyaXB0aW9uLnNxbCAgICAgIHwgMTEgKysrKysrKysrKysK IDMgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAt LWdpdCBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbCBiL3NyYy9iYWNrZW5k L2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbAppbmRleCA3M2ExYzFjNDY3MC4uOGYxMjliYWVjOTAg MTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbAorKysgYi9z cmMvYmFja2VuZC9jYXRhbG9nL3N5c3RlbV92aWV3cy5zcWwKQEAgLTE1MjcsNyArMTUyNyw4IEBA IEdSQU5UIFNFTEVDVCAob2lkLCBzdWJkYmlkLCBzdWJza2lwbHNuLCBzdWJuYW1lLCBzdWJvd25l ciwgc3ViZW5hYmxlZCwKICAgICAgICAgICAgICAgc3ViYmluYXJ5LCBzdWJzdHJlYW0sIHN1YnR3 b3BoYXNlc3RhdGUsIHN1YmRpc2FibGVvbmVyciwKIAkJCSAgc3VicGFzc3dvcmRyZXF1aXJlZCwg c3VicnVuYXNvd25lciwgc3ViZmFpbG92ZXIsCiAgICAgICAgICAgICAgIHN1YnJldGFpbmRlYWR0 dXBsZXMsIHN1Ym1heHJldGVudGlvbiwgc3VicmV0ZW50aW9uYWN0aXZlLAotICAgICAgICAgICAg ICBzdWJzZXJ2ZXIsIHN1YnNsb3RuYW1lLCBzdWJzeW5jY29tbWl0LCBzdWJwdWJsaWNhdGlvbnMs IHN1Ym9yaWdpbikKKyAgICAgICAgICAgICAgc3Vic2VydmVyLCBzdWJzbG90bmFtZSwgc3Vic3lu Y2NvbW1pdCwgc3Vid2FscmN2dGltZW91dCwKKyAgICAgICAgICAgICAgc3VicHVibGljYXRpb25z LCBzdWJvcmlnaW4pCiAgICAgT04gcGdfc3Vic2NyaXB0aW9uIFRPIHB1YmxpYzsKIAogQ1JFQVRF IFZJRVcgcGdfc3RhdF9zdWJzY3JpcHRpb25fc3RhdHMgQVMKZGlmZiAtLWdpdCBhL3NyYy90ZXN0 L3JlZ3Jlc3MvZXhwZWN0ZWQvc3Vic2NyaXB0aW9uLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhw ZWN0ZWQvc3Vic2NyaXB0aW9uLm91dAppbmRleCA3ZTNjYWJkYjkzZi4uODQ4MTA1NmE3MDIgMTAw NjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3Vic2NyaXB0aW9uLm91dAorKysg Yi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N1YnNjcmlwdGlvbi5vdXQKQEAgLTQ3LDYgKzQ3 LDIxIEBAIFNFTEVDVCBvYmpfZGVzY3JpcHRpb24ocy5vaWQsICdwZ19zdWJzY3JpcHRpb24nKSBG Uk9NIHBnX3N1YnNjcmlwdGlvbiBzOwogIHRlc3Qgc3Vic2NyaXB0aW9uCiAoMSByb3cpCiAKKy0t IENoZWNrIHRoYXQgb25seSBzdWJjb25uaW5mbyBpcyBub3QgcHVibGljbHkgcmVhZGFibGUgaW4g cGdfc3Vic2NyaXB0aW9uLgorU0VMRUNUIGNvdW50KCopID0gMCBBUyBvaworICAgIEZST00gcGdf YXR0cmlidXRlCisgICAgV0hFUkUgYXR0cmVsaWQgPSAncGdfY2F0YWxvZy5wZ19zdWJzY3JpcHRp b24nOjpyZWdjbGFzcyBBTkQgYXR0bnVtID4gMCBBTkQgTk9UIGF0dGlzZHJvcHBlZAorICAgICAg ICBBTkQgKChhdHRuYW1lID0gJ3N1YmNvbm5pbmZvJworCSAgICAgICAgQU5EIGhhc19jb2x1bW5f cHJpdmlsZWdlKCdyZWdyZXNzX3N1YnNjcmlwdGlvbl91c2VyX2R1bW15JywKKwkJICAgICdwZ19j YXRhbG9nLnBnX3N1YnNjcmlwdGlvbicsIGF0dG5hbWUsICdTRUxFQ1QnKSkKKyAgICAgICAgICAg IE9SIChhdHRuYW1lIDw+ICdzdWJjb25uaW5mbycKKwkgICAgICAgIEFORCBOT1QgaGFzX2NvbHVt bl9wcml2aWxlZ2UoJ3JlZ3Jlc3Nfc3Vic2NyaXB0aW9uX3VzZXJfZHVtbXknLAorCQkgICAgJ3Bn X2NhdGFsb2cucGdfc3Vic2NyaXB0aW9uJywgYXR0bmFtZSwgJ1NFTEVDVCcpKSk7Cisgb2sgCist LS0tCisgdAorKDEgcm93KQorCiAtLSBDaGVjayBpZiB0aGUgc3Vic2NyaXB0aW9uIHN0YXRzIGFy ZSBjcmVhdGVkIGFuZCBzdGF0c19yZXNldCBpcyB1cGRhdGVkCiAtLSBieSBwZ19zdGF0X3Jlc2V0 X3N1YnNjcmlwdGlvbl9zdGF0cygpLgogU0VMRUNUIHN1Ym5hbWUsIHN0YXRzX3Jlc2V0IElTIE5V TEwgc3RhdHNfcmVzZXRfaXNfbnVsbCBGUk9NIHBnX3N0YXRfc3Vic2NyaXB0aW9uX3N0YXRzIFdI RVJFIHN1Ym5hbWUgPSAncmVncmVzc190ZXN0c3ViJzsKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3Jl Z3Jlc3Mvc3FsL3N1YnNjcmlwdGlvbi5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9zdWJzY3Jp cHRpb24uc3FsCmluZGV4IDZjM2Q5NjMyZThhLi4zNzRmYWQ2YWE3YiAxMDA2NDQKLS0tIGEvc3Jj L3Rlc3QvcmVncmVzcy9zcWwvc3Vic2NyaXB0aW9uLnNxbAorKysgYi9zcmMvdGVzdC9yZWdyZXNz L3NxbC9zdWJzY3JpcHRpb24uc3FsCkBAIC00Miw2ICs0MiwxNyBAQCBDUkVBVEUgU1VCU0NSSVBU SU9OIHJlZ3Jlc3NfdGVzdHN1YiBDT05ORUNUSU9OICdkYm5hbWU9cmVncmVzc19kb2Vzbm90ZXhp c3QnIFBVQgogQ09NTUVOVCBPTiBTVUJTQ1JJUFRJT04gcmVncmVzc190ZXN0c3ViIElTICd0ZXN0 IHN1YnNjcmlwdGlvbic7CiBTRUxFQ1Qgb2JqX2Rlc2NyaXB0aW9uKHMub2lkLCAncGdfc3Vic2Ny aXB0aW9uJykgRlJPTSBwZ19zdWJzY3JpcHRpb24gczsKIAorLS0gQ2hlY2sgdGhhdCBvbmx5IHN1 YmNvbm5pbmZvIGlzIG5vdCBwdWJsaWNseSByZWFkYWJsZSBpbiBwZ19zdWJzY3JpcHRpb24uCitT RUxFQ1QgY291bnQoKikgPSAwIEFTIG9rCisgICAgRlJPTSBwZ19hdHRyaWJ1dGUKKyAgICBXSEVS RSBhdHRyZWxpZCA9ICdwZ19jYXRhbG9nLnBnX3N1YnNjcmlwdGlvbic6OnJlZ2NsYXNzIEFORCBh dHRudW0gPiAwIEFORCBOT1QgYXR0aXNkcm9wcGVkCisgICAgICAgIEFORCAoKGF0dG5hbWUgPSAn c3ViY29ubmluZm8nCisJICAgICAgICBBTkQgaGFzX2NvbHVtbl9wcml2aWxlZ2UoJ3JlZ3Jlc3Nf c3Vic2NyaXB0aW9uX3VzZXJfZHVtbXknLAorCQkgICAgJ3BnX2NhdGFsb2cucGdfc3Vic2NyaXB0 aW9uJywgYXR0bmFtZSwgJ1NFTEVDVCcpKQorICAgICAgICAgICAgT1IgKGF0dG5hbWUgPD4gJ3N1 YmNvbm5pbmZvJworCSAgICAgICAgQU5EIE5PVCBoYXNfY29sdW1uX3ByaXZpbGVnZSgncmVncmVz c19zdWJzY3JpcHRpb25fdXNlcl9kdW1teScsCisJCSAgICAncGdfY2F0YWxvZy5wZ19zdWJzY3Jp cHRpb24nLCBhdHRuYW1lLCAnU0VMRUNUJykpKTsKKwogLS0gQ2hlY2sgaWYgdGhlIHN1YnNjcmlw dGlvbiBzdGF0cyBhcmUgY3JlYXRlZCBhbmQgc3RhdHNfcmVzZXQgaXMgdXBkYXRlZAogLS0gYnkg cGdfc3RhdF9yZXNldF9zdWJzY3JpcHRpb25fc3RhdHMoKS4KIFNFTEVDVCBzdWJuYW1lLCBzdGF0 c19yZXNldCBJUyBOVUxMIHN0YXRzX3Jlc2V0X2lzX251bGwgRlJPTSBwZ19zdGF0X3N1YnNjcmlw dGlvbl9zdGF0cyBXSEVSRSBzdWJuYW1lID0gJ3JlZ3Jlc3NfdGVzdHN1Yic7Ci0tIAoyLjUzLjAK Cg== --000000000000315ffb065363fadf--