MIME-Version: 1.0
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 19 Mar 2026 01:05:29 +0900
Message-ID: 
 <CAHGQGwFzNYroAxSoyJhqTU-pH=t4Ej6RyvhVmBZ91Exj_TPMMQ@mail.gmail.com>
Subject: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during
 promotion?
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000ad48ed064d4e9f1e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwFzNYroAxSoyJhqTU-pH%3Dt4Ej6RyvhVmBZ91Exj_TPMMQ%40mail.gmail.com>
Precedence: bulk

--000000000000ad48ed064d4e9f1e
Content-Type: text/plain; charset="UTF-8"

Hi,

I noticed that during standby promotion the startup process sends SIGUSR1 to
the slotsync worker to make it exit. Is there a reason for using SIGUSR1?

If the slotsync worker is blocked waiting for input from the primary (e.g.,
due to a network outage between the primary and standby), SIGUSR1 won't
interrupt the wait. As a result, the worker can remain stuck and delay
promotion for a long time.

Would it make sense to send SIGTERM instead, so the worker can exit promptly
even while waiting? I've attached a WIP patch that does this. I haven't updated
the source comments yet, but I can do so if we agree on the approach.

SIGTERM alone is not sufficient, though. A new slotsync worker could start
immediately after the old one exits and block promotion again. To address this,
the patch makes a newly started worker exit immediately if promotion is
in progress.

Thoughts?

Regards,

-- 
Fujii Masao

--000000000000ad48ed064d4e9f1e
Content-Type: application/octet-stream;
	name="v1-0001-Use-SIGTERM-to-stop-slotsync-worker-during-standb.patch"
Content-Disposition: attachment;
	filename="v1-0001-Use-SIGTERM-to-stop-slotsync-worker-during-standb.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmw8g33c0>
X-Attachment-Id: f_mmw8g33c0

RnJvbSBjZGNjZTI0MGZjYWJmM2M0ZjkxYWQ2OTMxYjQ1MWJjNzdkYjc2Y2FmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IFRodSwgMTkgTWFyIDIwMjYgMDA6NTA6MDcgKzA5MDAKU3ViamVjdDogW1BBVENIIHYxXSBV
c2UgU0lHVEVSTSB0byBzdG9wIHNsb3RzeW5jIHdvcmtlciBkdXJpbmcgc3RhbmRieQogcHJvbW90
aW9uCgpQcmV2aW91c2x5LCB3aGVuIHN0YW5kYnkgcHJvbW90aW9uIHdhcyByZXF1ZXN0ZWQsIHRo
ZSBzdGFydHVwIHByb2Nlc3Mgc2VudApTSUdVU1IxIHRvIHRoZSBzbG90c3luYyB3b3JrZXIgKG9y
IGEgYmFja2VuZCBwZXJmb3JtaW5nIHNsb3Qgc3luY2hyb25pemF0aW9uKQp0byBtYWtlIGl0IGV4
aXQuIFRoaXMgZ2VuZXJhbGx5IHdvcmtlZCwgYnV0IGlmIHRoZSBzbG90c3luYyB3b3JrZXIgd2Fz
IGJsb2NrZWQKd2FpdGluZyBmb3IgaW5wdXQgZnJvbSB0aGUgcHJpbWFyeSwgU0lHVVNSMSB3b3Vs
ZCBub3QgaW50ZXJydXB0IHRoZSB3YWl0LgpBcyBhIHJlc3VsdCwgdGhlIHdvcmtlciBjb3VsZCBy
ZW1haW4gc3R1Y2ssIHByZXZlbnRpbmcgcHJvbW90aW9uIGZyb20KY29tcGxldGluZyBmb3IgYSBs
b25nIHRpbWUuCgpUaGlzIGNvbW1pdCBmaXhlcyB0aGUgaXNzdWUgYnkgaGF2aW5nIHRoZSBzdGFy
dHVwIHByb2Nlc3Mgc2VuZCBTSUdURVJNCmluc3RlYWQgb2YgU0lHVVNSMSwgYWxsb3dpbmcgdGhl
IHNsb3RzeW5jIHdvcmtlciAob3IgYmFja2VuZCkgdG8gZXhpdCBwcm9tcHRseQpldmVuIHdoaWxl
IHdhaXRpbmcgZm9yIGlucHV0LgoKQWRkaXRpb25hbGx5LCBuZXcgc2xvdHN5bmMgd29ya2VyIGNv
dWxkIGxhdW5jaCBpbW1lZGlhdGVseSBhZnRlciB0aGUgb2xkIG9uZQp3YXMgdGVybWluYXRlZCwg
d2hpY2ggY291bGQgYWdhaW4gYmxvY2sgcHJvbW90aW9uLiBUbyBwcmV2ZW50IHRoaXMsIGEgc2xv
dHN5bmMKd29ya2VyIHRoYXQgc3RhcnRzIHVwIGR1cmluZyBwcm9tb3Rpb24gbm93IGRldGVjdHMg
dGhpcyBjb25kaXRpb24gYW5kIGV4aXRzCmltbWVkaWF0ZWx5LgoKVGhpcyBlbnN1cmVzIHRoYXQg
c3RhbmRieSBwcm9tb3Rpb24gaXMgbm90IGRlbGF5ZWQgYnkgc3R1Y2sgb3IgbmV3bHkgc3RhcnRl
ZApzbG90c3luYyB3b3JrZXJzLgotLS0KIHNyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwv
c2xvdHN5bmMuYyB8IDI5ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA3
IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5k
L3JlcGxpY2F0aW9uL2xvZ2ljYWwvc2xvdHN5bmMuYyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9u
L2xvZ2ljYWwvc2xvdHN5bmMuYwppbmRleCBlNzVkYjY5ZTNmNi4uM2QxOGZmNGE2NmUgMTAwNjQ0
Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvc2xvdHN5bmMuYworKysgYi9z
cmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL3Nsb3RzeW5jLmMKQEAgLTEyOTgsMjcgKzEy
OTgsNiBAQCBQcm9jZXNzU2xvdFN5bmNJbnRlcnJ1cHRzKHZvaWQpCiB7CiAJQ0hFQ0tfRk9SX0lO
VEVSUlVQVFMoKTsKIAotCWlmIChTbG90U3luY0N0eC0+c3RvcFNpZ25hbGVkKQotCXsKLQkJaWYg
KEFtTG9naWNhbFNsb3RTeW5jV29ya2VyUHJvY2VzcygpKQotCQl7Ci0JCQllcmVwb3J0KExPRywK
LQkJCQkJZXJybXNnKCJyZXBsaWNhdGlvbiBzbG90IHN5bmNocm9uaXphdGlvbiB3b3JrZXIgd2ls
bCBzdG9wIGJlY2F1c2UgcHJvbW90aW9uIGlzIHRyaWdnZXJlZCIpKTsKLQotCQkJcHJvY19leGl0
KDApOwotCQl9Ci0JCWVsc2UKLQkJewotCQkJLyoKLQkJCSAqIEZvciB0aGUgYmFja2VuZCBleGVj
dXRpbmcgU1FMIGZ1bmN0aW9uCi0JCQkgKiBwZ19zeW5jX3JlcGxpY2F0aW9uX3Nsb3RzKCkuCi0J
CQkgKi8KLQkJCWVyZXBvcnQoRVJST1IsCi0JCQkJCWVycmNvZGUoRVJSQ09ERV9PQkpFQ1RfTk9U
X0lOX1BSRVJFUVVJU0lURV9TVEFURSksCi0JCQkJCWVycm1zZygicmVwbGljYXRpb24gc2xvdCBz
eW5jaHJvbml6YXRpb24gd2lsbCBzdG9wIGJlY2F1c2UgcHJvbW90aW9uIGlzIHRyaWdnZXJlZCIp
KTsKLQkJfQotCX0KLQogCWlmIChDb25maWdSZWxvYWRQZW5kaW5nKQogCQlzbG90c3luY19yZXJl
YWRfY29uZmlnKCk7CiB9CkBAIC0xNDI3LDYgKzE0MDYsMTIgQEAgY2hlY2tfYW5kX3NldF9zeW5j
X2luZm8ocGlkX3Qgc3luY19wcm9jZXNzX3BpZCkKIHsKIAlTcGluTG9ja0FjcXVpcmUoJlNsb3RT
eW5jQ3R4LT5tdXRleCk7CiAKKwlpZiAoU2xvdFN5bmNDdHgtPnN0b3BTaWduYWxlZCkKKwl7CisJ
CVNwaW5Mb2NrUmVsZWFzZSgmU2xvdFN5bmNDdHgtPm11dGV4KTsKKwkJcHJvY19leGl0KDApOwor
CX0KKwogCWlmIChTbG90U3luY0N0eC0+c3luY2luZykKIAl7CiAJCVNwaW5Mb2NrUmVsZWFzZSgm
U2xvdFN5bmNDdHgtPm11dGV4KTsKQEAgLTE3NTIsNyArMTczNyw3IEBAIFNodXREb3duU2xvdFN5
bmModm9pZCkKIAkgKiBkZXRlY3RpbmcgdGhhdCB0aGUgc3RvcFNpZ25hbGVkIGZsYWcgaXMgc2V0
IHRvIHRydWUuCiAJICovCiAJaWYgKHN5bmNfcHJvY2Vzc19waWQgIT0gSW52YWxpZFBpZCkKLQkJ
a2lsbChzeW5jX3Byb2Nlc3NfcGlkLCBTSUdVU1IxKTsKKwkJa2lsbChzeW5jX3Byb2Nlc3NfcGlk
LCBTSUdURVJNKTsKIAogCS8qIFdhaXQgZm9yIHNsb3Qgc3luYyB0byBlbmQgKi8KIAlmb3IgKDs7
KQotLSAKMi41MS4yCgo=
--000000000000ad48ed064d4e9f1e--