MIME-Version: 1.0
References: 
 <CAEudQAprLegxufoi93JuFVkCDmjT5wtGhu3gxT-E1Fg+1DGrag@mail.gmail.com>
In-Reply-To: 
 <CAEudQAprLegxufoi93JuFVkCDmjT5wtGhu3gxT-E1Fg+1DGrag@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Tue, 17 Mar 2026 08:07:47 +0900
Message-ID: 
 <CAHGQGwG2iC2LeizHiCezb-D=G6RE-ACXbFVfeAtzXwjnMTveGA@mail.gmail.com>
Subject: Re: Avoid resource leak (contrib/postgres_fdw/connection.c)
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwG2iC2LeizHiCezb-D%3DG6RE-ACXbFVfeAtzXwjnMTveGA%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 16, 2026 at 8:46=E2=80=AFPM Ranier Vilela <ranier.vf@gmail.com>=
 wrote:
>
> Hi.
>
> Per Coverity.
>
> CID 1645716: (#1 of 1): Resource leak (RESOURCE_LEAK)
> 8. leaked_storage: Variable str going out of scope leaks the storage str.=
data points to.
>
> The function *postgres_fdw_connection* leaks the contents of
> var str.data
> Once that function *cstring_to_text* palloc the contents
> must be necessary to free the var str.data.

It seems that postgres_fdw_connection() is expected to be called by
ForeignServerConnectionString() via OidFunctionCall3(),
and to allocate memory (including str.data) in the FDWConnectionContext
memory context created by ForeignServerConnectionString().

After calling postgres_fdw_connection(), ForeignServerConnectionString()
deletes FDWConnectionContext. So it seems to me that any memory
allocated in that context, including str.data, would not leak. No?

Regards,

--=20
Fujii Masao