MIME-Version: 1.0
References: 
 <CAA5RZ0v0OPGyDpwxkX81CtTt9xsj9-TNxhm=8JdOvEKPsVVFNg@mail.gmail.com>
 <CAA5RZ0vwTY=cVUWSiCFQbz9m5-DQoM=ELLz+ggn+SR-R9H7xpQ@mail.gmail.com>
In-Reply-To: 
 <CAA5RZ0vwTY=cVUWSiCFQbz9m5-DQoM=ELLz+ggn+SR-R9H7xpQ@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 13 Mar 2026 10:39:36 +0900
Message-ID: 
 <CAHGQGwGA5d0uigSj78xCyjPdc+j3V-qvxk=_NfbV6ScOrGQvbQ@mail.gmail.com>
Subject: Re: Add missing stats_reset column to pg_statio_all_sequences view
To: Sami Imseih <samimseih@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 shihao zhong <zhong950419@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwGA5d0uigSj78xCyjPdc%2Bj3V-qvxk%3D_NfbV6ScOrGQvbQ%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 13, 2026 at 7:44=E2=80=AFAM Sami Imseih <samimseih@gmail.com> w=
rote:
>
> After Creating this thread and the CF entry for it [1], I realized Shihao=
 also
> created [2] yesterday. Sorry about that.
>
> We can stick with 6582 and Shihao can also get author credit.

Thanks to both Shihao and Sami for proposing patches!

Since the two patches are almost the same, I reviewed Sami's patch.
It looks good to me overall. One comment: for the tests added to stats.sql,
it would be better to verify that the stats of the specified sequence are
actually reset by using pg_stat_reset_single_table_counters().

Also, the documentation for pg_stat_reset_single_table_counters() should
mention that it can reset sequence statistics as well.

Regards,

--=20
Fujii Masao