MIME-Version: 1.0
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 9 Jul 2026 11:24:31 +0900
Message-ID: 
 <CAHGQGwGDHAQw=bmpRzk+EmKzVtxZiD5YDurMUffBMwr6WXugQA@mail.gmail.com>
Subject: Fix data checksum processing for temp relations and dropped databases
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000b72a2f065624537d"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwGDHAQw%3DbmpRzk%2BEmKzVtxZiD5YDurMUffBMwr6WXugQA%40mail.gmail.com>
Precedence: bulk

--000000000000b72a2f065624537d
Content-Type: text/plain; charset="UTF-8"

Hi,

While reading the data checksum code, I found that BuildRelationList()
filters out non-temporary relations without storage, but does not
apply the same filtering to temporary relations. As a result, temporary
relations without storage, such as temporary views, are included in
the list of relations to wait for even though they are irrelevant to
checksum processing. For example, enabling data checksums can
unnecessarily wait for a long-lived session that owns only a temporary view.

I think BuildRelationList() should exclude temporary relations without
RELKIND_HAS_STORAGE(), matching the existing behavior for
non-temporary relations. Attached patch implements this.

Also there seems a small race condition. When enabling data checksums
online, the launcher assigns the first worker to process the shared catalogs
and prevents later workers from doing so. However, if that worker's
database is dropped after it has been selected for processing but
before checksum processing begins (a very small window), the worker
fails without processing the shared catalogs, yet they are still marked
as processed. As a result, later workers skip them, and checksum
enabling can complete successfully even though the shared catalogs
were never processed.

To fix this, we should mark the shared catalogs as processed only after
a worker completes successfully. Attached patch also implements this.

Thoughts?

Regards,

-- 
Fujii Masao

--000000000000b72a2f065624537d
Content-Type: application/octet-stream;
	name="v1-0001-Fix-data-checksum-processing-for-temp-relations-a.patch"
Content-Disposition: attachment;
	filename="v1-0001-Fix-data-checksum-processing-for-temp-relations-a.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mrcvvfng0>
X-Attachment-Id: f_mrcvvfng0

RnJvbSA2MDk1Y2M0OWRjZTExZTg4ODQwZWQwYzk0MDcxYjEyNGExMTE0NDYxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IFdlZCwgOCBKdWwgMjAyNiAyMzo1MjozOSArMDkwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIEZp
eCBkYXRhIGNoZWNrc3VtIHByb2Nlc3NpbmcgZm9yIHRlbXAgcmVsYXRpb25zIGFuZAogZHJvcHBl
ZCBkYXRhYmFzZXMKCldoZW4gYnVpbGRpbmcgdGhlIGxpc3Qgb2YgdGVtcG9yYXJ5IHJlbGF0aW9u
cyB0byB3YWl0IGZvciwgdGhlIGNvZGUKcHJldmlvdXNseSBpbmNsdWRlZCB0ZW1wb3JhcnkgcmVs
YXRpb25zIHdpdGhvdXQgc3RvcmFnZSwgc3VjaCBhcwp0ZW1wb3Jhcnkgdmlld3MsIGV2ZW4gdGhv
dWdoIHRoZXkgYXJlIGlycmVsZXZhbnQgdG8gY2hlY2tzdW0KcHJvY2Vzc2luZy4gQXMgYSByZXN1
bHQsIGVuYWJsaW5nIGRhdGEgY2hlY2tzdW1zIGNvdWxkIHdhaXQgZm9yIGEKbG9uZy1saXZlZCBz
ZXNzaW9uIHRoYXQgb3duZWQgb25seSBhIHRlbXBvcmFyeSB2aWV3LgoKVGhpcyBjb21taXQgZml4
ZXMgdGhlIGlzc3VlIGJ5IGZpbHRlcmluZyB0ZW1wb3JhcnkgcmVsYXRpb25zIHdpdGggc3RvcmFn
ZQpvbmx5LCBtYXRjaGluZyB0aGUgZXhpc3RpbmcgYmVoYXZpb3IgZm9yIG5vbi10ZW1wb3Jhcnkg
cmVsYXRpb25zLgoKQWxzbywgd2hlbiBlbmFibGluZyBkYXRhIGNoZWNrc3VtcyBvbmxpbmUsIHRo
ZSBsYXVuY2hlciBhc3NpZ25zIHRoZQpmaXJzdCB3b3JrZXIgdG8gcHJvY2VzcyBzaGFyZWQgY2F0
YWxvZ3MgYW5kIHByZXZlbnRzIGxhdGVyIHdvcmtlcnMgZnJvbQpkb2luZyBzby4gUHJldmlvdXNs
eSwgaWYgdGhhdCB3b3JrZXIncyBkYXRhYmFzZSB3YXMgZHJvcHBlZCBhZnRlciBpdApoYWQgYmVl
biBzZWxlY3RlZCBmb3IgcHJvY2Vzc2luZyBidXQgYmVmb3JlIGNoZWNrc3VtIHByb2Nlc3Npbmcg
YmVnYW4sCnRoZSB3b3JrZXIgZmFpbGVkIHdpdGhvdXQgcHJvY2Vzc2luZyB0aGUgc2hhcmVkIGNh
dGFsb2dzLCB5ZXQgdGhleSB3ZXJlCnN0aWxsIG1hcmtlZCBhcyBwcm9jZXNzZWQuIEFzIGEgcmVz
dWx0LCBsYXRlciB3b3JrZXJzIHNraXBwZWQgdGhlbSwgYW5kCmNoZWNrc3VtIGVuYWJsaW5nIGNv
dWxkIGNvbXBsZXRlIHN1Y2Nlc3NmdWxseSBldmVuIHRob3VnaCB0aGUgc2hhcmVkCmNhdGFsb2dz
IGhhZCBuZXZlciBiZWVuIHByb2Nlc3NlZC4KClRoaXMgY29tbWl0IGZpeGVzIHRoZSBpc3N1ZSBi
eSBtYXJraW5nIHNoYXJlZCBjYXRhbG9ncyBhcyBwcm9jZXNzZWQKb25seSBhZnRlciBhIHdvcmtl
ciBjb21wbGV0ZXMgc3VjY2Vzc2Z1bGx5LgotLS0KIHNyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvZGF0
YWNoZWNrc3VtX3N0YXRlLmMgfCAyMiArKysrKysrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFu
Z2VkLCAxNCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9i
YWNrZW5kL3Bvc3RtYXN0ZXIvZGF0YWNoZWNrc3VtX3N0YXRlLmMgYi9zcmMvYmFja2VuZC9wb3N0
bWFzdGVyL2RhdGFjaGVja3N1bV9zdGF0ZS5jCmluZGV4IDY4NTU3YzE2Y2I5Li4yYjNlMWRmNmNm
MSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9kYXRhY2hlY2tzdW1fc3RhdGUu
YworKysgYi9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL2RhdGFjaGVja3N1bV9zdGF0ZS5jCkBAIC0x
MzI5LDkgKzEzMjksMTIgQEAgUHJvY2Vzc0FsbERhdGFiYXNlcyh2b2lkKQogCQkgKiBXaGVuIG9u
ZSBkYXRhYmFzZSBoYXMgY29tcGxldGVkLCBpdCB3aWxsIGhhdmUgZG9uZSBzaGFyZWQgY2F0YWxv
Z3MKIAkJICogc28gd2UgZG9uJ3QgaGF2ZSB0byBwcm9jZXNzIHRoZW0gYWdhaW4uCiAJCSAqLwot
CQlMV0xvY2tBY3F1aXJlKERhdGFDaGVja3N1bXNXb3JrZXJMb2NrLCBMV19FWENMVVNJVkUpOwot
CQlEYXRhQ2hlY2tzdW1TdGF0ZS0+cHJvY2Vzc19zaGFyZWRfY2F0YWxvZ3MgPSBmYWxzZTsKLQkJ
TFdMb2NrUmVsZWFzZShEYXRhQ2hlY2tzdW1zV29ya2VyTG9jayk7CisJCWlmIChyZXN1bHQgPT0g
REFUQUNIRUNLU1VNU1dPUktFUl9TVUNDRVNTRlVMKQorCQl7CisJCQlMV0xvY2tBY3F1aXJlKERh
dGFDaGVja3N1bXNXb3JrZXJMb2NrLCBMV19FWENMVVNJVkUpOworCQkJRGF0YUNoZWNrc3VtU3Rh
dGUtPnByb2Nlc3Nfc2hhcmVkX2NhdGFsb2dzID0gZmFsc2U7CisJCQlMV0xvY2tSZWxlYXNlKERh
dGFDaGVja3N1bXNXb3JrZXJMb2NrKTsKKwkJfQogCX0KIAogCUZyZWVEYXRhYmFzZUxpc3QoRGF0
YWJhc2VMaXN0KTsKQEAgLTE0NjksMTEgKzE0NzIsMTEgQEAgRnJlZURhdGFiYXNlTGlzdChMaXN0
ICpkYmxpc3QpCiAgKgkJQ29tcGlsZSBhIGxpc3Qgb2YgcmVsYXRpb25zIGluIHRoZSBkYXRhYmFz
ZQogICoKICAqIFJldHVybnMgYSBsaXN0IG9mIE9JRHMgZm9yIHRoZSByZXF1ZXN0ZWQgcmVsYXRp
b24gdHlwZXMuIElmIHRlbXBfcmVsYXRpb25zCi0gKiBpcyBUcnVlIHRoZW4gb25seSB0ZW1wb3Jh
cnkgcmVsYXRpb25zIGFyZSByZXR1cm5lZC4gSWYgdGVtcF9yZWxhdGlvbnMgaXMKLSAqIEZhbHNl
IHRoZW4gbm9uLXRlbXBvcmFyeSByZWxhdGlvbnMgd2hpY2ggaGF2ZSBkYXRhIGNoZWNrc3VtcyBh
cmUgcmV0dXJuZWQuCi0gKiBJZiBpbmNsdWRlX3NoYXJlZCBpcyBUcnVlIHRoZW4gc2hhcmVkIHJl
bGF0aW9ucyBhcmUgaW5jbHVkZWQgYXMgd2VsbCBpbiBhCi0gKiBub24tdGVtcG9yYXJ5IGxpc3Qu
IGluY2x1ZGVfc2hhcmVkIGhhcyBubyByZWxldmFuY2Ugd2hlbiBidWlsZGluZyBhIGxpc3Qgb2YK
LSAqIHRlbXBvcmFyeSByZWxhdGlvbnMuCisgKiBpcyBUcnVlIHRoZW4gb25seSB0ZW1wb3Jhcnkg
cmVsYXRpb25zIHdpdGggc3RvcmFnZSBhcmUgcmV0dXJuZWQuICBJZgorICogdGVtcF9yZWxhdGlv
bnMgaXMgRmFsc2UgdGhlbiBub24tdGVtcG9yYXJ5IHJlbGF0aW9ucyB3aXRoIHN0b3JhZ2UgYXJl
CisgKiByZXR1cm5lZC4gIElmIGluY2x1ZGVfc2hhcmVkIGlzIFRydWUgdGhlbiBzaGFyZWQgcmVs
YXRpb25zIGFyZSBpbmNsdWRlZCBhcworICogd2VsbCBpbiBhIG5vbi10ZW1wb3JhcnkgbGlzdC4g
aW5jbHVkZV9zaGFyZWQgaGFzIG5vIHJlbGV2YW5jZSB3aGVuIGJ1aWxkaW5nCisgKiBhIGxpc3Qg
b2YgdGVtcG9yYXJ5IHJlbGF0aW9ucy4KICAqLwogc3RhdGljIExpc3QgKgogQnVpbGRSZWxhdGlv
bkxpc3QoYm9vbCB0ZW1wX3JlbGF0aW9ucywgYm9vbCBpbmNsdWRlX3NoYXJlZCkKQEAgLTE0OTks
NiArMTUwMiw5IEBAIEJ1aWxkUmVsYXRpb25MaXN0KGJvb2wgdGVtcF9yZWxhdGlvbnMsIGJvb2wg
aW5jbHVkZV9zaGFyZWQpCiAJCXsKIAkJCWlmICghdGVtcF9yZWxhdGlvbnMpCiAJCQkJY29udGlu
dWU7CisKKwkJCWlmICghUkVMS0lORF9IQVNfU1RPUkFHRShwZ2MtPnJlbGtpbmQpKQorCQkJCWNv
bnRpbnVlOwogCQl9CiAJCWVsc2UKIAkJewotLSAKMi41NS4wCgo=
--000000000000b72a2f065624537d--