public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Ilia Evdokimov <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Wrong argument name in error message from attribute_stats functions
Date: Fri, 10 Jul 2026 21:32:32 +0900
Message-ID: <CAHGQGwGDpHB4eKnk=GPhOZb1tCq0hKnwQmL4Aj7aprnL7itX1w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Fri, Jul 10, 2026 at 9:11 PM Ilia Evdokimov
<[email protected]> wrote:
>
> Hi,
>
> While using pg_clear_attribute_stats() I noticed weird printing:
>
> ```
> CREATE TABLE t(a int);
> SELECT pg_clear_attribute_stats(NULL, 't', 'a', false);
> ERROR:  argument "relation" must not be null
> ```
>
> NULL was passed for `schemaname`, not for a `relation` argument. This
> comes from cleararginfo[], where both the schema and relname entries are
> labeled `relation`.
>
> In v1-patch I propose naming these the same way `pg_proc.dat` does, i.e.
> `schemaname` and `relname`.

Thanks for the patch! LGTM.

Regards,

-- 
Fujii Masao

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Wrong argument name in error message from attribute_stats functions
  In-Reply-To: <CAHGQGwGDpHB4eKnk=GPhOZb1tCq0hKnwQmL4Aj7aprnL7itX1w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox