Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDE5K-002knJ-0v for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Apr 2026 04:12:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wDE5J-003gJm-1m for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Apr 2026 04:12:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDE5J-003gJe-0o for pgsql-hackers@lists.postgresql.org; Thu, 16 Apr 2026 04:12:09 +0000 Received: from mail-oo1-xc2f.google.com ([2607:f8b0:4864:20::c2f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wDE5G-00000001LTa-3hG6 for pgsql-hackers@lists.postgresql.org; Thu, 16 Apr 2026 04:12:08 +0000 Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-685013eb590so166735eaf.1 for ; Wed, 15 Apr 2026 21:12:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776312724; cv=none; d=google.com; s=arc-20240605; b=Ovc5FsoB5bAdAnlfd4OcZHpi2HCTcWMy11Ilu63cy0MgkzwTWGPdvofLCvM/AwmrDk LUKqVDT5CVjX4aOQo98MEXyUp+slzHHCwWoGuwDLXIuwB6k/RRom577620wc91qK8ibz X2diAbf1PAWO/Y+oE4h7ZxWT8fRvALH9oHjHY24Uv8sVfERmVKvcxAX38OirsQV8ftny NNfxR1ykCnSVOFcYZW6wv+9kFQ/owGujDCS/LzoucyKl03XArZlkQLXTWvAvgk9g9TRU jbP3MnWnjuZJbZvMRr6GREec/x+YtuqHMXxdu5meOXiQSo+EO/NptKBTs6BjzFj1E+ae d2uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MqKBhr++X8ipoaM+GsMTgg/y2NNFBRXgFNIgYblqPgQ=; fh=PnOk7+UDmJ4DVUtTV3E3M3h9qbJswshMAk3PCMo9qiU=; b=FTonWrLfTU0E80VKxgBJHBNvRLLG3AzPxgfXwiIWADSlRUKdG8fBcbadPjMVhq5u/j f6bRDF/CQbKmgr5oCAUdNc6CTTlIROKvRdknrL0Kt56SeSMCiwWjWzAw9wR+Qs+dId+h KgK1+GPVShIvdH0TEOn5GAuZfHT4EQo9wWYMJlA8kkn6tBbRZtEvZdhGbLhfAGGv5Njb LrD1J9viQNMsbFpNCYHtu6z2FisjR2jM3U4BbmuweU32AiRvUG5Z0zpO4LBWYGihTMcj yZFsWVXGJ2N00B6xUmTCHuMdh6EYKleifN1v/1N1GNvJhNRlZ3TDM2CRhvZ5Mv98drH1 7Ydg==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776312724; x=1776917524; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MqKBhr++X8ipoaM+GsMTgg/y2NNFBRXgFNIgYblqPgQ=; b=s1nJWVf2bSiaH2rDog8im1CXwyks15MXDWkix0CCxzB9BoIfvb29BJqQR07pSAchEg DpKMQfgY3W6y5Qztn2d981MQgKzgAxigVHoa7MfIKKO0MvJ3UqF1ksqdaEKV3UWY7DLZ C5qZuB/JeKSihtbZBoNJGe5Ld9yRki5bd5A2OWPkcK/1b9zEAIVsBCieHbDe6/cWP59Q 3ztc1mVDa1TPw7jnJax3j020Gyze5/G1xL2wXz1d8fZfkkGWHHcPPKTqk97xIwfQXjwb VHmK+0mtI5hH5rg7R6pKX7irSPlWlwjajbo6VJr1QgbJ88Lrekgn5w8EMAuY2v4iMp0T kk4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776312724; x=1776917524; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MqKBhr++X8ipoaM+GsMTgg/y2NNFBRXgFNIgYblqPgQ=; b=b+UmdypxHYm6SEvC1gsasc3wG9/HasMwcnoICZ7l2GL4HFDqcgvckDlDJSuXAt3cQZ oySlxGIbS1rgoFThYKydT3Ehh+UUts9BrPeTu9vBZNI4uzd8OeRm0s0i7N+n8+E1d4Mm /BLrhomRhk4r6pxLDNPclM4W6e1wqB+nllTT5PebKY9xBoZpbXo8Ys0OGGaHBh8eOqUI t5feRuPrtNt9PwFvhEYDVb6iEJed70FciV496YEiw6GHIatws9SuYc2Ll9G1VgY/N31D tQ2Dd5m83H1ktzCzgVVfl6y2HrRMBUeVRAFaBOo6JBGXV4dtRzeI5eK/XiKkHWFeXzfh E+4w== X-Gm-Message-State: AOJu0YzM5QfmHlDVVq3Ktoy3PFF1O7cj+3YVTgtE7HtHFwMO9WBT/OrT J8PsspRXb79N4aWwmF9f8NFk5DRHYrCeDjkRWdM1Smuj+YxXxKUVoqz6sG9ftmjKGZlyOqiILyb liNMsvxCR0Ma3HfMxpE6CmQYI9v1afvc= X-Gm-Gg: AeBDievteM2taJAG1asQi4+wXLvPll5MUXTaQUVnVXCrS00flVlmTLnb9woMEEPMl1b GpJUA4TYUm6hs1BcvgMDZrwVZCzHD2Y21YgciYbQxVvPyx6An2PNWzLytQ6sapnChLkELqhiye8 vtZ+BdZMBHOXOioUOXDBD/3w8WE8xOSCS5PWe7Sy/JErH/G4jOst+z0VxJlIIGk4hYmiKdsOOkj j11b7i3n/9VVJLT+puoI7mCx8ySp6s9h4/gKaVUsquy2aQYlscnfwm+/9gQY2EuFbVfafrdGSr4 3ZXslUeoKtxp/ULa5t3G6xPN0TGcWKYjov7SgnzL X-Received: by 2002:a05:6820:55ca:20b0:682:1c53:8a01 with SMTP id 006d021491bc7-69421bbcc4cmr866637eaf.2.1776312724529; Wed, 15 Apr 2026 21:12:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Fujii Masao Date: Thu, 16 Apr 2026 13:11:52 +0900 X-Gm-Features: AQROBzBMyL_4a9W_8VME-jLFluMOHXWTQf13AJqD_Cugx-RidOCMcHnQ7UngAek Message-ID: Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid To: vignesh C Cc: PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Apr 13, 2026 at 4:10=E2=80=AFPM vignesh C wro= te: > I felt these also should be updated, the attached v2 version patch > includes the changes for the same. Thanks for updating the patch! - applyPtr =3D (latestApplyPtr =3D=3D InvalidXLogRecPtr) ? + applyPtr =3D (XLogRecPtrIsInvalid(latestApplyPtr)) ? XLogRecPtrIsValid() should be used here, instead? Regards, --=20 Fujii Masao