MIME-Version: 1.0
References: 
 <CAHGQGwGDHAQw=bmpRzk+EmKzVtxZiD5YDurMUffBMwr6WXugQA@mail.gmail.com>
 <20260709.161542.46102955322725819.horikyota.ntt@gmail.com>
 <80447AEF-2E66-48EF-9F68-8D408B541EC1@yesql.se>
In-Reply-To: <80447AEF-2E66-48EF-9F68-8D408B541EC1@yesql.se>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 10 Jul 2026 09:12:29 +0900
Message-ID: 
 <CAHGQGwGaXoAPO814Hn87edzegW53wVTR0RoPPBdHCR43f03FGw@mail.gmail.com>
Subject: Re: Fix data checksum processing for temp relations and dropped
 databases
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000007f2e5d06563699a4"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwGaXoAPO814Hn87edzegW53wVTR0RoPPBdHCR43f03FGw%40mail.gmail.com>
Precedence: bulk

--0000000000007f2e5d06563699a4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 9, 2026 at 4:56=E2=80=AFPM Daniel Gustafsson <daniel@yesql.se> =
wrote:
> I like this suggestion, though I think it should go after the call to
> pgstat_progress_update_param since the db in question reached ProcessData=
base.
> I would add it as an else-if case to the conditional testing we have for
> _FAILED and _ABORTED.

Thanks for the review! I've updated the patch based on
your and Horiguchi-san's suggestions.

Regards,

--=20
Fujii Masao

--0000000000007f2e5d06563699a4
Content-Type: application/octet-stream;
	name="v2-0001-Fix-data-checksum-processing-for-temp-relations-a.patch"
Content-Disposition: attachment;
	filename="v2-0001-Fix-data-checksum-processing-for-temp-relations-a.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mre6l1ux0>
X-Attachment-Id: f_mre6l1ux0

RnJvbSBiZGI0OTYyN2I1OWEyNGVjZWZhZjMwOGYyZGQ3ODJiMjVhNmRjY2E5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IFdlZCwgOCBKdWwgMjAyNiAyMzo1MjozOSArMDkwMApTdWJqZWN0OiBbUEFUQ0ggdjJdIEZp
eCBkYXRhIGNoZWNrc3VtIHByb2Nlc3NpbmcgZm9yIHRlbXAgcmVsYXRpb25zIGFuZAogZHJvcHBl
ZCBkYXRhYmFzZXMKCldoZW4gYnVpbGRpbmcgdGhlIGxpc3Qgb2YgdGVtcG9yYXJ5IHJlbGF0aW9u
cyB0byB3YWl0IGZvciwgdGhlIGNvZGUKcHJldmlvdXNseSBpbmNsdWRlZCB0ZW1wb3JhcnkgcmVs
YXRpb25zIHdpdGhvdXQgc3RvcmFnZSwgc3VjaCBhcwp0ZW1wb3Jhcnkgdmlld3MsIGV2ZW4gdGhv
dWdoIHRoZXkgYXJlIGlycmVsZXZhbnQgdG8gY2hlY2tzdW0KcHJvY2Vzc2luZy4gQXMgYSByZXN1
bHQsIGVuYWJsaW5nIGRhdGEgY2hlY2tzdW1zIGNvdWxkIHdhaXQgZm9yIGEKbG9uZy1saXZlZCBz
ZXNzaW9uIHRoYXQgb3duZWQgb25seSBhIHRlbXBvcmFyeSB2aWV3LgoKVGhpcyBjb21taXQgZml4
ZXMgdGhlIGlzc3VlIGJ5IGZpbHRlcmluZyB0ZW1wb3JhcnkgcmVsYXRpb25zIHdpdGggc3RvcmFn
ZQpvbmx5LCBtYXRjaGluZyB0aGUgZXhpc3RpbmcgYmVoYXZpb3IgZm9yIG5vbi10ZW1wb3Jhcnkg
cmVsYXRpb25zLgoKQWxzbywgd2hlbiBlbmFibGluZyBkYXRhIGNoZWNrc3VtcyBvbmxpbmUsIHRo
ZSBsYXVuY2hlciBhc3NpZ25zIHRoZQpmaXJzdCB3b3JrZXIgdG8gcHJvY2VzcyBzaGFyZWQgY2F0
YWxvZ3MgYW5kIHByZXZlbnRzIGxhdGVyIHdvcmtlcnMgZnJvbQpkb2luZyBzby4gUHJldmlvdXNs
eSwgaWYgdGhhdCB3b3JrZXIncyBkYXRhYmFzZSB3YXMgZHJvcHBlZCBhZnRlciBpdApoYWQgYmVl
biBzZWxlY3RlZCBmb3IgcHJvY2Vzc2luZyBidXQgYmVmb3JlIGNoZWNrc3VtIHByb2Nlc3Npbmcg
YmVnYW4sCnRoZSB3b3JrZXIgZmFpbGVkIHdpdGhvdXQgcHJvY2Vzc2luZyB0aGUgc2hhcmVkIGNh
dGFsb2dzLCB5ZXQgdGhleSB3ZXJlCnN0aWxsIG1hcmtlZCBhcyBwcm9jZXNzZWQuIEFzIGEgcmVz
dWx0LCBsYXRlciB3b3JrZXJzIHNraXBwZWQgdGhlbSwgYW5kCmNoZWNrc3VtIGVuYWJsaW5nIGNv
dWxkIGNvbXBsZXRlIHN1Y2Nlc3NmdWxseSBldmVuIHRob3VnaCB0aGUgc2hhcmVkCmNhdGFsb2dz
IGhhZCBuZXZlciBiZWVuIHByb2Nlc3NlZC4KClRoaXMgY29tbWl0IGZpeGVzIHRoZSBpc3N1ZSBi
eSBtYXJraW5nIHNoYXJlZCBjYXRhbG9ncyBhcyBwcm9jZXNzZWQKb25seSBhZnRlciBhIHdvcmtl
ciBjb21wbGV0ZXMgc3VjY2Vzc2Z1bGx5LgoKQXV0aG9yOiBGdWppaSBNYXNhbyA8bWFzYW8uZnVq
aWlAZ21haWwuY29tPgpSZXZpZXdlZC1ieTogS3lvdGFybyBIb3JpZ3VjaGkgPGhvcmlreW90YS5u
dHRAZ21haWwuY29tPgpSZXZpZXdlZC1ieTogRGFuaWVsIEd1c3RhZnNzb24gPGRhbmllbEB5ZXNx
bC5zZT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS9DQUhHUUd3R0RIQVF3PWJtcFJ6
aytFbUt6VnR4WmlENVlEdXJNVWZmQk13cjZXWHVnUUFAbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMv
YmFja2VuZC9wb3N0bWFzdGVyL2RhdGFjaGVja3N1bV9zdGF0ZS5jIHwgMjQgKysrKysrKysrKysr
KystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMo
LSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL2RhdGFjaGVja3N1bV9zdGF0
ZS5jIGIvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9kYXRhY2hlY2tzdW1fc3RhdGUuYwppbmRleCA2
ODU1N2MxNmNiOS4uNmIxMzZhODZiNzQgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0
ZXIvZGF0YWNoZWNrc3VtX3N0YXRlLmMKKysrIGIvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9kYXRh
Y2hlY2tzdW1fc3RhdGUuYwpAQCAtMTMyNCw2ICsxMzI0LDE0IEBAIFByb2Nlc3NBbGxEYXRhYmFz
ZXModm9pZCkKIAkJCS8qIEFib3J0IGZsYWcgc2V0LCBzbyBleGl0IHRoZSB3aG9sZSBwcm9jZXNz
ICovCiAJCQlyZXR1cm4gZmFsc2U7CiAJCX0KKwkJZWxzZSBpZiAocmVzdWx0ID09IERBVEFDSEVD
S1NVTVNXT1JLRVJfRFJPUERCKQorCQl7CisJCQkvKgorCQkJICogSWdub3JlIGRhdGFiYXNlcyB0
aGF0IHdlcmUgZHJvcHBlZCBiZWZvcmUgdGhlaXIgd29ya2VyIGNvdWxkCisJCQkgKiBwcm9jZXNz
IHRoZW0sIGFuZCBjb250aW51ZSB3aXRoIHRoZSByZW1haW5pbmcgZGF0YWJhc2VzLgorCQkJICov
CisJCQljb250aW51ZTsKKwkJfQogCiAJCS8qCiAJCSAqIFdoZW4gb25lIGRhdGFiYXNlIGhhcyBj
b21wbGV0ZWQsIGl0IHdpbGwgaGF2ZSBkb25lIHNoYXJlZCBjYXRhbG9ncwpAQCAtMTQ2OSwxMSAr
MTQ3NywxMSBAQCBGcmVlRGF0YWJhc2VMaXN0KExpc3QgKmRibGlzdCkKICAqCQlDb21waWxlIGEg
bGlzdCBvZiByZWxhdGlvbnMgaW4gdGhlIGRhdGFiYXNlCiAgKgogICogUmV0dXJucyBhIGxpc3Qg
b2YgT0lEcyBmb3IgdGhlIHJlcXVlc3RlZCByZWxhdGlvbiB0eXBlcy4gSWYgdGVtcF9yZWxhdGlv
bnMKLSAqIGlzIFRydWUgdGhlbiBvbmx5IHRlbXBvcmFyeSByZWxhdGlvbnMgYXJlIHJldHVybmVk
LiBJZiB0ZW1wX3JlbGF0aW9ucyBpcwotICogRmFsc2UgdGhlbiBub24tdGVtcG9yYXJ5IHJlbGF0
aW9ucyB3aGljaCBoYXZlIGRhdGEgY2hlY2tzdW1zIGFyZSByZXR1cm5lZC4KLSAqIElmIGluY2x1
ZGVfc2hhcmVkIGlzIFRydWUgdGhlbiBzaGFyZWQgcmVsYXRpb25zIGFyZSBpbmNsdWRlZCBhcyB3
ZWxsIGluIGEKLSAqIG5vbi10ZW1wb3JhcnkgbGlzdC4gaW5jbHVkZV9zaGFyZWQgaGFzIG5vIHJl
bGV2YW5jZSB3aGVuIGJ1aWxkaW5nIGEgbGlzdCBvZgotICogdGVtcG9yYXJ5IHJlbGF0aW9ucy4K
KyAqIGlzIFRydWUgdGhlbiBvbmx5IHRlbXBvcmFyeSByZWxhdGlvbnMgd2l0aCBzdG9yYWdlIGFy
ZSByZXR1cm5lZC4gIElmCisgKiB0ZW1wX3JlbGF0aW9ucyBpcyBGYWxzZSB0aGVuIG5vbi10ZW1w
b3JhcnkgcmVsYXRpb25zIHdpdGggc3RvcmFnZSBhcmUKKyAqIHJldHVybmVkLiAgSWYgaW5jbHVk
ZV9zaGFyZWQgaXMgVHJ1ZSB0aGVuIHNoYXJlZCByZWxhdGlvbnMgYXJlIGluY2x1ZGVkIGFzCisg
KiB3ZWxsIGluIGEgbm9uLXRlbXBvcmFyeSBsaXN0LiBpbmNsdWRlX3NoYXJlZCBoYXMgbm8gcmVs
ZXZhbmNlIHdoZW4gYnVpbGRpbmcKKyAqIGEgbGlzdCBvZiB0ZW1wb3JhcnkgcmVsYXRpb25zLgog
ICovCiBzdGF0aWMgTGlzdCAqCiBCdWlsZFJlbGF0aW9uTGlzdChib29sIHRlbXBfcmVsYXRpb25z
LCBib29sIGluY2x1ZGVfc2hhcmVkKQpAQCAtMTQ5NCw2ICsxNTAyLDkgQEAgQnVpbGRSZWxhdGlv
bkxpc3QoYm9vbCB0ZW1wX3JlbGF0aW9ucywgYm9vbCBpbmNsdWRlX3NoYXJlZCkKIAl7CiAJCUZv
cm1fcGdfY2xhc3MgcGdjID0gKEZvcm1fcGdfY2xhc3MpIEdFVFNUUlVDVCh0dXApOwogCisJCWlm
ICghUkVMS0lORF9IQVNfU1RPUkFHRShwZ2MtPnJlbGtpbmQpKQorCQkJY29udGludWU7CisKIAkJ
LyogT25seSBpbmNsdWRlIHRlbXBvcmFyeSByZWxhdGlvbnMgd2hlbiBleHBsaWNpdGx5IGFza2Vk
IHRvICovCiAJCWlmIChwZ2MtPnJlbHBlcnNpc3RlbmNlID09IFJFTFBFUlNJU1RFTkNFX1RFTVAp
CiAJCXsKQEAgLTE1MDksOSArMTUyMCw2IEBAIEJ1aWxkUmVsYXRpb25MaXN0KGJvb2wgdGVtcF9y
ZWxhdGlvbnMsIGJvb2wgaW5jbHVkZV9zaGFyZWQpCiAJCQlpZiAodGVtcF9yZWxhdGlvbnMpCiAJ
CQkJY29udGludWU7CiAKLQkJCWlmICghUkVMS0lORF9IQVNfU1RPUkFHRShwZ2MtPnJlbGtpbmQp
KQotCQkJCWNvbnRpbnVlOwotCiAJCQlpZiAocGdjLT5yZWxpc3NoYXJlZCAmJiAhaW5jbHVkZV9z
aGFyZWQpCiAJCQkJY29udGludWU7CiAJCX0KLS0gCjIuNTUuMAoK
--0000000000007f2e5d06563699a4--