MIME-Version: 1.0
References: 
 <CA+TgmoYqMtWb4zLUkT98oFnEkJ=Wz0Pw-ggDJrp9wnSXPzUaeQ@mail.gmail.com>
 <CAPmGK161TJ4G01eptv3sBqgxa4SNHDE9VRqoC6jy5Y6G3D8yDw@mail.gmail.com>
 <CA+TgmoZpwfTGqqp=0efV99e_BMYWdLFq2XKRWVSDcukifkZMeA@mail.gmail.com>
 <CADkLM=dxe8NbQu4RNi2OFXpaRKdpS0-CHGm6Mqtf_rW155BM4g@mail.gmail.com>
 <CADkLM=cV=uezAKyZdyyxnZOBRhGLUSbeYfDj5_jbDCLP9LP24Q@mail.gmail.com>
 <CA+TgmoaVcgZJpwxyi7HEfNMJhmm7BXkTQ468jvxkW2QzQZRkvg@mail.gmail.com>
 <CADkLM=dy18dDJ+j3-_Ofn11vt5J7zF33oTWnE6N=ePc83uS91A@mail.gmail.com>
 <CAPmGK15MfVT2H+PUvA_nAJvySGr_pAVkVx3KcnVXWGO36acWLA@mail.gmail.com>
 <CADkLM=dr5bfB8YN-bV1U0NDvyVO7a6uuz0BsAi89a1Md4A==8g@mail.gmail.com>
 <CAPmGK14P2GRe78hp6fZ3vExU_9RRDjMsYVOx7AALvUQ-hKTUiQ@mail.gmail.com>
 <CADkLM=cL9ZGvO-72QWyXA5Wqv-4P3T1fp+VFJy5e6k3Hf=POMw@mail.gmail.com>
 <CA+TgmoZdTVeXRQo__cEr_1y+mUO9nubOX=6PEfw7Cr0UfZQn6w@mail.gmail.com>
 <CADkLM=fe=ycPdwT2wE_iYwK8e8viMbWvwWhXR9vDe+55KKF-KQ@mail.gmail.com>
 <CADkLM=dWJaw04u9FU=WkykOy7bu7B5eKmoDkfVz6JXh7mdemkw@mail.gmail.com>
 <CA+TgmoY3a_S0munZ0wg4hQpMKVMyM_jpi6aGhFR0gAm1jLukag@mail.gmail.com>
 <CADkLM=cdKjgphHpFW8kKukHF+DVYKogHcqLXO=BA8MGfiRFqQA@mail.gmail.com>
 <CADkLM=c9BEuA9vPjE9Wco6+Lz-HSnnmBZrFhi=-yNi0K8tmZug@mail.gmail.com>
 <CAPmGK17W1sUB3JnkRoBpgO0_iSH5HRcc0_nxk8Us4KYsQhuQxg@mail.gmail.com>
 <CA+TgmoZd5MDhcx6uav6MWxhM42yWcfaRAHYKNtNkuog=yrKAgw@mail.gmail.com>
 <CADkLM=f_c7Xoq-bSzw28LgvxPa+OQ3rVow=xwkTyjz1J0=pMdw@mail.gmail.com>
 <CAPmGK14dY-Cex2rc08TinQjHR4Q1L6nqPBfdEBRZusP7n_TZSA@mail.gmail.com>
 <CADkLM=enKc-3-uTjUSXXhoRhSKDHVdb_ate+S2dtkEcscW5bvA@mail.gmail.com>
 <CAPmGK17rNA=dknxHCXbUoQ_xe2PQcPq0d-bhTr47wrUfXrDLFA@mail.gmail.com>
 <CADkLM=dYZ2XJ=nUMSYgA6D3VEFQ4rvpyDLKD-RrnfESUGxktiA@mail.gmail.com>
 <CAPmGK15eTnEtn_tPm+o0QA-jEnJUW+B2FPAF=vGNkFAGMApWNQ@mail.gmail.com>
 <CAPmGK16-=HvkijvSiDfo8=JmrHQ4ra79gSnJbKzW4Oob9yPfdQ@mail.gmail.com>
 <CAPmGK16XqvvkWhsGgUASUQAtrxEtOfUud4id6do3zZ+XX44WZA@mail.gmail.com>
In-Reply-To: 
 <CAPmGK16XqvvkWhsGgUASUQAtrxEtOfUud4id6do3zZ+XX44WZA@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 10 Jul 2026 14:36:40 +0900
Message-ID: 
 <CAHGQGwGjcQ4SwHMUQ9P8UYQ7iLKL1QE3uLSdONToQ1MrzpUUoQ@mail.gmail.com>
Subject: Re: use of SPI by postgresImportForeignStatistics
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000bd76a706563b2048"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwGjcQ4SwHMUQ9P8UYQ7iLKL1QE3uLSdONToQ1MrzpUUoQ%40mail.gmail.com>
Precedence: bulk

--000000000000bd76a706563b2048
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 10, 2026 at 2:03=E2=80=AFPM Etsuro Fujita <etsuro.fujita@gmail.=
com> wrote:
>
> On Wed, Jul 8, 2026 at 9:04=E2=80=AFPM Etsuro Fujita <etsuro.fujita@gmail=
.com> wrote:
> > Attached is a new version
> > of the patch.  I'm planning to push and back-patch it, if no
> > objections.
>
> Committed and back-patched.

In the committed patch, I found that the set_*_arg() helper functions
in postgres_fdw.c are declared static in their prototypes, but their
definitions omit the static keyword. This looks like an oversight.

Attached patch adds static to the definitions for consistency and
to make their intended file-local scope explicit. It also fixes a few
nearby comment typos.

Regards,

--=20
Fujii Masao

--000000000000bd76a706563b2048
Content-Type: application/octet-stream;
	name="v1-0001-postgres_fdw-Mark-statistics-import-helpers-as-st.patch"
Content-Disposition: attachment;
	filename="v1-0001-postgres_fdw-Mark-statistics-import-helpers-as-st.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mrei6b7x0>
X-Attachment-Id: f_mrei6b7x0

RnJvbSBmOTc5M2U1ZmU5MjRiNDllMWNhZDkzZjdkMzNlZDMxMzI4M2M1MWY3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IEZyaSwgMTAgSnVsIDIwMjYgMTQ6MjI6NTQgKzA5MDAKU3ViamVjdDogW1BBVENIIHYxXSBw
b3N0Z3Jlc19mZHc6IE1hcmsgc3RhdGlzdGljcyBpbXBvcnQgaGVscGVycyBhcyBzdGF0aWMKClRo
ZSBzZXRfKl9hcmcgaGVscGVyIGZ1bmN0aW9ucyBpbiBwb3N0Z3Jlc19mZHcuYyBhcmUgZGVjbGFy
ZWQKc3RhdGljLCBidXQgdGhlaXIgZGVmaW5pdGlvbnMgb21pdHRlZCB0aGUgc3RhdGljIGtleXdv
cmQuIEFkZCBpdCB0bwptYWtlIHRoZWlyIGZpbGUtbG9jYWwgc2NvcGUgZXhwbGljaXQgYW5kIGtl
ZXAgdGhlIGRlY2xhcmF0aW9ucyBhbmQKZGVmaW5pdGlvbnMgY29uc2lzdGVudC4KCkFsc28gZml4
IGEgY291cGxlIG9mIG5lYXJieSBjb21tZW50IHR5cG9zLgotLS0KIGNvbnRyaWIvcG9zdGdyZXNf
ZmR3L3Bvc3RncmVzX2Zkdy5jICAgICAgfCAxMiArKysrKystLS0tLS0KIHNyYy9iYWNrZW5kL3N0
YXRpc3RpY3MvYXR0cmlidXRlX3N0YXRzLmMgfCAgMiArLQogc3JjL2JhY2tlbmQvc3RhdGlzdGlj
cy9yZWxhdGlvbl9zdGF0cy5jICB8ICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9u
cygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9jb250cmliL3Bvc3RncmVzX2Zkdy9w
b3N0Z3Jlc19mZHcuYyBiL2NvbnRyaWIvcG9zdGdyZXNfZmR3L3Bvc3RncmVzX2Zkdy5jCmluZGV4
IGU2ZTBhNGFiOWI1Li43MGRlOTQyZGUxMiAxMDA2NDQKLS0tIGEvY29udHJpYi9wb3N0Z3Jlc19m
ZHcvcG9zdGdyZXNfZmR3LmMKKysrIGIvY29udHJpYi9wb3N0Z3Jlc19mZHcvcG9zdGdyZXNfZmR3
LmMKQEAgLTYxMzQsNyArNjEzNCw3IEBAIGltcG9ydF9mZXRjaGVkX3N0YXRpc3RpY3MoUmVsYXRp
b24gcmVsYXRpb24sCiB9CiAKIC8qCi0gKiBDb25lbmllbmNlIHJvdXRpbmUgdG8gZmV0Y2ggdGhl
IHZhbHVlIGZvciB0aGUgcm93L2NvbHVtbiBvZiB0aGUgUEdyZXN1bHQKKyAqIENvbnZlbmllbmNl
IHJvdXRpbmUgdG8gZmV0Y2ggdGhlIHZhbHVlIGZvciB0aGUgcm93L2NvbHVtbiBvZiB0aGUgUEdy
ZXN1bHQKICAqLwogc3RhdGljIGNoYXIgKgogZ2V0X29wdF92YWx1ZShQR3Jlc3VsdCAqcmVzLCBp
bnQgcm93LCBpbnQgY29sKQpAQCAtNjE0Nyw3ICs2MTQ3LDcgQEAgZ2V0X29wdF92YWx1ZShQR3Jl
c3VsdCAqcmVzLCBpbnQgcm93LCBpbnQgY29sKQogLyoKICAqIENvbnZlbmllbmNlIHJvdXRpbmUg
Zm9yIHNldHRpbmcgb3B0aW9uYWwgdGV4dCBhcmd1bWVudHMKICAqLwotdm9pZAorc3RhdGljIHZv
aWQKIHNldF90ZXh0X2FyZyhOdWxsYWJsZURhdHVtICphcmcsIGNvbnN0IGNoYXIgKnMpCiB7CiAJ
aWYgKHMpCkBAIC02MTY1LDcgKzYxNjUsNyBAQCBzZXRfdGV4dF9hcmcoTnVsbGFibGVEYXR1bSAq
YXJnLCBjb25zdCBjaGFyICpzKQogLyoKICAqIENvbnZlbmllbmNlIHJvdXRpbmUgZm9yIHNldHRp
bmcgb3B0aW9uYWwgaW50MzIgYXJndW1lbnRzCiAgKi8KLXZvaWQKK3N0YXRpYyB2b2lkCiBzZXRf
aW50MzJfYXJnKE51bGxhYmxlRGF0dW0gKmFyZywgY29uc3QgY2hhciAqcykKIHsKIAlpZiAocykK
QEAgLTYxODUsNyArNjE4NSw3IEBAIHNldF9pbnQzMl9hcmcoTnVsbGFibGVEYXR1bSAqYXJnLCBj
b25zdCBjaGFyICpzKQogLyoKICAqIENvbnZlbmllbmNlIHJvdXRpbmUgZm9yIHNldHRpbmcgb3B0
aW9uYWwgdWludDMyIGFyZ3VtZW50cwogICovCi12b2lkCitzdGF0aWMgdm9pZAogc2V0X3VpbnQz
Ml9hcmcoTnVsbGFibGVEYXR1bSAqYXJnLCBjb25zdCBjaGFyICpzKQogewogCWlmIChzKQpAQCAt
NjIwNSw3ICs2MjA1LDcgQEAgc2V0X3VpbnQzMl9hcmcoTnVsbGFibGVEYXR1bSAqYXJnLCBjb25z
dCBjaGFyICpzKQogLyoKICAqIENvbnZlbmllbmNlIHJvdXRpbmUgZm9yIHNldHRpbmcgb3B0aW9u
YWwgZmxvYXQgYXJndW1lbnRzCiAgKi8KLXZvaWQKK3N0YXRpYyB2b2lkCiBzZXRfZmxvYXRfYXJn
KE51bGxhYmxlRGF0dW0gKmFyZywgY29uc3QgY2hhciAqcykKIHsKIAlpZiAocykKQEAgLTYyMjUs
NyArNjIyNSw3IEBAIHNldF9mbG9hdF9hcmcoTnVsbGFibGVEYXR1bSAqYXJnLCBjb25zdCBjaGFy
ICpzKQogLyoKICAqIENvbnZlbmllbmNlIHJvdXRpbmUgZm9yIHNldHRpbmcgb3B0aW9uYWwgZmxv
YXRbXSBhcmd1bWVudHMKICAqLwotdm9pZAorc3RhdGljIHZvaWQKIHNldF9mbG9hdGFycl9hcmco
TnVsbGFibGVEYXR1bSAqYXJnLCBjb25zdCBjaGFyICpzKQogewogCWlmIChzKQpkaWZmIC0tZ2l0
IGEvc3JjL2JhY2tlbmQvc3RhdGlzdGljcy9hdHRyaWJ1dGVfc3RhdHMuYyBiL3NyYy9iYWNrZW5k
L3N0YXRpc3RpY3MvYXR0cmlidXRlX3N0YXRzLmMKaW5kZXggMmVmYjc0Yjk1YTYuLjQ4ZTBkZjM5
MWUyIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9zdGF0aXN0aWNzL2F0dHJpYnV0ZV9zdGF0cy5j
CisrKyBiL3NyYy9iYWNrZW5kL3N0YXRpc3RpY3MvYXR0cmlidXRlX3N0YXRzLmMKQEAgLTcwOCw3
ICs3MDgsNyBAQCBwZ19yZXN0b3JlX2F0dHJpYnV0ZV9zdGF0cyhQR19GVU5DVElPTl9BUkdTKQog
fQogCiAvKgotICogSW1wb3J0IGF0dHJpYnV0ZSBzdGF0aXN0aWNzIGZyb20gTnVsbGFibGVEYXR1
bSBpbnB1dHMgZm9yIGFsbCBzdGF0aXRpY2FsCisgKiBJbXBvcnQgYXR0cmlidXRlIHN0YXRpc3Rp
Y3MgZnJvbSBOdWxsYWJsZURhdHVtIGlucHV0cyBmb3IgYWxsIHN0YXRpc3RpY2FsCiAgKiB2YWx1
ZXMuCiAgKgogICogRm9yIG5vdywgdGhlICd2ZXJzaW9uJyBhcmd1bWVudCBpcyBpZ25vcmVkLiBJ
biB0aGUgZnV0dXJlIGl0IGNhbiBiZSB1c2VkCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9zdGF0
aXN0aWNzL3JlbGF0aW9uX3N0YXRzLmMgYi9zcmMvYmFja2VuZC9zdGF0aXN0aWNzL3JlbGF0aW9u
X3N0YXRzLmMKaW5kZXggOTkwYTc1MTFkMDQuLmZiYWFiOTIyODRmIDEwMDY0NAotLS0gYS9zcmMv
YmFja2VuZC9zdGF0aXN0aWNzL3JlbGF0aW9uX3N0YXRzLmMKKysrIGIvc3JjL2JhY2tlbmQvc3Rh
dGlzdGljcy9yZWxhdGlvbl9zdGF0cy5jCkBAIC0yNTYsNyArMjU2LDcgQEAgcGdfcmVzdG9yZV9y
ZWxhdGlvbl9zdGF0cyhQR19GVU5DVElPTl9BUkdTKQogfQogCiAvKgotICogSW1wb3J0IHJlbGF0
aW9uIHN0YXRpc3RpY3MgZnJvbSBOdWxsYWJsZURhdHVtIGlucHV0cyBmb3IgYWxsIHN0YXRpdGlj
YWwKKyAqIEltcG9ydCByZWxhdGlvbiBzdGF0aXN0aWNzIGZyb20gTnVsbGFibGVEYXR1bSBpbnB1
dHMgZm9yIGFsbCBzdGF0aXN0aWNhbAogICogdmFsdWVzLgogICoKICAqIEZvciBub3csIHRoZSAn
dmVyc2lvbicgYXJndW1lbnQgaXMgaWdub3JlZC4gSW4gdGhlIGZ1dHVyZSBpdCBjYW4gYmUgdXNl
ZAotLSAKMi41NS4wCgo=
--000000000000bd76a706563b2048--