MIME-Version: 1.0
References: 
 <CAKFQuwawy1e6YR4S=j+y7pXqg_Dw1WBVrgvf=BP3d1_aSfe_+Q@mail.gmail.com>
 <CACJufxGEHmijmP-QqvrmqU6cxmhgpdjY7ewQBQ=E9NmdyEcqmw@mail.gmail.com>
 <f5ebfa4b318e97c41c0919304b94c77f@oss.nttdata.com>
 <CACJufxG=em0PHZvy1EAZ+vxPZ8UA68MfQ-Hji+h+WgnWNpqmVQ@mail.gmail.com>
 <CACJufxF0c3k5O8up9NOY-m02nyJ0f6N1tKxZwjCewTqvvFmbLw@mail.gmail.com>
 <CACJufxHr-LBV2pB9m64mA=1pgVMM4LvUn+-MzpeViWV=Ks_cyg@mail.gmail.com>
 <901967e5-e5dc-42c6-b2bf-fb3a49d7e787@gmail.com>
 <CACJufxEs_VBV39gYHnpLFOMcUaUD-ADAst_ePTCgmoDR8O=ekg@mail.gmail.com>
 <DFUHPCSP86G0.11VU7FGWRRXM2@gmail.com>
 <CACJufxGYPXQ_Jz1avF5eSh_XJRsxhPSUZ+=RzG3Hz4_XNAc32g@mail.gmail.com>
 <4c540fe3-495c-4bbf-8dcf-2c1e2b88bc3d@gmail.com>
 <CACJufxHFwQMw1As+QFk+fA7S8ZxRG2wOvHcvmsWuj2XJ+W6d_A@mail.gmail.com>
 <DG7WARDX1TY0.2VX3Q7QHSCXE9@gmail.com>
 <CACJufxGUP09S7a2akQ4GD62-Rf2bcV52cqnw4qqBOXcn9bmxCA@mail.gmail.com>
 <6f973222-f306-43af-9df5-38673fe3f7d6@eisentraut.org>
 <CACJufxG-bN_3-0qG2NsY2+07gMWwYkT1VNB1xfbxt9i-ZAyh9w@mail.gmail.com>
 <5e126dbb-9535-4de4-ad3b-187e475aa6b5@eisentraut.org>
In-Reply-To: <5e126dbb-9535-4de4-ad3b-187e475aa6b5@eisentraut.org>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Wed, 4 Mar 2026 22:25:45 +0900
Message-ID: 
 <CAHGQGwGmPc6aHpA5=WxKreiDePiOEitfOFsW2dSo5m81xWXgRA@mail.gmail.com>
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
To: Peter Eisentraut <peter@eisentraut.org>
Cc: jian he <jian.universality@gmail.com>,
	Matheus Alcantara <matheusssilv97@gmail.com>,
 torikoshia <torikoshia@oss.nttdata.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Jim Jones <jim.jones@uni-muenster.de>,
 Kirill Reshke <reshkekirill@gmail.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
 Yugo NAGATA <nagata@sraoss.co.jp>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000c13565064c32c23a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwGmPc6aHpA5%3DWxKreiDePiOEitfOFsW2dSo5m81xWXgRA%40mail.gmail.com>
Precedence: bulk

--000000000000c13565064c32c23a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 3, 2026 at 3:38=E2=80=AFPM Peter Eisentraut <peter@eisentraut.o=
rg> wrote:
> Thanks, committed.

Thanks for committing the patch!

With this change, ON_ERROR =3D 'set_null' can now be used with foreign tabl=
es
backed by file_fdw. However, unlike ON_ERROR =3D 'ignore', there is current=
ly
no regression test covering this behavior in file_fdw.

How about adding a regression test to ensure that file_fdw works correctly
with ON_ERROR =3D 'set_null', and to improve test coverage? Patch attached.

Regards,

--=20
Fujii Masao

--000000000000c13565064c32c23a
Content-Type: application/octet-stream;
	name="v1-0001-file_fdw-Add-regression-test-for-file_fdw-with-ON.patch"
Content-Disposition: attachment;
	filename="v1-0001-file_fdw-Add-regression-test-for-file_fdw-with-ON.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmc2kr6a0>
X-Attachment-Id: f_mmc2kr6a0

RnJvbSA0MDBhZGIxNmE1MGNjODE3ZWFlYTgxNmZjNjczNWE3YjRlN2FmOWFhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IFdlZCwgNCBNYXIgMjAyNiAyMjoxOTowNiArMDkwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIGZp
bGVfZmR3OiBBZGQgcmVncmVzc2lvbiB0ZXN0IGZvciBmaWxlX2ZkdyB3aXRoCiBPTl9FUlJPUj0n
c2V0X251bGwnLgoKQ29tbWl0IDJhNTI1Y2M5N2UxIGludHJvZHVjZWQgdGhlIE9OX0VSUk9SID0g
J3NldF9udWxsJyBvcHRpb24gZm9yIENPUFksCmFsbG93aW5nIGl0IHRvIGJlIHVzZWQgd2l0aCBm
b3JlaWduIHRhYmxlcyBiYWNrZWQgYnkgZmlsZV9mZHcuIEhvd2V2ZXIsCnVubGlrZSBPTl9FUlJP
UiA9ICdpZ25vcmUnLCBubyByZWdyZXNzaW9uIHRlc3Qgd2FzIGFkZGVkIHRvIHZlcmlmeQp0aGlz
IGJlaGF2aW9yIGZvciBmaWxlX2Zkdy4KClRoaXMgY29tbWl0IGFkZHMgYSByZWdyZXNzaW9uIHRl
c3QgdG8gZW5zdXJlIHRoYXQgZm9yZWlnbiB0YWJsZXMgdXNpbmcKZmlsZV9mZHcgd29yayBjb3Jy
ZWN0bHkgd2l0aCBPTl9FUlJPUiA9ICdzZXRfbnVsbCcsIGltcHJvdmluZyB0ZXN0IGNvdmVyYWdl
LgotLS0KIGNvbnRyaWIvZmlsZV9mZHcvZXhwZWN0ZWQvZmlsZV9mZHcub3V0IHwgMTIgKysrKysr
KysrKystCiBjb250cmliL2ZpbGVfZmR3L3NxbC9maWxlX2Zkdy5zcWwgICAgICB8ICA0ICsrKy0K
IDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9jb250cmliL2ZpbGVfZmR3L2V4cGVjdGVkL2ZpbGVfZmR3Lm91dCBiL2NvbnRyaWIv
ZmlsZV9mZHcvZXhwZWN0ZWQvZmlsZV9mZHcub3V0CmluZGV4IDI1MWYwMGJkMjU4Li42NDA5ODY1
MjhhZSAxMDA2NDQKLS0tIGEvY29udHJpYi9maWxlX2Zkdy9leHBlY3RlZC9maWxlX2Zkdy5vdXQK
KysrIGIvY29udHJpYi9maWxlX2Zkdy9leHBlY3RlZC9maWxlX2Zkdy5vdXQKQEAgLTI0Niw3ICsy
NDYsMTcgQEAgU0VMRUNUICogRlJPTSBhZ2dfYmFkOyAgICAgICAgICAgICAgIC0tIEVSUk9SCiBF
UlJPUjogIGludmFsaWQgaW5wdXQgc3ludGF4IGZvciB0eXBlIHJlYWw6ICJhYWEiCiBDT05URVhU
OiAgQ09QWSBhZ2dfYmFkLCBsaW5lIDMsIGNvbHVtbiBiOiAiYWFhIgogLS0gb25fZXJyb3IsIGxv
Z192ZXJib3NpdHkgYW5kIHJlamVjdF9saW1pdCB0ZXN0cwotQUxURVIgRk9SRUlHTiBUQUJMRSBh
Z2dfYmFkIE9QVElPTlMgKEFERCBvbl9lcnJvciAnaWdub3JlJyk7CitBTFRFUiBGT1JFSUdOIFRB
QkxFIGFnZ19iYWQgT1BUSU9OUyAoQUREIG9uX2Vycm9yICdzZXRfbnVsbCcpOworU0VMRUNUICog
RlJPTSBhZ2dfYmFkOworICBhICB8ICAgYiAgICAKKy0tLS0tKy0tLS0tLS0tCisgMTAwIHwgOTku
MDk3CisgICAwIHwgX251bGxfCisgIDQyIHwgMzI0Ljc4CisgICAxIHwgX251bGxfCisoNCByb3dz
KQorCitBTFRFUiBGT1JFSUdOIFRBQkxFIGFnZ19iYWQgT1BUSU9OUyAoU0VUIG9uX2Vycm9yICdp
Z25vcmUnKTsKIFNFTEVDVCAqIEZST00gYWdnX2JhZDsKIE5PVElDRTogIDIgcm93cyB3ZXJlIHNr
aXBwZWQgZHVlIHRvIGRhdGEgdHlwZSBpbmNvbXBhdGliaWxpdHkKICAgYSAgfCAgIGIgICAgCmRp
ZmYgLS1naXQgYS9jb250cmliL2ZpbGVfZmR3L3NxbC9maWxlX2Zkdy5zcWwgYi9jb250cmliL2Zp
bGVfZmR3L3NxbC9maWxlX2Zkdy5zcWwKaW5kZXggMmNiYTg0YjFkYjcuLjU2YmZjOTI2YzAwIDEw
MDY0NAotLS0gYS9jb250cmliL2ZpbGVfZmR3L3NxbC9maWxlX2Zkdy5zcWwKKysrIGIvY29udHJp
Yi9maWxlX2Zkdy9zcWwvZmlsZV9mZHcuc3FsCkBAIC0xNzEsNyArMTcxLDkgQEAgU0VMRUNUICog
RlJPTSBhZ2dfY3N2IGMgSk9JTiBhZ2dfdGV4dCB0IE9OICh0LmEgPSBjLmEpIE9SREVSIEJZIGMu
YTsKIFNFTEVDVCAqIEZST00gYWdnX2JhZDsgICAgICAgICAgICAgICAtLSBFUlJPUgogCiAtLSBv
bl9lcnJvciwgbG9nX3ZlcmJvc2l0eSBhbmQgcmVqZWN0X2xpbWl0IHRlc3RzCi1BTFRFUiBGT1JF
SUdOIFRBQkxFIGFnZ19iYWQgT1BUSU9OUyAoQUREIG9uX2Vycm9yICdpZ25vcmUnKTsKK0FMVEVS
IEZPUkVJR04gVEFCTEUgYWdnX2JhZCBPUFRJT05TIChBREQgb25fZXJyb3IgJ3NldF9udWxsJyk7
CitTRUxFQ1QgKiBGUk9NIGFnZ19iYWQ7CitBTFRFUiBGT1JFSUdOIFRBQkxFIGFnZ19iYWQgT1BU
SU9OUyAoU0VUIG9uX2Vycm9yICdpZ25vcmUnKTsKIFNFTEVDVCAqIEZST00gYWdnX2JhZDsKIEFM
VEVSIEZPUkVJR04gVEFCTEUgYWdnX2JhZCBPUFRJT05TIChBREQgbG9nX3ZlcmJvc2l0eSAnc2ls
ZW50Jyk7CiBTRUxFQ1QgKiBGUk9NIGFnZ19iYWQ7Ci0tIAoyLjUxLjIKCg==
--000000000000c13565064c32c23a--