MIME-Version: 1.0
References: 
 <CAHGQGwHhpizYzMo3nFP4GkNMueSNMY3QfC-gBN1VTXtuiANDvw@mail.gmail.com>
 <CAFC+b6qaCMoO7JZUx-etHJhinvPpQow8GKXZDXFfrCydeDtAdQ@mail.gmail.com>
 <CAHGQGwHz8aOjPbJd+mCb=OuYdfZQ-RkeatuQrfDCE4cqJxt69w@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwHz8aOjPbJd+mCb=OuYdfZQ-RkeatuQrfDCE4cqJxt69w@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 18 May 2026 19:48:57 +0900
Message-ID: 
 <CAHGQGwGrq7RwMPMdmBHaUCKZRkUFjfjkWTCtWFZCpsUwGbaWMA@mail.gmail.com>
Subject: Re: pg_recvlogical: honor source cluster file permissions for output
 files
To: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000003982750652155034"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwGrq7RwMPMdmBHaUCKZRkUFjfjkWTCtWFZCpsUwGbaWMA%40mail.gmail.com>
Precedence: bulk

--0000000000003982750652155034
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 18, 2026 at 7:47=E2=80=AFPM Fujii Masao <masao.fujii@gmail.com>=
 wrote:
> As far as I can tell, 010_basebackup.pl initializes the cluster without g=
roup
> access and checks the backup permissions, then enables group access using
> chmod_recursive() and verifies that group permissions are also applied to
> the backup. I updated the TAP test following this approach and attached
> a revised patch.

Sorry, I forgot to attach the patch.
I've attached it in this email.

Regards,

--=20
Fujii Masao

--0000000000003982750652155034
Content-Type: application/octet-stream;
	name="v2-0001-pg_recvlogical-Honor-source-cluster-file-permissi.patch"
Content-Disposition: attachment;
	filename="v2-0001-pg_recvlogical-Honor-source-cluster-file-permissi.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpb2yhd30>
X-Attachment-Id: f_mpb2yhd30

RnJvbSAxOWU0MmIxNDExOTI5N2RhZjhhNGJiZWRkNDU3ODczM2RkODU0MTJiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IEZyaSwgMTUgTWF5IDIwMjYgMjI6NDc6MjggKzA5MDAKU3ViamVjdDogW1BBVENIIHYyXSBw
Z19yZWN2bG9naWNhbDogSG9ub3Igc291cmNlIGNsdXN0ZXIgZmlsZSBwZXJtaXNzaW9ucyBmb3IK
IG91dHB1dCBmaWxlcwoKQ29tbWl0IGMzN2IzZDA4Y2E2IGF0dGVtcHRlZCB0byBwcmVzZXJ2ZSBn
cm91cCBwZXJtaXNzaW9ucyBvbiBwZ19yZWN2bG9naWNhbApvdXRwdXQgZmlsZXMgd2hlbiBncm91
cCBhY2Nlc3Mgd2FzIGVuYWJsZWQgb24gdGhlIHNvdXJjZSBjbHVzdGVyLiBIb3dldmVyLAp0aGUg
b3V0cHV0IGZpbGVzIHdlcmUgc3RpbGwgY3JlYXRlZCB3aXRoIGEgZml4ZWQgU19JUlVTUiB8IFNf
SVdVU1IgbW9kZSwKcHJldmVudGluZyBncm91cC1yZWFkIHBlcm1pc3Npb25zIGZyb20gYmVpbmcg
YXBwbGllZC4KClRoaXMgY29tbWl0IGZpeGVzIHRoZSBpc3N1ZSBieSBjcmVhdGluZyBvdXRwdXQg
ZmlsZXMgd2l0aCBwZ19maWxlX2NyZWF0ZV9tb2RlCmluc3RlYWQgb2YgYSBoYXJkLWNvZGVkIG1v
ZGUuIFRoaXMgYWxsb3dzIHBnX3JlY3Zsb2dpY2FsIHRvIGNvcnJlY3RseSBwcmVzZXJ2ZQpncm91
cCBwZXJtaXNzaW9ucyBmcm9tIHRoZSBzb3VyY2UgY2x1c3Rlci4KCkJhY2twYXRjaCB0byBhbGwg
c3VwcG9ydGVkIGJyYW5jaGVzLgotLS0KIGRvYy9zcmMvc2dtbC9yZWYvcGdfcmVjdmxvZ2ljYWwu
c2dtbCAgICAgICAgICB8ICAyICstCiBzcmMvYmluL3BnX2Jhc2ViYWNrdXAvcGdfcmVjdmxvZ2lj
YWwuYyAgICAgICAgfCAgMiArLQogc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3QvMDMwX3BnX3JlY3Zs
b2dpY2FsLnBsIHwgNDYgKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA0OCBp
bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9y
ZWYvcGdfcmVjdmxvZ2ljYWwuc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfcmVjdmxvZ2ljYWwu
c2dtbAppbmRleCA1MzgwZDc3NmJhZi4uNWY3NmU0MjRlMjYgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMv
c2dtbC9yZWYvcGdfcmVjdmxvZ2ljYWwuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvcmVmL3BnX3Jl
Y3Zsb2dpY2FsLnNnbWwKQEAgLTQ5NCw3ICs0OTQsNyBAQCBQb3N0Z3JlU1FMIGRvY3VtZW50YXRp
b24KIAogICA8cGFyYT4KICAgIDxhcHBsaWNhdGlvbj5wZ19yZWN2bG9naWNhbDwvYXBwbGljYXRp
b24+IHdpbGwgcHJlc2VydmUgZ3JvdXAgcGVybWlzc2lvbnMgb24KLSAgIHRoZSByZWNlaXZlZCBX
QUwgZmlsZXMgaWYgZ3JvdXAgcGVybWlzc2lvbnMgYXJlIGVuYWJsZWQgb24gdGhlIHNvdXJjZQor
ICAgdGhlIG91dHB1dCBmaWxlcyBpZiBncm91cCBwZXJtaXNzaW9ucyBhcmUgZW5hYmxlZCBvbiB0
aGUgc291cmNlCiAgICBjbHVzdGVyLgogICA8L3BhcmE+CiAKZGlmZiAtLWdpdCBhL3NyYy9iaW4v
cGdfYmFzZWJhY2t1cC9wZ19yZWN2bG9naWNhbC5jIGIvc3JjL2Jpbi9wZ19iYXNlYmFja3VwL3Bn
X3JlY3Zsb2dpY2FsLmMKaW5kZXggYmU3MTc4M2IzNzAuLjJmZGY2NGJjYWRiIDEwMDY0NAotLS0g
YS9zcmMvYmluL3BnX2Jhc2ViYWNrdXAvcGdfcmVjdmxvZ2ljYWwuYworKysgYi9zcmMvYmluL3Bn
X2Jhc2ViYWNrdXAvcGdfcmVjdmxvZ2ljYWwuYwpAQCAtMzQyLDcgKzM0Miw3IEBAIFN0cmVhbUxv
Z2ljYWxMb2codm9pZCkKIAkJCQlvdXRmZCA9IGZpbGVubyhzdGRvdXQpOwogCQkJZWxzZQogCQkJ
CW91dGZkID0gb3BlbihvdXRmaWxlLCBPX0NSRUFUIHwgT19BUFBFTkQgfCBPX1dST05MWSB8IFBH
X0JJTkFSWSwKLQkJCQkJCQkgU19JUlVTUiB8IFNfSVdVU1IpOworCQkJCQkJCSBwZ19maWxlX2Ny
ZWF0ZV9tb2RlKTsKIAkJCWlmIChvdXRmZCA9PSAtMSkKIAkJCXsKIAkJCQlwZ19sb2dfZXJyb3Io
ImNvdWxkIG5vdCBvcGVuIGxvZyBmaWxlIFwiJXNcIjogJW0iLCBvdXRmaWxlKTsKZGlmZiAtLWdp
dCBhL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC90LzAzMF9wZ19yZWN2bG9naWNhbC5wbCBiL3NyYy9i
aW4vcGdfYmFzZWJhY2t1cC90LzAzMF9wZ19yZWN2bG9naWNhbC5wbAppbmRleCAwNjNhZDk2Yjli
ZS4uOTQ1YTI0MmJkYWQgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC90LzAzMF9w
Z19yZWN2bG9naWNhbC5wbAorKysgYi9zcmMvYmluL3BnX2Jhc2ViYWNrdXAvdC8wMzBfcGdfcmVj
dmxvZ2ljYWwucGwKQEAgLTIzNiw2ICsyMzYsNTIgQEAgbXkgJGNvdW50ID0gKCgpID0gJG91dGZp
bGVkYXRhID1+IC9JTlNFUlQvZyk7CiBjbXBfb2soJGNvdW50LCAnPT0nLCAyLAogCSdwZ19yZWN2
bG9naWNhbCBoYXMgcmVjZWl2ZWQgYW5kIHdyaXR0ZW4gdHdvIElOU0VSVHMnKTsKIAorIyBDaGVj
ayB0aGF0IHBnX3JlY3Zsb2dpY2FsIGRlcml2ZXMgb3V0cHV0IGZpbGUgcGVybWlzc2lvbnMgZnJv
bSB0aGUgc291cmNlCisjIGNsdXN0ZXIuCitTS0lQOgoreworCXNraXAgInVuaXgtc3R5bGUgcGVy
bWlzc2lvbnMgbm90IHN1cHBvcnRlZCBvbiBXaW5kb3dzIiwgMgorCSAgaWYgKCRDb25maWd7b3Nu
YW1lfSBlcSAnTVNXaW4zMicgfHwgJENvbmZpZ3tvc25hbWV9IGVxICdjeWd3aW4nKTsKKworCSMg
VGhlIGNsdXN0ZXIgd2FzIGluaXRpYWxpemVkIHdpdGhvdXQgZ3JvdXAgYWNjZXNzLCBzbyBwZ19y
ZWN2bG9naWNhbAorCSMgc2hvdWxkIGNyZWF0ZSB0aGUgb3V0cHV0IGZpbGUgYXMgMDYwMCAoLXJ3
LS0tLS0tLSkuCisJbXkgJG1vZGUgPSBzcHJpbnRmKCclMDRvJywgKHN0YXQoJG91dGZpbGUpKVsy
XSAmIDA3Nzc3KTsKKwlpcygkbW9kZSwgJzA2MDAnLAorCQkncGdfcmVjdmxvZ2ljYWwgb3V0cHV0
IGZpbGUgaGFzIG5vIGdyb3VwIHBlcm1pc3Npb25zICgwNjAwKScpOworCisJIyBFbmFibGUgZ3Jv
dXAgYWNjZXNzIG9uIHRoZSBzb3VyY2UgY2x1c3RlciBhbmQgaXRzIGZpbGVzLCB0aGVuIHJlc3Rh
cnQKKwkjIHNvIHBnX3JlY3Zsb2dpY2FsIG9ic2VydmVzIHRoZSB1cGRhdGVkIHNvdXJjZSBjbHVz
dGVyIHBlcm1pc3Npb25zLgorCSRub2RlLT5zdG9wOworCWNobW9kX3JlY3Vyc2l2ZSgkbm9kZS0+
ZGF0YV9kaXIsIDA3NTAsIDA2NDApOworCSRub2RlLT5zdGFydDsKKworCSRvdXRmaWxlID0gJG5v
ZGUtPmJhc2VkaXIgLiAnL2dyb3VwX2FjY2Vzcy5vdXQnOworCUBwZ19yZWN2bG9naWNhbF9jbWQg
PSAoCisJCSdwZ19yZWN2bG9naWNhbCcsCisJCSctLXNsb3QnID0+ICdyZWNvbm5lY3RfdGVzdCcs
CisJCSctLWRibmFtZScgPT4gJG5vZGUtPmNvbm5zdHIoJ3Bvc3RncmVzJyksCisJCSctLXN0YXJ0
JywKKwkJJy0tZmlsZScgPT4gJG91dGZpbGUsCisJCSctLWZzeW5jLWludGVydmFsJyA9PiAnMScp
OworCisJJHJlY3YgPSBJUEM6OlJ1bjo6c3RhcnQoCisJCVtAcGdfcmVjdmxvZ2ljYWxfY21kXSwK
KwkJJz4nID0+IFwkc3Rkb3V0LAorCQknMj4nID0+IFwkc3RkZXJyKTsKKworCSRub2RlLT5zYWZl
X3BzcWwoJ3Bvc3RncmVzJywgJ0lOU0VSVCBJTlRPIHRlc3RfdGFibGUgVkFMVUVTICgzKScpOwor
CXdhaXRfZm9yX2ZpbGUoJG91dGZpbGUsIHFyL0lOU0VSVC8pOworCisJJHJlY3YtPnNpZ25hbCgn
VEVSTScpOworCSRyZWN2LT5maW5pc2goKTsKKworCSMgV2l0aCBncm91cCBhY2Nlc3MgZW5hYmxl
ZCBvbiB0aGUgc291cmNlIGNsdXN0ZXIsIHBnX3JlY3Zsb2dpY2FsIHNob3VsZAorCSMgY3JlYXRl
IHRoZSBvdXRwdXQgZmlsZSBhcyAwNjQwICgtcnctci0tLS0tKS4KKwkkbW9kZSA9IHNwcmludGYo
JyUwNG8nLCAoc3RhdCgkb3V0ZmlsZSkpWzJdICYgMDc3NzcpOworCWlzKCRtb2RlLCAnMDY0MCcs
CisJCSdwZ19yZWN2bG9naWNhbCBvdXRwdXQgZmlsZSByZXNwZWN0cyBncm91cCBwZXJtaXNzaW9u
cyAoMDY0MCknKTsKK30KKwogJG5vZGUtPmNvbW1hbmRfb2soCiAJWwogCQkncGdfcmVjdmxvZ2lj
YWwnLAotLSAKMi41My4wCgo=
--0000000000003982750652155034--