MIME-Version: 1.0
References: 
 <CAKFQuwawy1e6YR4S=j+y7pXqg_Dw1WBVrgvf=BP3d1_aSfe_+Q@mail.gmail.com>
 <CACJufxGEHmijmP-QqvrmqU6cxmhgpdjY7ewQBQ=E9NmdyEcqmw@mail.gmail.com>
 <f5ebfa4b318e97c41c0919304b94c77f@oss.nttdata.com>
 <CACJufxG=em0PHZvy1EAZ+vxPZ8UA68MfQ-Hji+h+WgnWNpqmVQ@mail.gmail.com>
 <CACJufxF0c3k5O8up9NOY-m02nyJ0f6N1tKxZwjCewTqvvFmbLw@mail.gmail.com>
 <CACJufxHr-LBV2pB9m64mA=1pgVMM4LvUn+-MzpeViWV=Ks_cyg@mail.gmail.com>
 <901967e5-e5dc-42c6-b2bf-fb3a49d7e787@gmail.com>
 <CACJufxEs_VBV39gYHnpLFOMcUaUD-ADAst_ePTCgmoDR8O=ekg@mail.gmail.com>
 <DFUHPCSP86G0.11VU7FGWRRXM2@gmail.com>
 <CACJufxGYPXQ_Jz1avF5eSh_XJRsxhPSUZ+=RzG3Hz4_XNAc32g@mail.gmail.com>
 <4c540fe3-495c-4bbf-8dcf-2c1e2b88bc3d@gmail.com>
 <CACJufxHFwQMw1As+QFk+fA7S8ZxRG2wOvHcvmsWuj2XJ+W6d_A@mail.gmail.com>
 <DG7WARDX1TY0.2VX3Q7QHSCXE9@gmail.com>
 <CACJufxGUP09S7a2akQ4GD62-Rf2bcV52cqnw4qqBOXcn9bmxCA@mail.gmail.com>
 <6f973222-f306-43af-9df5-38673fe3f7d6@eisentraut.org>
 <CACJufxG-bN_3-0qG2NsY2+07gMWwYkT1VNB1xfbxt9i-ZAyh9w@mail.gmail.com>
 <5e126dbb-9535-4de4-ad3b-187e475aa6b5@eisentraut.org>
 <CAHGQGwGmPc6aHpA5=WxKreiDePiOEitfOFsW2dSo5m81xWXgRA@mail.gmail.com>
 <CAHGQGwFTRgYXS0V7=e3AYox5PVbMU034BQoxZkX7kMyp5beLMw@mail.gmail.com>
 <5e6ae3c1.48b2.19ce5bfea42.Coremail.dingyi_yale@163.com>
 <CAHGQGwHGyBAA6e+2eMzOPAbwd9CHKhCCKQ8AVHXG2UwUEj7zew@mail.gmail.com>
 <2291919f.2a51.19cf483243a.Coremail.dingyi_yale@163.com>
In-Reply-To: <2291919f.2a51.19cf483243a.Coremail.dingyi_yale@163.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 16 Mar 2026 12:15:16 +0900
Message-ID: 
 <CAHGQGwHA8Vh_JjjB_NvzKDGKH9anVXcEO=DVYqTppo6EBGpFYQ@mail.gmail.com>
Subject: Re: Re: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
To: Yi Ding <dingyi_yale@163.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 jian he <jian.universality@gmail.com>,
	Matheus Alcantara <matheusssilv97@gmail.com>,
 torikoshia <torikoshia@oss.nttdata.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Jim Jones <jim.jones@uni-muenster.de>,
 Kirill Reshke <reshkekirill@gmail.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
 Yugo NAGATA <nagata@sraoss.co.jp>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHA8Vh_JjjB_NvzKDGKH9anVXcEO%3DDVYqTppo6EBGpFYQ%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 16, 2026 at 11:39=E2=80=AFAM Yi Ding <dingyi_yale@163.com> wrot=
e:
>
>
> At 2026-03-13 21:50:07, "Fujii Masao" <masao.fujii@gmail.com> wrote:
> >On Fri, Mar 13, 2026 at 2:51=E2=80=AFPM Yi Ding <dingyi_yale@163.com> wr=
ote:
> >> The new test added in v1 makes sense to me. A small suggestion is that=
 to verify if a field is really null, we can do:
> >>
> >> ALTER FOREIGN TABLE agg_bad OPTIONS (ADD on_error 'set_null');
> >> SELECT a, b IS NULL FROM agg_bad;
> >
> >Since the file_fdw test runs "\pset null _null_", a NULL value is displa=
yed as
> >"_null_". So you can verify that the value is NULL by checking whether
> >"_null_" is shown.
> >
> >One could argue that this cannot be distinguished from the literal text =
value
> >"_null_". However, relying on "\pset null _null_" is sufficient for this=
 test,
> >I think.
> >
> >Regards,
> >
> >--
> >Fujii Masao
> >
>
> Sounds reasonable,that addressed my comment.

I've pushed the patch. Thanks!

Regards,

--=20
Fujii Masao