MIME-Version: 1.0
References: <CAASxf_P1F75Ck+0qyb10auT+BORupOM4yigXBnm7aWRNx1LYcA@mail.gmail.com>
 <3007317.1765210195@sss.pgh.pa.us> <CAASxf_P5f=Frf8S7rN9BzphtCLoeN9vFuh-V7ukotOQZU54g+w@mail.gmail.com>
In-Reply-To: <CAASxf_P5f=Frf8S7rN9BzphtCLoeN9vFuh-V7ukotOQZU54g+w@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 9 Jan 2026 01:02:31 +0900
Message-ID: <CAHGQGwHAPXexiGaHMkDDRF7cPBr_3fgCNdT4n2+1UjaEU++BAQ@mail.gmail.com>
Subject: Re: [BUG] CRASH: ECPGprepared_statement() and ECPGdeallocate_all()
 when connection is NULL
To: Shruthi Gowda <gowdashru@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, 
	PostgreSQL Development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHGQGwHAPXexiGaHMkDDRF7cPBr_3fgCNdT4n2%2B1UjaEU%2B%2BBAQ%40mail.gmail.com>
Precedence: bulk

On Thu, Jan 8, 2026 at 3:00=E2=80=AFAM Shruthi Gowda <gowdashru@gmail.com> =
wrote:
>
>
> On Mon, Dec 8, 2025 at 9:39=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote=
:
>>
>> Shruthi Gowda <gowdashru@gmail.com> writes:
>> > The ECPG application crashes with a segmentation fault when calling
>> > specific deallocation or prepared statement functions without an
>> > established database connection. This is caused by a missing NULL chec=
k on
>> > the connection handle before attempting to access it.
>>
>> Hmm ... poking around, I see several other places that aren't checking
>> the result of ecpg_get_connection.  Shouldn't we tighten them all?
>>
>>                         regards, tom lane
>
>
> I agree. I=E2=80=99ve reviewed all occurrences of ecpg_get_connection() a=
nd noted that, in most instances, it is followed by ecpg_init(), which vali=
dates the connection and returns immediately if the connection is NULL.

Why did you add this check instead of calling ecpg_init()?
Wouldn't it be better and sufficient to use ecpg_init() to validate
the connection?

+ con =3D ecpg_get_connection(connection_name);
+ if (!con)
+ {
+ ecpg_raise(lineno, ECPG_NO_CONN, ECPG_SQLSTATE_CONNECTION_DOES_NOT_EXIST,
+    connection_name ? connection_name : ecpg_gettext("NULL"));

Regards,

--=20
Fujii Masao