MIME-Version: 1.0
References: <A2B8B7DE-C119-492F-A9FA-14CF86849777@gmail.com>
 <CAHGQGwHnz7FoSx+qQsAHBx_j8Tks+SC-kAPTevrKYfrL08Ee9Q@mail.gmail.com>
 <978D8971-08C3-4AAD-AE8B-976D753C882A@gmail.com>
 <CALDaNm3UyoQ91gW2bRP4PXnnfAv3GfmCik614-AtQCiEUAjQYw@mail.gmail.com>
 <6B9A85F9-B632-4286-98AF-9EC435019055@gmail.com>
 <CA+FpmFdfyBhuiou1uqe94UR3WCg57wM5FsooUx2w27aABGoyag@mail.gmail.com>
 <CAHGQGwHU2E7h7XBCBNK7OJ+OAx7Xkwn+yUb7o5p5GxExi4fzAw@mail.gmail.com>
 <0DCA82A4-7C10-40A7-AEF5-827171160FE8@gmail.com>
 <CAHGQGwEvA2a+jXZdVrdybX9OmWguSU4Q8wEhZxWKkDMOZHnuMQ@mail.gmail.com>
 <0C00CA35-D0C5-40EB-9C23-9F871DCE74E9@gmail.com>
 <2620a664-7b44-48b2-9aa8-5f0131702d9c@eisentraut.org>
 <4FD8124D-6D42-4481-9C41-B658E5378364@gmail.com>
In-Reply-To: <4FD8124D-6D42-4481-9C41-B658E5378364@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 28 May 2026 14:22:21 +0900
Message-ID: 
 <CAHGQGwHBPqis=pP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw@mail.gmail.com>
Subject: Re: Set notice receiver before libpq connection startup
To: Chao Li <li.evan.chao@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Rafia Sabih <rafia.pghackers@gmail.com>,
	vignesh C <vignesh21@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000597d220652d9ea91"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHBPqis%3DpP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw%40mail.gmail.com>
Precedence: bulk

--000000000000597d220652d9ea91
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 28, 2026 at 9:40=E2=80=AFAM Chao Li <li.evan.chao@gmail.com> wr=
ote:
> > The committed patch violates the .gitattributes whitespace rules:
> >
> > git show --check 06a5c3cdef02
> >
> > contrib/postgres_fdw/connection.c:651: indent with spaces.
> > +                                                   /* expand_dbname =
=3D */ false);
> >
> > It is unfortunate that pgindent produces this layout that contradicts t=
he git configuration.  (The current formatting also doesn't look like what =
I would produce in an editor, so I think git is right here.)
> >
> > Maybe we could reformat this slightly to avoid that?  (unless someone w=
ants to try to fix pgindent)

Thanks for the report!


> Ah, I was not aware of the whitespace rule. I think it was not pgindent; =
I made that change manually. I added =E2=80=9C=3D=E2=80=9D because I though=
t it might read more fluently.
>
> Attached is a fix for that.

Thanks for the patch!

I suspect the whitespace issue was caused by pgindent that I ran
before committing the patch.

-     /* expand_dbname =3D */ false);
+    false /* expand_dbname */ );

I think "/* expand_dbname =3D */ false" looks better. libpqwalreceiver.c
also uses that comment style. So how about the attached v2 patch, which
reformats the comment accordingly?

After applying the v2 patch, I confirmed that neither "git show --check ...=
"
nor pgindent reports any issues.

Regards,

--=20
Fujii Masao

--000000000000597d220652d9ea91
Content-Type: application/octet-stream;
	name="v2-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch"
Content-Disposition: attachment;
	filename="v2-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mpp1qgrs0>
X-Attachment-Id: f_mpp1qgrs0

RnJvbSA4MmM1ZTkwNjFjMmU3ZTU0MTgwZDVhZjE3YzM5OTM4MTZhNzMyMmYxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiQ2hhbyBMaSAoRXZhbikiIDxsaWNAaGlnaGdvLmNvbT4KRGF0
ZTogVGh1LCAyOCBNYXkgMjAyNiAwODozMDoyMiArMDgwMApTdWJqZWN0OiBbUEFUQ0ggdjJdIEZp
eCBhbiBpbmRlbnRhdGlvbiBwcm9ibGVtIGluIHBvc3RncmVzX2Zkdy9jb25uZWN0aW9uLmMKClJl
cG9ydGVkLWJ5OiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRyYXV0Lm9yZz4KQXV0aG9y
OiBDaGFvIExpIDxsaWNAaGlnaGdvLmNvbT4KUmV2aWV3ZWQtYnk6CkRpc2N1c3Npb246IGh0dHBz
Oi8vcG9zdGdyLmVzL20vMjYyMGE2NjQtN2I0NC00OGIyLTlhYTgtNWYwMTMxNzAyZDljQGVpc2Vu
dHJhdXQub3JnCi0tLQogY29udHJpYi9wb3N0Z3Jlc19mZHcvY29ubmVjdGlvbi5jIHwgNSArKyst
LQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9jb250cmliL3Bvc3RncmVzX2Zkdy9jb25uZWN0aW9uLmMgYi9jb250cmliL3Bvc3Rn
cmVzX2Zkdy9jb25uZWN0aW9uLmMKaW5kZXggMzQ2ZjZmMWZiZmUuLmFhYjIxNjk1OTc5IDEwMDY0
NAotLS0gYS9jb250cmliL3Bvc3RncmVzX2Zkdy9jb25uZWN0aW9uLmMKKysrIGIvY29udHJpYi9w
b3N0Z3Jlc19mZHcvY29ubmVjdGlvbi5jCkBAIC02NDcsOCArNjQ3LDkgQEAgY29ubmVjdF9wZ19z
ZXJ2ZXIoRm9yZWlnblNlcnZlciAqc2VydmVyLCBVc2VyTWFwcGluZyAqdXNlcikKIAkJCXBnZmR3
X3dlX2Nvbm5lY3QgPSBXYWl0RXZlbnRFeHRlbnNpb25OZXcoIlBvc3RncmVzRmR3Q29ubmVjdCIp
OwogCiAJCS8qIE9LIHRvIG1ha2UgY29ubmVjdGlvbiAqLwotCQlzdGFydF9jb25uID0gbGlicHFz
cnZfY29ubmVjdF9wYXJhbXNfc3RhcnQoa2V5d29yZHMsIHZhbHVlcywKLQkJCQkJCQkJCQkJCSAg
ICAvKiBleHBhbmRfZGJuYW1lID0gKi8gZmFsc2UpOworCQlzdGFydF9jb25uID0KKwkJCWxpYnBx
c3J2X2Nvbm5lY3RfcGFyYW1zX3N0YXJ0KGtleXdvcmRzLCB2YWx1ZXMsCisJCQkJCQkJCQkJICAg
LyogZXhwYW5kX2RibmFtZSA9ICovIGZhbHNlKTsKIAkJUFFzZXROb3RpY2VSZWNlaXZlcihzdGFy
dF9jb25uLCBsaWJwcXNydl9ub3RpY2VfcmVjZWl2ZXIsCiAJCQkJCQkJInJlY2VpdmVkIG1lc3Nh
Z2UgdmlhIHJlbW90ZSBjb25uZWN0aW9uIik7CiAJCWxpYnBxc3J2X2Nvbm5lY3RfY29tcGxldGUo
c3RhcnRfY29ubiwgcGdmZHdfd2VfY29ubmVjdCk7Ci0tIAoyLjUzLjAKCg==
--000000000000597d220652d9ea91--