MIME-Version: 1.0
References: <F780CEEB-A237-4302-9F55-60E9D8B6533D@gmail.com>
 <CAP53PkwEZ+UMmwA8cbUSUdE6phXi+xWmn5t-YAnvKf0qoBnOvg@mail.gmail.com>
 <D83C0F3F-0CD8-4D1D-B59C-F2AFBB9B2974@gmail.com>
 <CDC22691-F63E-4FD3-865A-2982E3B56DCA@gmail.com>
 <7d4afbdb.5322.19d70df0de4.Coremail.wxp_728@163.com>
 <CAHGQGwEM=s5vXPpXoismwRMNCnAmwwMJPnQEQYbPFTJGouV0rQ@mail.gmail.com>
 <56B09FF0-13AB-4AF3-A4C4-29428A695FB0@gmail.com>
In-Reply-To: <56B09FF0-13AB-4AF3-A4C4-29428A695FB0@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 23 Apr 2026 01:11:53 +0900
Message-ID: 
 <CAHGQGwHFHghHRn1427m_ZH_D9t0gytKRa96Uid-pJ4VyZCvyOw@mail.gmail.com>
Subject: Re: pg_test_timing: fix unit typo and widen diff type
To: Chao Li <li.evan.chao@gmail.com>
Cc: "wang.xiao.peng" <wxp_728@163.com>, lukas@fittl.com,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>,
	Hannu Krosing <hannuk@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHFHghHRn1427m_ZH_D9t0gytKRa96Uid-pJ4VyZCvyOw%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 22, 2026 at 5:58=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:
> PFA v4:
>
> * 0001 unchanged from v3.
> * 0002 changed size of histogram[] 64.

Thanks for updating the patch!

Since patch 0001 is a bug fix, it should be backpatched to the supported st=
able
branches. However, in v19 the unit should be changed like s/ms/ns, while in=
 v18
and earlier s/ms/us, since those older branches report the diff in microsec=
onds.
Right?

Patch 0002 looks more like an improvement than a bug fix, so we should prob=
ably
wait for the next CommitFest before committing it. Thoughts?

Regards,


--=20
Fujii Masao