MIME-Version: 1.0
References: <20260204213032.15bab46b@ardentperf.com>
 <CAHGQGwH7c5X4OkPaQ6VDaLGoFgJgwf_-HNwUi2uXoiAhkFkkyA@mail.gmail.com>
 <177304694613.1094603.10800724073727441272.pgcf@coridan.postgresql.org>
 <CAHGQGwG_Ud-N1zrULv8fE51-CUd2ZF3eDe7jUdNOm-rt_JgcQQ@mail.gmail.com>
 <017AD77A-21B6-4B0A-8847-207914D53CE0@gmail.com>
 <CAHGQGwEBvWXU4sdu2DMxaUWdPYQvGesr1VPyX-WnSxtW9nN6UA@mail.gmail.com>
 <DC03170F-ABB9-48A8-AE09-1F93BEB5DBE6@gmail.com>
In-Reply-To: <DC03170F-ABB9-48A8-AE09-1F93BEB5DBE6@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 16 Mar 2026 18:21:50 +0900
Message-ID: 
 <CAHGQGwHH5Tpq7+sGRs2x-z45YH02J0NziNyzHfkwrDXR17=Srg@mail.gmail.com>
Subject: Re: client_connection_check_interval default value
To: Chao Li <li.evan.chao@gmail.com>
Cc: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHH5Tpq7%2BsGRs2x-z45YH02J0NziNyzHfkwrDXR17%3DSrg%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 16, 2026 at 10:37=E2=80=AFAM Chao Li <li.evan.chao@gmail.com> w=
rote:
> V2 overall looks good to me.
>
> A small comment is about the variable name logged_lock_waits that sounds =
like =E2=80=9Ccount of waits=E2=80=9D, I would suggest =E2=80=9Clock_wait_l=
ogged=E2=80=9D. But I see that the name follows the naming convention of th=
e existing variable logged_recovery_conflict, so maybe just rename to logge=
d_lock_wait (remove the =E2=80=9Cs=E2=80=9D).
>

TBH I'm not sure whether renaming the variable that way is a good idea,
but I don't have a strong opinion about this. So I renamed it to
logged_lock_wait (i.e., removed the trailing "s").

I've pushed the patch. Thanks!

Regards,

--=20
Fujii Masao