MIME-Version: 1.0
References: 
 <CAAJ6gzGi9gK6nGjsGCch0nFPdd2+odWatTS1uAGwRDPbHkmSVQ@mail.gmail.com>
 <CABv9HUmAh6UHwePG0PkP-suSweCJDiBcwwLjrSUbZWhVi8xZQg@mail.gmail.com>
In-Reply-To: 
 <CABv9HUmAh6UHwePG0PkP-suSweCJDiBcwwLjrSUbZWhVi8xZQg@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Sat, 23 May 2026 09:41:21 +0900
Message-ID: 
 <CAHGQGwHPA_Zc0=-p8Fc=n1HXwf0UABp=XWCyq9r3vPca7ajDGQ@mail.gmail.com>
Subject: Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion
To: Zhenwei Shang <a934172442@gmail.com>
Cc: Afrah Razzak <mypg.afrah@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHPA_Zc0%3D-p8Fc%3Dn1HXwf0UABp%3DXWCyq9r3vPca7ajDGQ%40mail.gmail.com>
Precedence: bulk

On Wed, May 13, 2026 at 2:49=E2=80=AFPM Zhenwei Shang <a934172442@gmail.com=
> wrote:
>
>
>
> Afrah Razzak <mypg.afrah@gmail.com> =E4=BA=8E2026=E5=B9=B45=E6=9C=8813=E6=
=97=A5=E5=91=A8=E4=B8=89 11:35=E5=86=99=E9=81=93=EF=BC=9A
>>
>> Hi,
>>
>> Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
>> psql's tab completion was not updated to include it.
>>
>> Currently:
>>
>>     EXPLAIN (<Tab>      -- IO is not listed
>>   EXPLAIN (IO <Tab>   -- no ON/OFF offered
>>
>> The attached patch adds IO to both the option keyword list and the
>> boolean ON/OFF completion pattern in tab-complete.in.c.
>>
>> Thanks,
>> Afrah Razzak
>>
> Looks correct to me. EXPLAIN (IO) is a boolean option, so adding it to bo=
th the option keyword list and the ON/OFF completion branch is the right fi=
x.

I've pushed the patch. Thanks!

Regards,

--=20
Fujii Masao