MIME-Version: 1.0
References: <20260204213032.15bab46b@ardentperf.com>
 <CAHGQGwH7c5X4OkPaQ6VDaLGoFgJgwf_-HNwUi2uXoiAhkFkkyA@mail.gmail.com>
 <177304694613.1094603.10800724073727441272.pgcf@coridan.postgresql.org>
 <CAHGQGwG_Ud-N1zrULv8fE51-CUd2ZF3eDe7jUdNOm-rt_JgcQQ@mail.gmail.com>
 <017AD77A-21B6-4B0A-8847-207914D53CE0@gmail.com>
 <CAHGQGwEBvWXU4sdu2DMxaUWdPYQvGesr1VPyX-WnSxtW9nN6UA@mail.gmail.com>
 <CAB5wL7YB1my9W5k5i=SY+=sTjeozyJ0YkvGXrVfeDNzuRkoTPg@mail.gmail.com>
 <CAHGQGwGV3ufcdXnW6JLBhejfptCJRGs7Jrp03YPoO7V_b-2MFA@mail.gmail.com>
 <CAB5wL7amNFF3zA=h5R3Wx1aQZR-EKzv485LyYMLbB9X7dhx2Ew@mail.gmail.com>
In-Reply-To: 
 <CAB5wL7amNFF3zA=h5R3Wx1aQZR-EKzv485LyYMLbB9X7dhx2Ew@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 6 Apr 2026 20:09:30 +0900
Message-ID: 
 <CAHGQGwHPcgESm_cqQ52xeJtLFjfFY4hr+s6byYiojNKOwxO3Mg@mail.gmail.com>
Subject: Re: client_connection_check_interval default value
To: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000003b775d064ec8b4fa"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHPcgESm_cqQ52xeJtLFjfFY4hr%2Bs6byYiojNKOwxO3Mg%40mail.gmail.com>
Precedence: bulk

--0000000000003b775d064ec8b4fa
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 18, 2026 at 4:59=E2=80=AFAM H=C3=BCseyin Demir <huseyin.d3r@gma=
il.com> wrote:
> I created a regression test for the behaviour we mentioned before
> introducing further possible changes.
>
> You can review it. Basically I tried to simulate the desired behaviour
> which the current patch introduced.

Thanks for the patch!

Commit 557a9f1e3e6 recently added test for lock stats, which also causes
lock wait situations. So it seems better to extend that test to cover
log_lock_waits rather than adding a new TAP test file.

I've prepared a patch to do this. Patch attached. Thought?

Regards,

--0000000000003b775d064ec8b4fa
Content-Type: application/octet-stream;
	name="v2-0001-Add-TAP-tests-for-log_lock_waits.patch"
Content-Disposition: attachment;
	filename="v2-0001-Add-TAP-tests-for-log_lock_waits.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnn38n6l0>
X-Attachment-Id: f_mnn38n6l0

RnJvbSAzNzQxY2JkZmEzYTlkYmNjODgzZGFhZWFlMDY4OTE2MjFlODQ0YzNjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IE1vbiwgNiBBcHIgMjAyNiAxNToxNDozNCArMDkwMApTdWJqZWN0OiBbUEFUQ0ggdjJdIEFk
ZCBUQVAgdGVzdHMgZm9yIGxvZ19sb2NrX3dhaXRzCgpUaGlzIGNvbW1pdCB1cGRhdGVzIDAxMV9s
b2NrX3N0YXRzLnBsIHRvIHZlcmlmeSBsb2dfbG9ja193YWl0cyBiZWhhdmlvci4KClRoZSB0ZXN0
cyBjaGVjayB0aGF0IG1lc3NhZ2VzIGFyZSBlbWl0dGVkIGJvdGggd2hlbiBhIHdhaXQgb2NjdXJz
IGFuZAp3aGVuIHRoZSBsb2NrIGlzIGFjcXVpcmVkLCBhbmQgdGhhdCB0aGUgInN0aWxsIHdhaXRp
bmcgZm9yIiBtZXNzYWdlIGlzIGxvZ2dlZApleGFjdGx5IG9uY2UgcGVyIHdhaXQsIGV2ZW4gaWYg
dGhlIGJhY2tlbmQgd2FrZXMgdXAgZHVyaW5nIHRoZSB3YWl0LgoKVGhlIGxhdHRlciBjb3ZlcnMg
dGhlIGJlaGF2aW9yIGludHJvZHVjZWQgYnkgY29tbWl0IGZkNmVjYmZhNzVmLgotLS0KIC4uLi9t
b2R1bGVzL3Rlc3RfbWlzYy90LzAxMV9sb2NrX3N0YXRzLnBsICAgICB8IDY0ICsrKysrKysrKysr
KysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p
CgpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMTFfbG9ja19zdGF0
cy5wbCBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL3QvMDExX2xvY2tfc3RhdHMucGwKaW5k
ZXggNThhMDA0NmE1MmMuLjk5MTBkYjZiZjRlIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9tb2R1bGVz
L3Rlc3RfbWlzYy90LzAxMV9sb2NrX3N0YXRzLnBsCisrKyBiL3NyYy90ZXN0L21vZHVsZXMvdGVz
dF9taXNjL3QvMDExX2xvY2tfc3RhdHMucGwKQEAgLTEsMTMgKzEsMTggQEAKIAogIyBDb3B5cmln
aHQgKGMpIDIwMjYsIFBvc3RncmVTUUwgR2xvYmFsIERldmVsb3BtZW50IEdyb3VwCiAKLSMgVGVz
dCBmb3IgdGhlIGxvY2sgc3RhdGlzdGljcworIyBUZXN0IGZvciB0aGUgbG9jayBzdGF0aXN0aWNz
IGFuZCBsb2dfbG9ja193YWl0cwogIwogIyBUaGlzIHRlc3QgY3JlYXRlcyBtdWx0aXBsZSBsb2Nr
aW5nIHNpdHVhdGlvbnMgd2hlbiBhIHNlc3Npb24gKHMyKSBoYXMgdG8KICMgd2FpdCBvbiBhIGxv
Y2sgZm9yIGxvbmdlciB0aGFuIGRlYWRsb2NrX3RpbWVvdXQuIFRoZSBmaXJzdCB0ZXN0cyBlYWNo
IHRlc3QgYQogIyBkZWRpY2F0ZWQgbG9jayB0eXBlLgogIyBUaGUgbGFzdCBvbmUgY2hlY2tzIHRo
YXQgbG9nX2xvY2tfd2FpdHMgaGFzIG5vIGltcGFjdCBvbiB0aGUgc3RhdGlzdGljcwogIyBjb3Vu
dGVycy4KKyMKKyMgVGhpcyB0ZXN0IGFsc28gY2hlY2tzIHRoYXQgbG9nX2xvY2tfd2FpdHMgbWVz
c2FnZXMgYXJlIGVtaXR0ZWQgYm90aCB3aGVuCisjIGEgd2FpdCBvY2N1cnMgYW5kIHdoZW4gdGhl
IGxvY2sgaXMgYWNxdWlyZWQsIGFuZCB0aGF0IHRoZSAic3RpbGwgd2FpdGluZyBmb3IiCisjIG1l
c3NhZ2UgaXMgbG9nZ2VkIGV4YWN0bHkgb25jZSBwZXIgd2FpdCwgZXZlbiBpZiB0aGUgYmFja2Vu
ZCB3YWtlcyBkdWUKKyMgdG8gc2lnbmFscy4KIAogdXNlIHN0cmljdDsKIHVzZSB3YXJuaW5ncyBG
QVRBTCA9PiAnYWxsJzsKQEAgLTkwLDYgKzk1LDggQEAgSU5TRVJUIElOVE8gdGVzdF9zdGF0X3Rh
YihrZXksIHZhbHVlKSBWQUxVRVMoJ2swJywgMSk7CiAKIHNldHVwX3Nlc3Npb25zKCk7CiAKK215
ICRsb2dfb2Zmc2V0ID0gLXMgJG5vZGUtPmxvZ2ZpbGU7CisKICRzMS0+cXVlcnlfc2FmZSgKIAlx
WwogU0VMRUNUIHBnX3N0YXRfcmVzZXRfc2hhcmVkKCdsb2NrJyk7CkBAIC0xMTIsNiArMTE5LDE4
IEBAIExPQ0sgVEFCTEUgdGVzdF9zdGF0X3RhYjsKIAogd2FpdF9hbmRfZGV0YWNoKCRub2RlLCAn
ZGVhZGxvY2stdGltZW91dC1maXJlZCcpOwogCisjIENoZWNrIHRoYXQgbG9nX2xvY2tfd2FpdHMg
bWVzc2FnZSBpcyBlbWl0dGVkIGR1cmluZyBhIGxvY2sgd2FpdC4KKyRub2RlLT53YWl0X2Zvcl9s
b2cocXIvc3RpbGwgd2FpdGluZyBmb3IgQWNjZXNzRXhjbHVzaXZlTG9jayBvbiByZWxhdGlvbi8s
CisJJGxvZ19vZmZzZXQpOworCisjIFdha2UgdGhlIGJhY2tlbmQgd2FpdGluZyBvbiB0aGUgbG9j
ay4gQ29uZmlybSBpdCB3b2tlIGJ5IGNhbGxpbmcKKyMgcGdfbG9nX2JhY2tlbmRfbWVtb3J5X2Nv
bnRleHRzKCkgYW5kIGNoZWNraW5nIGZvciB0aGUgbG9nZ2VkIG1lbW9yeSBjb250ZXh0cy4KKyRu
b2RlLT5zYWZlX3BzcWwoCisJJ3Bvc3RncmVzJywgcVtTRUxFQ1QgcGdfbG9nX2JhY2tlbmRfbWVt
b3J5X2NvbnRleHRzKHBpZCkKKwlGUk9NIHBnX2xvY2tzIFdIRVJFIGxvY2t0eXBlID0gJ3JlbGF0
aW9uJyBBTkQKKwlyZWxhdGlvbiA9ICd0ZXN0X3N0YXRfdGFiJzo6cmVnY2xhc3MgQU5EIE5PVCBn
cmFudGVkO10pOworJG5vZGUtPndhaXRfZm9yX2xvZyhxci9sb2dnaW5nIG1lbW9yeSBjb250ZXh0
cy8sICRsb2dfb2Zmc2V0KTsKKwogIyBkZWFkbG9ja190aW1lb3V0IGZpcmVkLCBub3cgY29tbWl0
IGluIHMxIGFuZCBzMgogJHMxLT5xdWVyeV9zYWZlKHEoQ09NTUlUKSk7CiAkczItPnF1ZXJ5X3Nh
ZmUocShDT01NSVQpKTsKQEAgLTEyMCw2ICsxMzksMTggQEAgJHMyLT5xdWVyeV9zYWZlKHEoQ09N
TUlUKSk7CiB3YWl0X2Zvcl9wZ19zdGF0X2xvY2soJG5vZGUsICdyZWxhdGlvbicpOwogb2soMSwg
IkxvY2sgc3RhdHMgb2sgZm9yIHJlbGF0aW9uIik7CiAKKyMgQ2hlY2sgdGhhdCBsb2dfbG9ja193
YWl0cyBtZXNzYWdlIGlzIGVtaXR0ZWQgd2hlbiB0aGUgbG9jayBpcyBhY3F1aXJlZAorIyBhZnRl
ciB3YWl0aW5nLgorJG5vZGUtPndhaXRfZm9yX2xvZyhxci9hY3F1aXJlZCBBY2Nlc3NFeGNsdXNp
dmVMb2NrIG9uIHJlbGF0aW9uLywKKwkkbG9nX29mZnNldCk7CisKKyMgQ2hlY2sgdGhhdCB0aGUg
InN0aWxsIHdhaXRpbmcgZm9yIiBtZXNzYWdlIGlzIGxvZ2dlZCBleGFjdGx5IG9uY2UgcGVyIHdh
aXQsCisjIGV2ZW4gaWYgdGhlIGJhY2tlbmQgd2FrZXMgZHVyaW5nIHRoZSB3YWl0LgorbXkgJGxv
Z19jb250ZW50cyA9IHNsdXJwX2ZpbGUoJG5vZGUtPmxvZ2ZpbGUsICRsb2dfb2Zmc2V0KTsKK215
IEBzdGlsbF93YWl0aW5nID0gKCRsb2dfY29udGVudHMgPX4gL3N0aWxsIHdhaXRpbmcgZm9yL2cp
OworaXMoc2NhbGFyIEBzdGlsbF93YWl0aW5nLAorCTEsICJzdGlsbCB3YWl0aW5nIGxvZ2dlZCBl
eGFjdGx5IG9uY2UgZGVzcGl0ZSBwZ19yZWxvYWRfY29uZigpIHdha2V1cHMiKTsKKwogIyBjbG9z
ZSBzZXNzaW9ucwogJHMxLT5xdWl0OwogJHMyLT5xdWl0OwpAQCAtMTI4LDYgKzE1OSw4IEBAICRz
Mi0+cXVpdDsKIAogc2V0dXBfc2Vzc2lvbnMoKTsKIAorJGxvZ19vZmZzZXQgPSAtcyAkbm9kZS0+
bG9nZmlsZTsKKwogJHMxLT5xdWVyeV9zYWZlKAogCXFbCiBTRUxFQ1QgcGdfc3RhdF9yZXNldF9z
aGFyZWQoJ2xvY2snKTsKQEAgLTE1Miw2ICsxODUsMTAgQEAgVVBEQVRFIHRlc3Rfc3RhdF90YWIg
U0VUIHZhbHVlID0gdmFsdWUgKyAxIFdIRVJFIGtleSA9ICdrMSc7CiAKIHdhaXRfYW5kX2RldGFj
aCgkbm9kZSwgJ2RlYWRsb2NrLXRpbWVvdXQtZmlyZWQnKTsKIAorIyBDaGVjayB0aGF0IGxvZ19s
b2NrX3dhaXRzIG1lc3NhZ2UgaXMgZW1pdHRlZCBkdXJpbmcgYSBsb2NrIHdhaXQuCiskbm9kZS0+
d2FpdF9mb3JfbG9nKHFyL3N0aWxsIHdhaXRpbmcgZm9yIFNoYXJlTG9jayBvbiB0cmFuc2FjdGlv
bi8sCisJJGxvZ19vZmZzZXQpOworCiAjIGRlYWRsb2NrX3RpbWVvdXQgZmlyZWQsIG5vdyBjb21t
aXQgaW4gczEgYW5kIHMyCiAkczEtPnF1ZXJ5X3NhZmUocShDT01NSVQpKTsKICRzMi0+cXVlcnlf
c2FmZShxKENPTU1JVCkpOwpAQCAtMTYwLDYgKzE5NywxMCBAQCAkczItPnF1ZXJ5X3NhZmUocShD
T01NSVQpKTsKIHdhaXRfZm9yX3BnX3N0YXRfbG9jaygkbm9kZSwgJ3RyYW5zYWN0aW9uaWQnKTsK
IG9rKDEsICJMb2NrIHN0YXRzIG9rIGZvciB0cmFuc2FjdGlvbmlkIik7CiAKKyMgQ2hlY2sgdGhh
dCBsb2dfbG9ja193YWl0cyBtZXNzYWdlIGlzIGVtaXR0ZWQgd2hlbiB0aGUgbG9jayBpcyBhY3F1
aXJlZAorIyBhZnRlciB3YWl0aW5nLgorJG5vZGUtPndhaXRfZm9yX2xvZyhxci9hY3F1aXJlZCBT
aGFyZUxvY2sgb24gdHJhbnNhY3Rpb24vLCAkbG9nX29mZnNldCk7CisKICMgQ2xvc2Ugc2Vzc2lv
bnMKICRzMS0+cXVpdDsKICRzMi0+cXVpdDsKQEAgLTE2OCw2ICsyMDksOCBAQCAkczItPnF1aXQ7
CiAKIHNldHVwX3Nlc3Npb25zKCk7CiAKKyRsb2dfb2Zmc2V0ID0gLXMgJG5vZGUtPmxvZ2ZpbGU7
CisKICRzMS0+cXVlcnlfc2FmZSgKIAlxWwogU0VMRUNUIHBnX3N0YXRfcmVzZXRfc2hhcmVkKCds
b2NrJyk7CkBAIC0xOTAsNiArMjMzLDEwIEBAIFNFTEVDVCBwZ19hZHZpc29yeV9sb2NrKDEpOwog
CiB3YWl0X2FuZF9kZXRhY2goJG5vZGUsICdkZWFkbG9jay10aW1lb3V0LWZpcmVkJyk7CiAKKyMg
Q2hlY2sgdGhhdCBsb2dfbG9ja193YWl0cyBtZXNzYWdlIGlzIGVtaXR0ZWQgZHVyaW5nIGEgbG9j
ayB3YWl0LgorJG5vZGUtPndhaXRfZm9yX2xvZyhxci9zdGlsbCB3YWl0aW5nIGZvciBFeGNsdXNp
dmVMb2NrIG9uIGFkdmlzb3J5IGxvY2svLAorCSRsb2dfb2Zmc2V0KTsKKwogIyBkZWFkbG9ja190
aW1lb3V0IGZpcmVkLCBub3cgdW5sb2NrIGFuZCBjb21taXQgczIKICRzMS0+cXVlcnlfc2FmZShx
KFNFTEVDVCBwZ19hZHZpc29yeV91bmxvY2soMSkpKTsKICRzMi0+cXVlcnlfc2FmZSgKQEAgLTIw
Miw2ICsyNDksMTAgQEAgQ09NTUlUOwogd2FpdF9mb3JfcGdfc3RhdF9sb2NrKCRub2RlLCAnYWR2
aXNvcnknKTsKIG9rKDEsICJMb2NrIHN0YXRzIG9rIGZvciBhZHZpc29yeSIpOwogCisjIENoZWNr
IHRoYXQgbG9nX2xvY2tfd2FpdHMgbWVzc2FnZSBpcyBlbWl0dGVkIHdoZW4gdGhlIGxvY2sgaXMg
YWNxdWlyZWQKKyMgYWZ0ZXIgd2FpdGluZy4KKyRub2RlLT53YWl0X2Zvcl9sb2cocXIvYWNxdWly
ZWQgRXhjbHVzaXZlTG9jayBvbiBhZHZpc29yeSBsb2NrLywgJGxvZ19vZmZzZXQpOworCiAjIENs
b3NlIHNlc3Npb25zCiAkczEtPnF1aXQ7CiAkczItPnF1aXQ7CkBAIC0yMTAsNiArMjYxLDggQEAg
JHMyLT5xdWl0OwogCiBzZXR1cF9zZXNzaW9ucygpOwogCiskbG9nX29mZnNldCA9IC1zICRub2Rl
LT5sb2dmaWxlOworCiAkczEtPnF1ZXJ5X3NhZmUoCiAJcVsKIFNFTEVDVCBwZ19zdGF0X3Jlc2V0
X3NoYXJlZCgnbG9jaycpOwpAQCAtMjQxLDYgKzI5NCwxNSBAQCAkczItPnF1ZXJ5X3NhZmUocShD
T01NSVQpKTsKIHdhaXRfZm9yX3BnX3N0YXRfbG9jaygkbm9kZSwgJ3JlbGF0aW9uJyk7CiBvaygx
LCAibG9nX2xvY2tfd2FpdHMgaGFzIG5vIGltcGFjdCBvbiBMb2NrIHN0YXRzIik7CiAKKyMgQ2hl
Y2sgdGhhdCBubyBsb2dfbG9ja193YWl0cyBtZXNzYWdlcyBhcmUgZW1pdHRlZAorb2soICEkbm9k
ZS0+bG9nX2NvbnRhaW5zKAorCQkic3RpbGwgd2FpdGluZyBmb3IgQWNjZXNzRXhjbHVzaXZlTG9j
ayBvbiByZWxhdGlvbiIsICRsb2dfb2Zmc2V0KSwKKwknY2hlY2sgdGhhdCBubyBsb2dfbG9ja193
YWl0cyBtZXNzYWdlIGlzIGVtaXR0ZWQgZHVyaW5nIGEgbG9jayB3YWl0Jyk7CitvayggISRub2Rl
LT5sb2dfY29udGFpbnMoCisJCSJhY3F1aXJlZCBBY2Nlc3NFeGNsdXNpdmVMb2NrIG9uIHJlbGF0
aW9uIiwgJGxvZ19vZmZzZXQpLAorCSdjaGVjayB0aGF0IGxvZ19sb2NrX3dhaXRzIG1lc3NhZ2Ug
aXMgZW1pdHRlZCB3aGVuIHRoZSBsb2NrIGlzIGFjcXVpcmVkIGFmdGVyIHdhaXRpbmcnCispOwor
CiAjIGNsb3NlIHNlc3Npb25zCiAkczEtPnF1aXQ7CiAkczItPnF1aXQ7Ci0tIAoyLjUxLjIKCg==
--0000000000003b775d064ec8b4fa--