MIME-Version: 1.0
References: 
 <CAAJ_b95-xMvUN1PEqxv8y6g-A-8k+fSgyv20kSZc9eF1wZAUPg@mail.gmail.com>
In-Reply-To: 
 <CAAJ_b95-xMvUN1PEqxv8y6g-A-8k+fSgyv20kSZc9eF1wZAUPg@mail.gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Mon, 20 Apr 2026 21:20:22 +0900
Message-ID: 
 <CAHGQGwHRAs4LQwtWM2OY0w3Z6kM3fCwnjGdy=nx4oGsCA3SC7w@mail.gmail.com>
Subject: Re: Cleanup: Use modern macro for text-to-CString conversion in
 plsample.c
To: Amul Sul <sulamul@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHRAs4LQwtWM2OY0w3Z6kM3fCwnjGdy%3Dnx4oGsCA3SC7w%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 17, 2026 at 9:55=E2=80=AFPM Amul Sul <sulamul@gmail.com> wrote:
>
> Hi,
>
> I noticed that plsample.c uses an outdated method to convert text data
> to a C string. This old method calls the textout function manually,
> which adds unnecessary overhead.
>
> The attached patch replaces this with the TextDatumGetCString() macro.
> This macro is more efficient and automatically handles "detoasting"
> (decompressing/fetching) the data.
>
> Since plsample serves as a template for developers writing new
> extensions, it should follow current best practices. This patch
> updates the code in both the function and trigger handlers.

LGTM.

Regards,


--=20
Fujii Masao