MIME-Version: 1.0
References: <CAHGQGwGWyApGA0L-uE819xeinwSonPXQfV1diBUCkR+AcgxuOw@mail.gmail.com>
 <202601201506.yrmcvqjl2bnc@alvherre.pgsql> <CAHGQGwH3PJ8an=Z-70s3Nv=YY3btAJ=qD76Tivh2XgnABq8Xmg@mail.gmail.com>
 <MN2PR15MB3021F257D141B286206F0DC6A796A@MN2PR15MB3021.namprd15.prod.outlook.com>
In-Reply-To: <MN2PR15MB3021F257D141B286206F0DC6A796A@MN2PR15MB3021.namprd15.prod.outlook.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Thu, 22 Jan 2026 10:18:08 +0900
Message-ID: <CAHGQGwHUyyZMWEY+T6-3kRLE1uwJhUeeKOFpfM_AW4RipxNQNg@mail.gmail.com>
Subject: Re: file_fdw: Support multi-line HEADER option.
To: Steven Niu <niushiji@gmail.com>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>, 
	Shinya Kato <shinya11.kato@gmail.com>, Chao Li <li.evan.chao@gmail.com>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHGQGwHUyyZMWEY%2BT6-3kRLE1uwJhUeeKOFpfM_AW4RipxNQNg%40mail.gmail.com>
Precedence: bulk

On Wed, Jan 21, 2026 at 5:18=E2=80=AFPM Steven Niu <niushiji@gmail.com> wro=
te:
> I've noticed an inconsistent naming convention in the patch:
> we use a capitalized Boolean for the boolean type, but a lowercase intege=
r when referring to the value type.
>
> + errmsg("%s requires a Boolean value, an integer "
> +               "value greater than or equal to zero
>
> Is there any reason why we follow this mixed style?

I don't have a strong opinion on this. "Boolean value" has been used in com=
mand
error messages from before, and I couldn't find any messages that use the t=
erm
"Integer". So I committed the patch with the original wording. If this turn=
s out
to be an issue, we can revisit it later.


> Another nitpick in v6-0001 patch:
> tow whitespaces are between "special" and "value"
> +                second %s is the special  value "match" for that option =
*/

Thanks for catching that! I've fixed it.

I've pushed the patches. Thanks!

Regards,

--=20
Fujii Masao