Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wBCg6-000py6-35 for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 14:17:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wBCg5-00CRTS-0x for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 14:17:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wBCg5-00CRTH-00 for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 14:17:45 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wBCg3-00000000LN0-3eYb for pgsql-hackers@postgresql.org; Fri, 10 Apr 2026 14:17:45 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-7dbd1458a77so1584960a34.2 for ; Fri, 10 Apr 2026 07:17:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775830663; cv=none; d=google.com; s=arc-20240605; b=gzQwrYCqRJJWt1sq+xdpvLrViZn8wPC9vV+XaaNTHzpqjMzQ/7OjmhmnBXTqoqZ59+ vKLtlNnCxJHs2q2QdZrsAGFRhDpH4B3iYfDV1X2Ate+8by0p0jz8gX5jI2hdFNcCOQ55 IIh3lhiln4h/odyrKc9E63gddsyUEZsdbwW6xomTaVZHGlrMxq+gpPlgWj4j+joF1zbl /nPUiSY1bY75tk8egprIci4Ni5ccUAVqTjqYTyR+5V8oQYIxl68GBTmVcunhSnxaM+FS HQHGmUMzSKSolUMN5MRxcpsECfdicma06xU8Jb1xKqG1Aj/yEnRRPCVQiWIVxDYSPrvC 18Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=0ivx7/YrURgF4nVJUeEMyJXKO385Q/DlJxzCFxVaBEc=; fh=XuGnccLZfCGAU4xv//haxFo6o2sj5bVNhvI1Pejj59s=; b=coLWS4Ml+cG+2eCaXI8CX1sXYNyQW35TL6ASGfl+qwa1nesJ9MDrSDMhDTzPNhvVIT k4vFpsaFqpmhOx4onwoA3N6dzmKMS4a+u6xUTPxhRfHIi2+GxWzVJ7KWr9ktSclaVy9/ 69IB8pmZopyIKXziEGoAHLwv7IyFphiublQVRJyuVRxmf+gSSqEzI/VB2t96t5a4hYyF tZcKu+XR6URoI/18CQA6NCN3KkG2Sqq0lrcfoOtsrhUIjFUFl0XbyE+scSFXtNIIcY5y 1mPRAvBsfHC9man2Jj5pd5n8ppp29nSDc+srACGJ5f4LLTZO5EaMqf0h1Mj+5fXcwR4e MRnA==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775830663; x=1776435463; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0ivx7/YrURgF4nVJUeEMyJXKO385Q/DlJxzCFxVaBEc=; b=GTcuMtYQ2z+8A4PDMdYTBoM76ixEFSJ2N4RNAc3z5PjaLWJc2Jj3m4kjpHT3T+5YJC qjumCUf9gRyCY28NUcnTe0bURjgcF9Ce75ZquguYnOZ/0DxNYUNofztjpZ9kGXsMpCao LYuU+kMhPrwBuX/hAJkvP/drryO9Ko83S6n7q0ansWhfXGvSYKT2bqJ/ZYEgaV2ObWIl NbnUg57hAZzlyVVI/18OFgunqHghoA99BkbPAxwxHLIlAF7FSK77t/61HKXKCdsWFzBD hsqQrxFiRFOke40jHU4sREU5ceFoFLJbpMHYBxxgp6d91r4Rnj/Rt7bUOpRlbMPXDHIS s3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775830663; x=1776435463; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0ivx7/YrURgF4nVJUeEMyJXKO385Q/DlJxzCFxVaBEc=; b=LF82eBbBomHbYzFiIU9JrfS+nMiuFko439GziglcSrSW8M0EE7BiTU/jA8DX24UkHo x0aPCJkuepG0iph6SVBnUBwgfcL3vjerVpsNU1CiMDLjMVFlhXxEvjhQ9tR0lNUvtnEz IecMqQppcp6y+DlSx3VxY70ae1+SzJnL8PdV8IrZwMiODEpe6xhm0QXOOcVnjWjxXEH0 r1ApbVB0DjBSdbQu29j0kF41ffim+wPwjNbMw+39yfO/MJUeWjnXLVHrYMtO4VV13Z2P BBRU942b/BYYSAGpD9Ftj03uAFShxOONjTGWHU8gGZNpofFI82UHC5IO6fOSjjjERwau RnXw== X-Forwarded-Encrypted: i=1; AJvYcCXBcdJrMX1ihiQO1MXPzYxuFbAW3I3ehsBlU6ghCHyXFyXMvQAKzYJ2ElGBpLvY8AlvPK1sfRoWPifSFVNR@postgresql.org X-Gm-Message-State: AOJu0YwRcC1MXxKNSmJviRmoG5kR4AmKJw2521fqkVKTXGjaBvsy5ZZ4 nHumAi1vG0zA77PYs5VzIx5YdVmk82KBPGlKHVv6vblDqa7KaRd3FicW11CMibpkBUulfdsuEPc ihTRWakK6fIPUhB6VKkNRJjAg3BGxhys= X-Gm-Gg: AeBDiev2uWmOyT4IqVmHXxW5asocfPvVl7zQWpKnCE8BJMwLga5ysRW7+shgjwEKouc XDDh1Pz8MFz7FOwiw0Rs39XXs1JwHSiqWTpVNcU5w4tSbKQZVqPjL7aLiBxtTcyXnjzymDnpTKJ k33xfxPMRl3wfrWcPp0EjuYRC68Mr1qwFEZgYIrOUgTeJgrbm7PYGEPospI6rwUZQ4CCKsreaZ3 5OI5f9hWjAQIRdFoSIbfVAiDgKqjGgUHaijfDd7244HK7otR45+Df8INfb7NVcO17jpqnu8HUUq rruB5I2XQdD2NlE8J1m4R+oVydkdH9w4KkDdAUVHjA== X-Received: by 2002:a05:6808:191a:b0:45e:e088:5f3e with SMTP id 5614622812f47-478a080ba3amr1772937b6e.49.1775830663366; Fri, 10 Apr 2026 07:17:43 -0700 (PDT) MIME-Version: 1.0 References: <74381238-4E8A-4621-B794-57025DCCE0BA@gmail.com> <6a42c40e-eb81-4212-9bca-8c0eb02d47d1@proxel.se> <0D17D4E1-919F-4412-8EFE-BEB80211321D@gmail.com> In-Reply-To: <0D17D4E1-919F-4412-8EFE-BEB80211321D@gmail.com> From: Fujii Masao Date: Fri, 10 Apr 2026 23:17:29 +0900 X-Gm-Features: AQROBzCMsI8hJT0AEnRhacMuTtz6cdj-nFKQG_tjNWiIYdY0D54KN8bbCOL6J6M Message-ID: Subject: Re: Use proc_exit() in WalRcvWaitForStartPosition To: Chao Li Cc: Xuneng Zhou , Andreas Karlsson , PostgreSQL-development Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Apr 10, 2026 at 4:07=E2=80=AFPM Chao Li wr= ote: > PFA v2 - updated header comment of walreceive.c. I tried to avoid mention= ing the exact exit value in the comment, so I just changed =E2=80=9Cexit(0)= =E2=80=9D to =E2=80=9Cterminate=E2=80=9D. Thanks for updating the patch! "termination instructs XXX to terminate" sounds a bit redundant. How about saying "to ereport(FATAL)" instead of =E2=80=9Cto terminate=E2=80=9D? Regards, --=20 Fujii Masao