MIME-Version: 1.0
References: 
 <CAOzEurQKuy3RiPkd=25PEwEzaqHuGvEOf=X7vaVzhgNjaukYzA@mail.gmail.com>
 <CAHGQGwEpwuq9U=Hhx3BbfGY-RrJ5rFvdQopO+0xyAuLVsMdfWA@mail.gmail.com>
 <tencent_B56532E9785E072776FBA169850EB5032908@qq.com>
In-Reply-To: <tencent_B56532E9785E072776FBA169850EB5032908@qq.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 8 May 2026 13:21:31 +0900
Message-ID: 
 <CAHGQGwHfdbfRRVdQjYRZmT94UMqE1W4MENiaseVtsHWmzkWxBQ@mail.gmail.com>
Subject: Re: Call EndCopyFrom() after initial table sync in logical
 replication
To: cca5507 <cca5507@qq.com>
Cc: Shinya Kato <shinya11.kato@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHfdbfRRVdQjYRZmT94UMqE1W4MENiaseVtsHWmzkWxBQ%40mail.gmail.com>
Precedence: bulk

On Fri, May 8, 2026 at 11:34=E2=80=AFAM cca5507 <cca5507@qq.com> wrote:
>
> Hi,
>
> Maybe we want to add "free_parsestate(pstate);" after the "EndCopyFrom()"=
 as well?

What actual issue could occur if free_parsestate() is not called there?

Since pstate->p_target_relation does not seem to be used afterward,
omitting free_parsestate() appears mostly harmless to me. Bascailly
calling free_parsestate() after make_parsestate() seems intuitive,
but from a quick grep I found several places that call make_parsestate()
without a corresponding free_parsestate().

Regards,

--=20
Fujii Masao