Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wOpQ4-000D6d-1h for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2026 04:17:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wOpQ2-0013yX-1O for pgsql-hackers@arkaria.postgresql.org; Mon, 18 May 2026 04:17:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wOpQ2-0013yP-0N for pgsql-hackers@lists.postgresql.org; Mon, 18 May 2026 04:17:31 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wOpQ1-000000007tL-03gN for pgsql-hackers@lists.postgresql.org; Mon, 18 May 2026 04:17:30 +0000 Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-479d37e7d7fso463050b6e.1 for ; Sun, 17 May 2026 21:17:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779077846; cv=none; d=google.com; s=arc-20240605; b=JjlUWS74uHfqt//Vw5Mm+iyg3g49Nyl1uIrHnQa7RMBEMd4XJgJH2fzDG3sBWoAsES sdTlNLkPPnFYoFd0A3mFX1oDab8WH6q7o1Zv+cCOw7PUcI3zsEvzyjEYtR4076FEy3ED ILz88qhJ+RCITXdR7UJXd8FvXNOxLjYC/Y+FdIc2IoB5vn6aD8ZrYcXJt2G7XShO1/5K 5bi14aCMTuCI9UgNzI3/vfCZ4t2fVIpJjW5liJHu7PNarS5J6Cj0CQicC51qbujqyTlX n69Z08rPFv4SrF621MzkInefryG82QpKho6/KbXGWFQFP/gPa/sLUiSHv/UUdW0325Xw tjHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=VSCf28oGJ/QBIHU8+YXNN3tJynx77pFZ//dzFbwXXAM=; fh=JRmO00eTI9/al7B6zDI7tXh07MehN8kbCMbrcumkWg8=; b=QlzJDbm/06re03udJvNFTnZnXIhHjjjilJrHW+g4kAWic/tuLHq8N1OTDDOfUBMgE0 msTYKy6+sVd8l//D+Tr29bt8Gc2QTGwZm6lchaGTX4XZIaR9A33Ffb0xKOihsXJO1F6e u3hXwofEFIcJ+uGcQjOIib0halg0GfL7ITe9Jb2NTFAb4taDmO6j95CP4OWKoton+9vz q7L/CNrPQ2dQF00hdkfTBsLsWgwrPp0PB43wwNJ65zNWMw8QKo7nK1liC5CwbeXLbFur 3keWwr+eUrd1VX4uOqEDfnPcTcyeR3zwbI37SFznwfxyRo7ihsqlBTjUztYhMNXPFEp5 TenQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779077846; x=1779682646; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VSCf28oGJ/QBIHU8+YXNN3tJynx77pFZ//dzFbwXXAM=; b=cXuZPuTsWSOH447K35tpYuIQDLPHehAg+gZhShIBrgCtbQ4ZCLwA3bBWcj+ZcMC6QQ Px0Ijpih7WASrwdatWBNHJkpgk/PwvHfpUPVh+pNMOt2iE2/pJGqwy3Ga1DHtvstXqzY X1GE9BHVgYmCkgCcFSQg8N28rndiG+OYEibeqmN+lYqtVEKT0coe71n3ewLkZibh0jkj jGcqpyuI+i1ZqPSoZqp/9togz8y03VB4WWGh+06IE2O+T2d9qUMvwlSynnLxIKnAN9Ub 0WJtSOCA+LHjrqpEUqoL7Va0DGAoUfG2KsQUO+g0D8X/WFe44Ge8o+4q0q1morBeF1lq nPhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779077846; x=1779682646; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VSCf28oGJ/QBIHU8+YXNN3tJynx77pFZ//dzFbwXXAM=; b=kV6qPETaWxtCnoJGqkZt6qqNEmjF691R+rKVeKFo9DuE9Ar9E3fA5+lbqjKdFcSXfR pg8dFc2/UdM5FEtakfAKdiOz/jT9pXzrNNiASX8N/RS8PPGIQhs6Yrqc7P4iAVx73Bh8 opJhH50tC489GoeMCYsh2/LjVI2/zh4yOyKWKMENSJcK2WSAResI2x6/UP4/X1T/q0jL IlN4jRk5G84AicqOKh2Y8sa7TlsfN8aIZFleW+Scd4RaDqoZQ8xVaoAavfdG8TQt+pAl BR7ukd0TsITh91PvYtZTzz3yScQUnEjNVqgRZc545TRY0y00MzV4t16YtULOhD88Ptab HgTw== X-Forwarded-Encrypted: i=1; AFNElJ8cvlX5nUWxRRD+XaiiuJre9D7Xk4F4RlTgJvn4QYycJ3bBlrVvO2qasv/AWKdaOEulwbJ/X+p5i4imMCIM@lists.postgresql.org X-Gm-Message-State: AOJu0YyIrCH8H/lQ/ayQQE1KFpjObgopNc3RagjNX7D2Z1ITB33r3xk7 C0s68Cl17ECx10SgKEiyUEWKoFVOa4xRPJkhg/nKssyP8qreFtH/1uIufDxnWzdrve7R+ta7oUF eyJJ/fP6CL6eZwwP2SpEy9DXQ5OjcvL4= X-Gm-Gg: Acq92OGV9XFWwDOIV73bIfowobA5rF6E69M0e/UPCpkHEJPoRF/JCf/tWew0RBv9/ds m0uDKOWRbvl6jKc4zJNK9VgJLWm2ibF+iAx26tP82CowCgFLAyvrTA9P5fnpxCOT8cQ46FtMZOw IwXZ4ayMxWG2ReikvMe2HmtjUoQGn0bAgFI8wz2AinQ4wIhW4BdRxlPBHtxxWvC1rYYubC3Hb/v bFP5UfnVkvOz8SeF7OhmUK8R2t4pIRSdElMpGUl1/0GcMaJ3YAM+8PcyMRRb93nYPulH1rojSbO lJ14wc2H7otvA8TqoEWYqXzI11N2mVo3rnddAD0YltE6H8Zxruqi X-Received: by 2002:a05:6820:20e:b0:696:13e9:6855 with SMTP id 006d021491bc7-69c942fc917mr9408362eaf.15.1779077846517; Sun, 17 May 2026 21:17:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Fujii Masao Date: Mon, 18 May 2026 13:17:13 +0900 X-Gm-Features: AVHnY4IYGpJDX1uq-02Y0NmwB0vSXTUCvWQJw6qihIkUYp4HGatQseKXuWx_vnY Message-ID: Subject: Re: [PATCH] Fix psql tab completion for REPACK boolean options To: =?UTF-8?Q?=C3=81lvaro_Herrera?= Cc: Baji Shaik , pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, May 15, 2026 at 11:32=E2=80=AFPM =C3=81lvaro Herrera wrote: > > Second, when the same option is specified multiple times, the last valu= e > > is not always honored. In particular, if any occurrence sets an option = to ON, > > the option remains enabled even when the final setting is OFF. > > > > I think these are bugs, and the attached patch fixes them. Thoughts? > > I agree that these are bugs. The patch looks good to me on a cursory > look, though I didn't actually test it. Thanks for the review! I've tested it again and then pushed it. Regards, --=20 Fujii Masao