public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Srinath Reddy Sadipiralla <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_recvlogical: honor source cluster file permissions for output files
Date: Mon, 18 May 2026 19:47:15 +0900
Message-ID: <CAHGQGwHz8aOjPbJd+mCb=OuYdfZQ-RkeatuQrfDCE4cqJxt69w@mail.gmail.com> (raw)
In-Reply-To: <CAFC+b6qaCMoO7JZUx-etHJhinvPpQow8GKXZDXFfrCydeDtAdQ@mail.gmail.com>
References: <CAHGQGwHhpizYzMo3nFP4GkNMueSNMY3QfC-gBN1VTXtuiANDvw@mail.gmail.com>
	<CAFC+b6qaCMoO7JZUx-etHJhinvPpQow8GKXZDXFfrCydeDtAdQ@mail.gmail.com>

On Sun, May 17, 2026 at 12:22 AM Srinath Reddy Sadipiralla
<[email protected]> wrote:
> i have reviewed, tested the patch and it LGTM,

Thanks for the review!


> i think we can add
> a TAP test to verify the group permission, attached a diff patch
> for the same,

Thanks for the patch!

The test you added checks that pg_recvlogical creates output files with
mode 0640 when the cluster is initialized with group access enabled.
However, it does not check the opposite case, i.e., that pg_recvlogical
creates output files with mode 0600 when group access is disabled.

It seems we should test both cases, similar to what 010_basebackup.pl does?

As far as I can tell, 010_basebackup.pl initializes the cluster without group
access and checks the backup permissions, then enables group access using
chmod_recursive() and verifies that group permissions are also applied to
the backup. I updated the TAP test following this approach and attached
a revised patch.


>> I think this should be backpatched to all supported branches.
>
>
> +1

I'm currently thinking of backpatching the fix itself to all supported branches,
but adding the test only to master. Because it does not seem worthwhile to
spend much time backporting the test to older branches, where the test code
differs much from master. Thought?

Regards,

-- 
Fujii Masao

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pg_recvlogical: honor source cluster file permissions for output files
  In-Reply-To: <CAHGQGwHz8aOjPbJd+mCb=OuYdfZQ-RkeatuQrfDCE4cqJxt69w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox