MIME-Version: 1.0
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 10 Jul 2026 12:13:37 +0900
Message-ID: 
 <CAHGQGwHz_-nt+YkHDMRZNBZrnoHro8cMOgSwuXEmSYT6vxgQ=w@mail.gmail.com>
Subject: Restrict data checksums entries in pg_stat_io
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000032c18a065639212f"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHz_-nt%2BYkHDMRZNBZrnoHro8cMOgSwuXEmSYT6vxgQ%3Dw%40mail.gmail.com>
Precedence: bulk

--00000000000032c18a065639212f
Content-Type: text/plain; charset="UTF-8"

Hi,

While reviewing the data checksums docs at [1], I found that the data checksums
launcher and workers are exposed in pg_stat_io with the same broad set of
object/context combinations as general background workers.

However, several of those entries can never accumulate I/O statistics.
For example, as far as I understand correctly, the launcher never processes
relations itself, and the workers neither operate on temporary relations nor
use the bulkread or bulkwrite contexts. So I think it would be better to
restrict the reported entries to those that the data checksums processes
can actually use.

The attached patch teaches pgstat_tracks_io_object() and pgstat_tracks_io_op()
about the actual I/O paths used by these processes. After the patch,
pg_stat_io includes only:

- data checksums launcher: relation/normal, wal/init, wal/normal
- data checksums worker: relation/normal, relation/vacuum, wal/init, wal/normal

The patch also excludes WAL reads for both processes, since they emit
WAL records but never read WAL.

Thoughts?

Regards,

[1] https://postgr.es/m/CAHGQGwFsBjQs2fv7b72hxzGV_fJMh6LAg4E83pNfDOu1jVgWCA@mail.gmail.com

-- 
Fujii Masao

--00000000000032c18a065639212f
Content-Type: application/octet-stream;
	name="v1-0001-Restrict-pg_stat_io-entries-for-data-checksum-pro.patch"
Content-Disposition: attachment;
	filename="v1-0001-Restrict-pg_stat_io-entries-for-data-checksum-pro.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mred2kcg0>
X-Attachment-Id: f_mred2kcg0

RnJvbSAxMDNhNTQ4ODJjNDAzMDQ5NThiNGEzNjBlMGFjMDdmNmI3MGI4ZmUxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5vcmc+CkRh
dGU6IEZyaSwgMTAgSnVsIDIwMjYgMTA6NTQ6NDYgKzA5MDAKU3ViamVjdDogW1BBVENIIHYxXSBS
ZXN0cmljdCBwZ19zdGF0X2lvIGVudHJpZXMgZm9yIGRhdGEgY2hlY2tzdW0gcHJvY2Vzc2VzCgpU
aGUgZGF0YSBjaGVja3N1bXMgbGF1bmNoZXIgYW5kIHdvcmtlcnMgd2VyZSBleHBvc2VkIGluIHBn
X3N0YXRfaW8Kd2l0aCB0aGUgc2FtZSBicm9hZCBzZXQgb2Ygb2JqZWN0L2NvbnRleHQgY29tYmlu
YXRpb25zIGFzIGdlbmVyYWwKYmFja2dyb3VuZCB3b3JrZXJzLiBIb3dldmVyLCBtYW55IG9mIHRo
b3NlIGVudHJpZXMgY2FuIG5ldmVyIGFjY3VtdWxhdGUKSS9PIHN0YXRpc3RpY3MgZm9yIHRoZXNl
IHByb2Nlc3Nlcywgc3VjaCBhcyBidWxrcmVhZCwgYnVsa3dyaXRlLApyZWxhdGlvbiBpbml0LCBh
bmQgdGVtcG9yYXJ5IHJlbGF0aW9uIGVudHJpZXMuCgpUZWFjaCBwZ3N0YXRfdHJhY2tzX2lvX29i
amVjdCgpIGFuZCBwZ3N0YXRfdHJhY2tzX2lvX29wKCkgYWJvdXQgdGhlCmFjdHVhbCBJL08gcGVy
Zm9ybWVkIGJ5IHRoZSBkYXRhIGNoZWNrc3VtIHByb2Nlc3Nlcy4gS2VlcCB0aGUgZW50cmllcwpu
ZWVkZWQgZm9yIGNhdGFsb2cgc2NhbnMsIHdvcmtlciByZWxhdGlvbiBwcm9jZXNzaW5nIHdpdGgg
YSB2YWN1dW0KYWNjZXNzIHN0cmF0ZWd5LCBhbmQgV0FMIHdyaXRlcyBhbmQgaW5pdGlhbGl6YXRp
b24sIHdoaWxlIGV4Y2x1ZGluZyBXQUwKcmVhZHMgYW5kIG90aGVyIG9iamVjdC9jb250ZXh0IGNv
bWJpbmF0aW9ucyB0aGF0IGNhbiBuZXZlciBiZSB1c2VkLgotLS0KIHNyYy9iYWNrZW5kL3V0aWxz
L2FjdGl2aXR5L3Bnc3RhdF9pby5jIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKysKIHNy
Yy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMub3V0ICAgIHwgMTEgKy0tLS0tLS0tCiAyIGZp
bGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp
dCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FjdGl2aXR5L3Bnc3RhdF9pby5jIGIvc3JjL2JhY2tlbmQv
dXRpbHMvYWN0aXZpdHkvcGdzdGF0X2lvLmMKaW5kZXggMzhiYWU3YjE1ZDIuLjRmODYyYzk2MWM1
IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hY3Rpdml0eS9wZ3N0YXRfaW8uYworKysg
Yi9zcmMvYmFja2VuZC91dGlscy9hY3Rpdml0eS9wZ3N0YXRfaW8uYwpAQCAtNDY0LDYgKzQ2NCwz
NSBAQCBwZ3N0YXRfdHJhY2tzX2lvX29iamVjdChCYWNrZW5kVHlwZSBia3R5cGUsIElPT2JqZWN0
IGlvX29iamVjdCwKIAkJaW9fY29udGV4dCA9PSBJT0NPTlRFWFRfQlVMS1dSSVRFKQogCQlyZXR1
cm4gZmFsc2U7CiAKKwkvKgorCSAqIFRoZSBkYXRhIGNoZWNrc3VtcyBsYXVuY2hlciBvbmx5IHNj
YW5zIGNhdGFsb2dzIGFuZCBlbWl0cyBXQUwgcmVjb3JkcworCSAqIGZvciBjaGVja3N1bSBzdGF0
ZSBjaGFuZ2VzLgorCSAqLworCWlmIChia3R5cGUgPT0gQl9EQVRBQ0hFQ0tTVU1TV09SS0VSX0xB
VU5DSEVSKQorCXsKKwkJaWYgKGlvX29iamVjdCA9PSBJT09CSkVDVF9XQUwgfHwKKwkJCShpb19v
YmplY3QgPT0gSU9PQkpFQ1RfUkVMQVRJT04gJiYKKwkJCSBpb19jb250ZXh0ID09IElPQ09OVEVY
VF9OT1JNQUwpKQorCQkJcmV0dXJuIHRydWU7CisKKwkJcmV0dXJuIGZhbHNlOworCX0KKworCS8q
CisJICogVGhlIHdvcmtlciBhbHNvIHNjYW5zIGNhdGFsb2dzLCB0aGVuIHByb2Nlc3NlcyByZWxh
dGlvbnMgdXNpbmcgYSB2YWN1dW0KKwkgKiBhY2Nlc3Mgc3RyYXRlZ3kuCisJICovCisJaWYgKGJr
dHlwZSA9PSBCX0RBVEFDSEVDS1NVTVNXT1JLRVJfV09SS0VSKQorCXsKKwkJaWYgKGlvX29iamVj
dCA9PSBJT09CSkVDVF9XQUwgfHwKKwkJCShpb19vYmplY3QgPT0gSU9PQkpFQ1RfUkVMQVRJT04g
JiYKKwkJCSAoaW9fY29udGV4dCA9PSBJT0NPTlRFWFRfTk9STUFMIHx8CisJCQkgIGlvX2NvbnRl
eHQgPT0gSU9DT05URVhUX1ZBQ1VVTSkpKQorCQkJcmV0dXJuIHRydWU7CisKKwkJcmV0dXJuIGZh
bHNlOworCX0KKwogCXJldHVybiB0cnVlOwogfQogCkBAIC01MDcsNiArNTM2LDggQEAgcGdzdGF0
X3RyYWNrc19pb19vcChCYWNrZW5kVHlwZSBia3R5cGUsIElPT2JqZWN0IGlvX29iamVjdCwKIAlp
ZiAoaW9fb2JqZWN0ID09IElPT0JKRUNUX1dBTCAmJiBpb19vcCA9PSBJT09QX1JFQUQgJiYKIAkJ
KGJrdHlwZSA9PSBCX1dBTF9SRUNFSVZFUiB8fCBia3R5cGUgPT0gQl9CR19XUklURVIgfHwKIAkJ
IGJrdHlwZSA9PSBCX0FVVE9WQUNfTEFVTkNIRVIgfHwgYmt0eXBlID09IEJfQVVUT1ZBQ19XT1JL
RVIgfHwKKwkJIGJrdHlwZSA9PSBCX0RBVEFDSEVDS1NVTVNXT1JLRVJfTEFVTkNIRVIgfHwKKwkJ
IGJrdHlwZSA9PSBCX0RBVEFDSEVDS1NVTVNXT1JLRVJfV09SS0VSIHx8CiAJCSBia3R5cGUgPT0g
Ql9XQUxfV1JJVEVSKSkKIAkJcmV0dXJuIGZhbHNlOwogCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9y
ZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3Rh
dHMub3V0CmluZGV4IDAzY2JjMWNkZWY1Li5jY2I3MTZjN2MxMCAxMDA2NDQKLS0tIGEvc3JjL3Rl
c3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBl
Y3RlZC9zdGF0cy5vdXQKQEAgLTUxLDIwICs1MSwxMSBAQCBjbGllbnQgYmFja2VuZHxyZWxhdGlv
bnx2YWN1dW0KIGNsaWVudCBiYWNrZW5kfHRlbXAgcmVsYXRpb258bm9ybWFsCiBjbGllbnQgYmFj
a2VuZHx3YWx8aW5pdAogY2xpZW50IGJhY2tlbmR8d2FsfG5vcm1hbAotZGF0YWNoZWNrc3VtcyBs
YXVuY2hlcnxyZWxhdGlvbnxidWxrcmVhZAotZGF0YWNoZWNrc3VtcyBsYXVuY2hlcnxyZWxhdGlv
bnxidWxrd3JpdGUKLWRhdGFjaGVja3N1bXMgbGF1bmNoZXJ8cmVsYXRpb258aW5pdAogZGF0YWNo
ZWNrc3VtcyBsYXVuY2hlcnxyZWxhdGlvbnxub3JtYWwKLWRhdGFjaGVja3N1bXMgbGF1bmNoZXJ8
cmVsYXRpb258dmFjdXVtCi1kYXRhY2hlY2tzdW1zIGxhdW5jaGVyfHRlbXAgcmVsYXRpb258bm9y
bWFsCiBkYXRhY2hlY2tzdW1zIGxhdW5jaGVyfHdhbHxpbml0CiBkYXRhY2hlY2tzdW1zIGxhdW5j
aGVyfHdhbHxub3JtYWwKLWRhdGFjaGVja3N1bXMgd29ya2VyfHJlbGF0aW9ufGJ1bGtyZWFkCi1k
YXRhY2hlY2tzdW1zIHdvcmtlcnxyZWxhdGlvbnxidWxrd3JpdGUKLWRhdGFjaGVja3N1bXMgd29y
a2VyfHJlbGF0aW9ufGluaXQKIGRhdGFjaGVja3N1bXMgd29ya2VyfHJlbGF0aW9ufG5vcm1hbAog
ZGF0YWNoZWNrc3VtcyB3b3JrZXJ8cmVsYXRpb258dmFjdXVtCi1kYXRhY2hlY2tzdW1zIHdvcmtl
cnx0ZW1wIHJlbGF0aW9ufG5vcm1hbAogZGF0YWNoZWNrc3VtcyB3b3JrZXJ8d2FsfGluaXQKIGRh
dGFjaGVja3N1bXMgd29ya2VyfHdhbHxub3JtYWwKIGlvIHdvcmtlcnxyZWxhdGlvbnxidWxrcmVh
ZApAQCAtMTExLDcgKzEwMiw3IEBAIHdhbHN1bW1hcml6ZXJ8d2FsfGluaXQKIHdhbHN1bW1hcml6
ZXJ8d2FsfG5vcm1hbAogd2Fsd3JpdGVyfHdhbHxpbml0CiB3YWx3cml0ZXJ8d2FsfG5vcm1hbAot
KDk1IHJvd3MpCisoODYgcm93cykKIFxhCiAtLSBMaXN0IG9mIHJlZ2lzdGVyZWQgc3RhdGlzdGlj
cyBraW5kcy4KIFNFTEVDVCBpZCwgbmFtZSwgZml4ZWRfYW1vdW50LAotLSAKMi41NS4wCgo=
--00000000000032c18a065639212f--