MIME-Version: 1.0
References: <4D2047B0-E8D8-472B-B7E8-61206B1E6AFA@yandex-team.ru>
 <F694DABC-6A42-4614-B254-643180B9D6F6@pgguru.net>
 <CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com>
 <CACJufxEThXCX1QWyNE1gw--uJ4JQJ8f16MFH-kN+Ym3_02azTA@mail.gmail.com>
In-Reply-To: 
 <CACJufxEThXCX1QWyNE1gw--uJ4JQJ8f16MFH-kN+Ym3_02azTA@mail.gmail.com>
From: David Christensen <david@pgguru.net>
Date: Fri, 26 Sep 2025 11:56:49 -0500
Message-ID: 
 <CAHM0NXg=yGzhn=H0_HiZ9u=Xq-40g1f+Bb=2e2LDxgd6a11bWw@mail.gmail.com>
Subject: Re: [PATCH] GROUP BY ALL
To: jian he <jian.universality@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
 Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHM0NXg%3DyGzhn%3DH0_HiZ9u%3DXq-40g1f%2BBb%3D2e2LDxgd6a11bWw%40mail.gmail.com>
Precedence: bulk

On Fri, Sep 26, 2025 at 11:38=E2=80=AFAM jian he <jian.universality@gmail.c=
om> wrote:
>
> On Fri, Sep 26, 2025 at 11:46=E2=80=AFPM David Christensen <david@pgguru.=
net> wrote:
> >
> > >
> > > I=E2=80=99m interested in picking it up again but would appreciate th=
e review.
> >
> > Here is a rebased version with a few more tests.  I also changed the
> > main check here to using `!contain_agg_clause` instead of
> > `!IsA(Aggref))` directly.  (This was defined in `optimizer/clauses.h`,
> > but we already are pulling in `optimizer.h`, so it felt valid to me.)
> >
>
> hi.
> I only briefly browse the patch text file, so forgive me.
> seems missing deparse regress tests
>
> i think you may need one test like:
>
> create view v1 as SELECT b, COUNT(*) FROM t1 GROUP BY ALL;
> \sv v1

Thanks, good suggestion; not sure the appropriate final location for
this, but it did show a bug in the current patch.

David