MIME-Version: 1.0
References: <4D2047B0-E8D8-472B-B7E8-61206B1E6AFA@yandex-team.ru>
 <F694DABC-6A42-4614-B254-643180B9D6F6@pgguru.net>
 <CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com>
 <4083063.1758902694@sss.pgh.pa.us>
 <CAHM0NXgPhe_OF81MyA9ocWZ=b+oEAHtQHoDXw4DverPdbkXzpg@mail.gmail.com>
 <4085064.1758903815@sss.pgh.pa.us>
 <cf397a8c-49cf-4839-9a3f-992ea49feb12@eisentraut.org>
 <167505.1758988990@sss.pgh.pa.us> <702762.1759011796@sss.pgh.pa.us>
In-Reply-To: <702762.1759011796@sss.pgh.pa.us>
From: David Christensen <david@pgguru.net>
Date: Sun, 28 Sep 2025 14:18:48 -0500
Message-ID: 
 <CAHM0NXgP6-a75XgAR-WdKfzvDRcUv3=CipR+Zt2qmZ0T8bcABg@mail.gmail.com>
Subject: Re: [PATCH] GROUP BY ALL
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Andrey Borodin <x4mmm@yandex-team.ru>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHM0NXgP6-a75XgAR-WdKfzvDRcUv3%3DCipR%2BZt2qmZ0T8bcABg%40mail.gmail.com>
Precedence: bulk

On Sat, Sep 27, 2025 at 5:23=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Here's a v6 that's rebased up to HEAD and contains fixes for the
> semantic issues we discussed.  It still lacks documentation, but
> otherwise I think it's about ready to go.

Here is v7 with a stab at docs; fairly minimal at this point, but
touching the two areas that are likely to need adjusting.  When
adjusting the docs for sql-select, I noticed that the grammar also
supports `GROUP BY ALL <grouping_elements>`, so I also added a test to
ensure that this syntax is explicitly supported. (It seems like it
works as-is without further grammar adjustments, but I was a little
worried when I first saw that fact... :D)  Not sure that
aggregates.sql is still the right place for all of these bits, but it
does seem like having all things `GROUP BY ALL`-related tested in the
same place is a nice property, so leaving there for now.

David