MIME-Version: 1.0
References: <CAKAnmmJz8Hh=8Ru8jgzySPWmLBhnv4=oc_0KRiz-UORJ0Dex+w@mail.gmail.com>
 <CAHM0NXiD15-23=r1B9rHzKhS8e0+zwp_a6PncdLNetyF0xpNpA@mail.gmail.com>
 <c180a366-fecc-4f3a-9c40-79eec526f70c@uni-muenster.de> <CAHM0NXheC3YO=ANPX0fCZKcQxMVBdgDzk9fc=-4TTCUN0aLYWA@mail.gmail.com>
 <8c9b9b7d-0868-46d4-963c-8b1906bd7a1b@eisentraut.org> <CAKAnmmL6-U+QPsuWM0r8mNq0Lo80d8L=cR7JLk7pypXJfwt=EA@mail.gmail.com>
 <CAHM0NXjO-Thdj+DqT5SOfLGVP-aVKhguiRfmkLDu4BJ_H-gg0A@mail.gmail.com>
 <CAKAnmmJq-13e74uSwDSnx0isA+9N0ByV+cscV4knpWo_mpM1FQ@mail.gmail.com>
 <CAHM0NXi5G9RwtH_MRQkh2jcZMvn8Uubm9pMn=KW-AuwYcNk51w@mail.gmail.com>
 <72f6995a-75a6-4579-9e93-45a80f6bd956@eisentraut.org> <CAHM0NXi19okhdByr6cNDwqHtjG7umjbY5OmRMwgropZHs01KGw@mail.gmail.com>
 <CAHM0NXhzU4oZJ00VUvbDL9gLoW2xUTLKZphoRCL3QWLGh5GE7A@mail.gmail.com> <2597072.1737232674@sss.pgh.pa.us>
In-Reply-To: <2597072.1737232674@sss.pgh.pa.us>
From: David Christensen <david+pg@pgguru.net>
Date: Thu, 30 Jan 2025 14:55:00 -0600
Message-ID: <CAHM0NXgs4-k3cSg2J0rJd2CPiT40ZfYGs4SK6MAHi-HB3B7dUA@mail.gmail.com>
Subject: Re: Adding comments to help understand psql hidden queries
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, Greg Sabino Mullane <htamfids@gmail.com>, 
	Jim Jones <jim.jones@uni-muenster.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHM0NXgs4-k3cSg2J0rJd2CPiT40ZfYGs4SK6MAHi-HB3B7dUA%40mail.gmail.com>
Precedence: bulk

On Sat, Jan 18, 2025 at 2:37=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Christensen <david+pg@pgguru.net> writes:
> > Any further concerns/issues with this patch that I can address to help
> > move it forward?
>
> I got around to looking at this finally --- sorry that it's been on
> the back burner for so long.  I think this is basically a good idea
> but it still requires a lot of sanding-down of rough edges.

Hi Tom, thanks for the detailed feedback.  I'll take your v6 and see
about adding the additional changes; I agree with what you've pointed
out at the high level, and will respond with additional questions of
my own if things seem ambiguous in terms of approach.

Thanks,

David