MIME-Version: 1.0
References: <CAKAnmmJz8Hh=8Ru8jgzySPWmLBhnv4=oc_0KRiz-UORJ0Dex+w@mail.gmail.com>
 <CAHM0NXiD15-23=r1B9rHzKhS8e0+zwp_a6PncdLNetyF0xpNpA@mail.gmail.com>
 <c180a366-fecc-4f3a-9c40-79eec526f70c@uni-muenster.de> <CAHM0NXheC3YO=ANPX0fCZKcQxMVBdgDzk9fc=-4TTCUN0aLYWA@mail.gmail.com>
 <8c9b9b7d-0868-46d4-963c-8b1906bd7a1b@eisentraut.org> <CAKAnmmL6-U+QPsuWM0r8mNq0Lo80d8L=cR7JLk7pypXJfwt=EA@mail.gmail.com>
 <CAHM0NXjO-Thdj+DqT5SOfLGVP-aVKhguiRfmkLDu4BJ_H-gg0A@mail.gmail.com>
 <CAKAnmmJq-13e74uSwDSnx0isA+9N0ByV+cscV4knpWo_mpM1FQ@mail.gmail.com>
 <CAHM0NXi5G9RwtH_MRQkh2jcZMvn8Uubm9pMn=KW-AuwYcNk51w@mail.gmail.com>
 <72f6995a-75a6-4579-9e93-45a80f6bd956@eisentraut.org> <CAHM0NXi19okhdByr6cNDwqHtjG7umjbY5OmRMwgropZHs01KGw@mail.gmail.com>
In-Reply-To: <CAHM0NXi19okhdByr6cNDwqHtjG7umjbY5OmRMwgropZHs01KGw@mail.gmail.com>
From: David Christensen <david+pg@pgguru.net>
Date: Tue, 11 Jun 2024 17:54:34 -0500
Message-ID: <CAHM0NXhzU4oZJ00VUvbDL9gLoW2xUTLKZphoRCL3QWLGh5GE7A@mail.gmail.com>
Subject: Re: Adding comments to help understand psql hidden queries
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Greg Sabino Mullane <htamfids@gmail.com>, Jim Jones <jim.jones@uni-muenster.de>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAHM0NXhzU4oZJ00VUvbDL9gLoW2xUTLKZphoRCL3QWLGh5GE7A%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 4, 2024 at 11:12=E2=80=AFAM David Christensen <david+pg@pgguru.=
net> wrote:
>
> On Thu, Apr 4, 2024 at 9:32=E2=80=AFAM Peter Eisentraut <peter@eisentraut=
.org> wrote:
> >
> > On 03.04.24 19:16, David Christensen wrote:
> > > I removed _() in the output of the query/stars since there'd be no
> > > sensible existing translations for the constructed string, which
> > > included the query string itself.  If we need it for the "QUERY"
> > > string, this could be added fairly easily, but the existing piece
> > > would have been nonsensical and never used in practice.
> >
> > "QUERY" is currently translated.  Your patch loses that.
>
> I see; enclosed is v5 which fixes this.
>
> The effective diff from the last one is:
>
> -    char *label =3D "QUERY";
> +    char *label =3D _("QUERY");
>
> and
>
> -        label =3D psprintf("QUERY (\\%s)", curcmd);
> +        label =3D psprintf(_("QUERY (\\%s)"), curcmd);

Any further concerns/issues with this patch that I can address to help
move it forward?

David