MIME-Version: 1.0
References: <4D2047B0-E8D8-472B-B7E8-61206B1E6AFA@yandex-team.ru>
 <F694DABC-6A42-4614-B254-643180B9D6F6@pgguru.net>
 <CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com>
 <4083063.1758902694@sss.pgh.pa.us>
 <CAHM0NXgPhe_OF81MyA9ocWZ=b+oEAHtQHoDXw4DverPdbkXzpg@mail.gmail.com>
In-Reply-To: 
 <CAHM0NXgPhe_OF81MyA9ocWZ=b+oEAHtQHoDXw4DverPdbkXzpg@mail.gmail.com>
From: David Christensen <david@pgguru.net>
Date: Fri, 26 Sep 2025 11:17:29 -0500
Message-ID: 
 <CAHM0NXiL+KDNygg5xed-cuQmMQvwwtUoZ8YQstL0Tt7kEZ9g3w@mail.gmail.com>
Subject: Re: [PATCH] GROUP BY ALL
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
 Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHM0NXiL%2BKDNygg5xed-cuQmMQvwwtUoZ8YQstL0Tt7kEZ9g3w%40mail.gmail.com>
Precedence: bulk

On Fri, Sep 26, 2025 at 11:13=E2=80=AFAM David Christensen <david@pgguru.ne=
t> wrote:
>
> On Fri, Sep 26, 2025 at 11:05=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wro=
te:
> >
> > David Christensen <david@pgguru.net> writes:
> > > Here is a rebased version with a few more tests.  I also changed the
> > > main check here to using `!contain_agg_clause` instead of
> > > `!IsA(Aggref))` directly.  (This was defined in `optimizer/clauses.h`=
,
> > > but we already are pulling in `optimizer.h`, so it felt valid to me.)
> >
> > contain_agg_clause will blow up on a SubLink, so I doubt this is
> > gonna be robust.
>
> Fair enough, see that Assert now; easy enough to make a new
> expression_tree_walker that only looks for Aggref and short-circuits
> SubLink (which I assume is the right behavior here, but might have to
> add some more tests/play around with subqueries in the GROUP BY ALL
> part).

Or contain_aggs_of_level(), assuming I can suss out how to get the
current level... :D  Anyway, will mess with this for a bit.

David