public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Christensen <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Subject: Re: [PATCH] GROUP BY ALL
Date: Fri, 26 Sep 2025 10:52:36 -0500
Message-ID: <CAHM0NXib3ZpAkPypXS6coGrydWadp8NXHvSinOcGF+uOHJs+hQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHM0NXjz0kDwtzoe-fnHAqPB1qA8_VJN0XAmCgUZ+iPnvP5LbA@mail.gmail.com>
	<CAKFQuwY0vhNG8T+pC3BQJurFi3NN_L1KbEPGagRN3V5nKZcpDQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAGECzQSGKWy1tcB8BB=p2suOvW0KLtLR+pm=XTagfp9WSA4HXQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Fri, Sep 26, 2025 at 9:12 AM Tom Lane <[email protected]> wrote:
>
> Peter Eisentraut <[email protected]> writes:
> > The initially proposed patch appears to have the right idea overall.
> > But it does not handle more complex cases like
> >      SELECT a, SUM(b)+a FROM t1 GROUP BY ALL;
>
> > (For explanation:  GROUP BY ALL expands to all select list entries that
> > do not contain aggregates.  So the above would expand to
> >      SELECT a, SUM(b)+a FROM t1 GROUP BY a;
> > which should then be rejected based on the existing rules.)
>
> I thought I understood this definition, up till your last
> comment.  What's invalid about that expanded query?
>
> regression=# create table t1 (a int, b int);
> CREATE TABLE
> regression=# SELECT a, SUM(b)+a FROM t1 GROUP BY a;
>  a | ?column?
> ---+----------
> (0 rows)

Agreed that this shouldn't be an error; added a similar test case to
v2 of this patch.

David

view thread (49+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] GROUP BY ALL
  In-Reply-To: <CAHM0NXib3ZpAkPypXS6coGrydWadp8NXHvSinOcGF+uOHJs+hQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox