MIME-Version: 1.0
References: <CAMbWs48jzLrPt1J_00ZcPZXWUQKawQOFE8ROc-ADiYqsqrpBNw@mail.gmail.com>
 <87il22cj51.fsf@163.com> <CAMbWs49=eAd2W9jCtGhaZPPp+SOC_2rg16RTG74xAht=hkr5JQ@mail.gmail.com>
 <CAMbWs49Nc4M3H+eCf1+8w8piDyEECjRb-gK_JMF4VvcyWwGEVQ@mail.gmail.com>
 <CAMbWs49E_dR0nobsExsyetpnBpHObLTsQLsEbWKQLkh0omPxNg@mail.gmail.com>
 <CAMbWs49B_qUiHvu2EqLHZRpLr3p_+QPBs50n2=L5ibYzniwTzA@mail.gmail.com>
 <CAMbWs48KCQtDymnYi4M=Vz+WMzo3fkBxffJsyk6VX6hOXXv+VA@mail.gmail.com>
 <CAMbWs49sv_MuOYqqrtmBN_oYf8VSQ2BXDwXaTpJTn_YfwyYdWQ@mail.gmail.com>
 <CAMbWs49U8Sddx_fGszPdvA3jp_nheynxaqm5Y4NqMV21VBYAuQ@mail.gmail.com>
 <CAMbWs4-LwyOg9ga+NVF7yQbMi0ZsZdN1G_sO2v=YJHV18=19+A@mail.gmail.com>
 <CALA8mJquG_zCJXfVwash5LKqHGtZXQmq7RfTSaRDUzGYeW=7Rw@mail.gmail.com>
 <CAMbWs4_EjgcBib5+y1LYcGB3EK3Y6R+OOxGKfJo42fDovadk1g@mail.gmail.com>
 <CALA8mJqe0anNM8_V6cOeOQnCHUTQggn7iOQNyQr1VaN_xMjz+w@mail.gmail.com>
 <CAMbWs48eE-s-jCicC8pSVfXk8Ws-ZvUKnsw8qH-DkVBdYv0eJQ@mail.gmail.com>
 <CAMbWs483a7-8M0pDttG44r-+8Gevn9VG0xNceE3WpkEQxJXPZw@mail.gmail.com>
 <CAHewXNmYM6DvR_kaxDL0w0fz9BwKbac+TSU3QS10aA3cXHyMmA@mail.gmail.com>
 <CA+TgmoaxH=P63hLYgyJJcEbMRnw3xi16d=HxFi1j-m7MhH6W_w@mail.gmail.com> <CAMbWs4-Q-CHadH1ub_oAv3sJ_NHt0GUO4nce3LBhpPmp1v6Z_Q@mail.gmail.com>
In-Reply-To: <CAMbWs4-Q-CHadH1ub_oAv3sJ_NHt0GUO4nce3LBhpPmp1v6Z_Q@mail.gmail.com>
From: Tender Wang <tndrwang@gmail.com>
Date: Thu, 29 Aug 2024 11:38:11 +0800
Message-ID: <CAHewXNk7VWJCvn817tHR0DjyX36+UgdtMdYrC7R7onvqRoD_GA@mail.gmail.com>
Subject: Re: Eager aggregation, take 3
To: Richard Guo <guofenglinux@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Paul George <p.a.george19@gmail.com>, 
	Andy Fan <zhihuifan1213@163.com>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000db483d0620ca3497"
Archived-At: <https://www.postgresql.org/message-id/CAHewXNk7VWJCvn817tHR0DjyX36%2BUgdtMdYrC7R7onvqRoD_GA%40mail.gmail.com>
Precedence: bulk

--000000000000db483d0620ca3497
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Richard Guo <guofenglinux@gmail.com> =E4=BA=8E2024=E5=B9=B48=E6=9C=8829=E6=
=97=A5=E5=91=A8=E5=9B=9B 10:46=E5=86=99=E9=81=93=EF=BC=9A

> On Wed, Aug 28, 2024 at 9:01=E2=80=AFPM Robert Haas <robertmhaas@gmail.co=
m> wrote:
> > On Tue, Aug 27, 2024 at 11:57=E2=80=AFPM Tender Wang <tndrwang@gmail.co=
m> wrote:
> > > I haven't look all of them. I just pick few simple plan test(e.g.
> 19.sql, 45.sql).
> > > For example, 19.sql, eager agg pushdown doesn't get large gain, but a
> little
> > > performance regress.
> >
> > Yeah, this is one of the things I was worried about in my previous
> > reply to Richard. It would be worth Richard, or someone, probing into
> > exactly why that's happening. My fear is that we just don't have good
> > enough estimates to make good decisions, but there might well be
> > another explanation.
>
> It's great that we have a query to probe into.  Your guess is likely
> correct: it may be caused by poor estimates.
>
> Tender, would you please help provide the outputs of
>
> EXPLAIN (COSTS ON, ANALYZE)
>
> on 19.sql with and without eager aggregation?
>
> I upload EXPLAIN(COSTS ON, ANALYZE) test to [1].
I ran the same query three times, and I chose the third time result.
You can check 19_off_explain.out and 19_on_explain.out.


[1] https://github.com/tenderwg/eager_agg


--=20
Tender Wang

--000000000000db483d0620ca3497
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">Richard Guo &lt;<a href=3D"mailto:guo=
fenglinux@gmail.com">guofenglinux@gmail.com</a>&gt; =E4=BA=8E2024=E5=B9=B48=
=E6=9C=8829=E6=97=A5=E5=91=A8=E5=9B=9B 10:46=E5=86=99=E9=81=93=EF=BC=9A<br>=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Aug 28, 202=
4 at 9:01=E2=80=AFPM Robert Haas &lt;<a href=3D"mailto:robertmhaas@gmail.co=
m" target=3D"_blank">robertmhaas@gmail.com</a>&gt; wrote:<br>
&gt; On Tue, Aug 27, 2024 at 11:57=E2=80=AFPM Tender Wang &lt;<a href=3D"ma=
ilto:tndrwang@gmail.com" target=3D"_blank">tndrwang@gmail.com</a>&gt; wrote=
:<br>
&gt; &gt; I haven&#39;t look all of them. I just pick few simple plan test(=
e.g. 19.sql, 45.sql).<br>
&gt; &gt; For example, 19.sql, eager agg pushdown doesn&#39;t get large gai=
n, but a little<br>
&gt; &gt; performance regress.<br>
&gt;<br>
&gt; Yeah, this is one of the things I was worried about in my previous<br>
&gt; reply to Richard. It would be worth Richard, or someone, probing into<=
br>
&gt; exactly why that&#39;s happening. My fear is that we just don&#39;t ha=
ve good<br>
&gt; enough estimates to make good decisions, but there might well be<br>
&gt; another explanation.<br>
<br>
It&#39;s great that we have a query to probe into.=C2=A0 Your guess is like=
ly<br>
correct: it may be caused by poor estimates.<br>
<br>
Tender, would you please help provide the outputs of<br>
<br>
EXPLAIN (COSTS ON, ANALYZE)<br>
<br>
on 19.sql with and without eager aggregation?<br><br></blockquote><div>I up=
load EXPLAIN(COSTS ON, ANALYZE) test to [1].</div><div>I ran the same query=
 three times, and I chose the third time result.</div><div>You can check 19=
_off_explain.out and 19_on_explain.out.</div><div><br></div><div><br></div>=
<div>[1]=C2=A0<a href=3D"https://github.com/tenderwg/eager_agg">https://git=
hub.com/tenderwg/eager_agg</a>=C2=A0</div></div><br clear=3D"all"><div><br>=
</div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div>Tender Wang</div></div></d=
iv></div>

--000000000000db483d0620ca3497--