MIME-Version: 1.0
References: <CAHewXNno_HKiQ6PqyLYfuqDtwp7KKHZiH1J7Pqyz0nr+PS2Dwg@mail.gmail.com>
 <CAHewXN=sGCF7cp3r+8PyZXP0TT+Q1imoEe-7Z-0Sxxb76eWAXg@mail.gmail.com>
 <CA+HiwqFmtOjVX0Gy2HCMGDRJg3zKNmhdt=o=K=pTvE2VhEe-1A@mail.gmail.com>
 <CAHewXNk1K2G56C7kXvuYzQexeQs2EuHA3x-7v68ihn843svEZQ@mail.gmail.com>
 <CACJufxFefXhnD+Z3swU9A0SCK3AfmEbTSx7hj=TCu-0hr2OOgA@mail.gmail.com>
 <CAHewXNnoTXxsAuJKxEjs-TASjG_-soH9Y_+tup8a5teggS4caw@mail.gmail.com>
 <CACJufxF1bmHSc+L7Hg7QxnH9UDbyP+qMsK8Z2ZBU8kux6C=t3A@mail.gmail.com>
 <CAEG8a3Ks7_5b+0bnqbSceAbofj=o1RmP4qedv1Jr43Nz1wY-vA@mail.gmail.com> <CA+HiwqEHx++qTjCGmWyYZDiPR=_fLGPjR7RcFEVnSNZVc-Qj2g@mail.gmail.com>
In-Reply-To: <CA+HiwqEHx++qTjCGmWyYZDiPR=_fLGPjR7RcFEVnSNZVc-Qj2g@mail.gmail.com>
From: Tender Wang <tndrwang@gmail.com>
Date: Fri, 1 Nov 2024 10:59:21 +0800
Message-ID: <CAHewXNk=FAwF5P1BX+3sEWH4vr_JLmXG-pJV8Q0n=ZXHaDtTAQ@mail.gmail.com>
Subject: Re: Wrong result when enable_partitionwise_join is on if collation of
 PartitionKey and Column is different.
To: Amit Langote <amitlangote09@gmail.com>
Cc: Junwang Zhao <zhjwpku@gmail.com>, jian he <jian.universality@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000d3a1200625d11f07"
Archived-At: <https://www.postgresql.org/message-id/CAHewXNk%3DFAwF5P1BX%2B3sEWH4vr_JLmXG-pJV8Q0n%3DZXHaDtTAQ%40mail.gmail.com>
Precedence: bulk

--000000000000d3a1200625d11f07
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Amit Langote <amitlangote09@gmail.com> =E4=BA=8E2024=E5=B9=B410=E6=9C=8831=
=E6=97=A5=E5=91=A8=E5=9B=9B 21:09=E5=86=99=E9=81=93=EF=BC=9A

>
> 0001 is the patch for the partitionwise grouping issue (bug #18568).
> I concluded that even partial aggregate should be disallowed when the
> grouping collation doesn't match partitioning collation. The result
> with partial partitionwise grouping is not the same as when
> enable_partitionwise_aggregate is off.
>

LGTM


--=20
Thanks,
Tender Wang

--000000000000d3a1200625d11f07
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">Amit Langote &lt;<a href=3D"mailto:am=
itlangote09@gmail.com">amitlangote09@gmail.com</a>&gt; =E4=BA=8E2024=E5=B9=
=B410=E6=9C=8831=E6=97=A5=E5=91=A8=E5=9B=9B 21:09=E5=86=99=E9=81=93=EF=BC=
=9A<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
0001 is the patch for the partitionwise grouping issue (bug #18568).<br>
I concluded that even partial aggregate should be disallowed when the<br>
grouping collation doesn&#39;t match partitioning collation. The result<br>
with partial partitionwise grouping is not the same as when<br>
enable_partitionwise_aggregate is off.<br></blockquote><div><br></div><div>=
LGTM=C2=A0</div></div><br clear=3D"all"><div><br></div><span class=3D"gmail=
_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"=
><div dir=3D"ltr"><div>Thanks,</div><div>Tender Wang</div></div></div></div=
>

--000000000000d3a1200625d11f07--