public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tender Wang <[email protected]>
To: Richard Guo <[email protected]>
Cc: Paul George <[email protected]>
Cc: Andy Fan <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: [email protected]
Subject: Re: Eager aggregation, take 3
Date: Fri, 13 Sep 2024 15:48:20 +0800
Message-ID: <CAHewXNkUbvxiv+LVR1yDJf5zYD-MuMz2dEJfHSQYXW4u1E2zQw@mail.gmail.com> (raw)
In-Reply-To: <CAHewXNmwdmf2DDYVfqySYKQ7DnxyUUDnaaUa6+bdfF-oUAh_Vg@mail.gmail.com>
References: <CAMbWs48jzLrPt1J_00ZcPZXWUQKawQOFE8ROc-ADiYqsqrpBNw@mail.gmail.com>
<[email protected]>
<CAMbWs49=eAd2W9jCtGhaZPPp+SOC_2rg16RTG74xAht=hkr5JQ@mail.gmail.com>
<CAMbWs49Nc4M3H+eCf1+8w8piDyEECjRb-gK_JMF4VvcyWwGEVQ@mail.gmail.com>
<CAMbWs49E_dR0nobsExsyetpnBpHObLTsQLsEbWKQLkh0omPxNg@mail.gmail.com>
<CAMbWs49B_qUiHvu2EqLHZRpLr3p_+QPBs50n2=L5ibYzniwTzA@mail.gmail.com>
<CAMbWs48KCQtDymnYi4M=Vz+WMzo3fkBxffJsyk6VX6hOXXv+VA@mail.gmail.com>
<CAMbWs49sv_MuOYqqrtmBN_oYf8VSQ2BXDwXaTpJTn_YfwyYdWQ@mail.gmail.com>
<CAMbWs49U8Sddx_fGszPdvA3jp_nheynxaqm5Y4NqMV21VBYAuQ@mail.gmail.com>
<CAMbWs4-LwyOg9ga+NVF7yQbMi0ZsZdN1G_sO2v=YJHV18=19+A@mail.gmail.com>
<CALA8mJquG_zCJXfVwash5LKqHGtZXQmq7RfTSaRDUzGYeW=7Rw@mail.gmail.com>
<CAMbWs4_EjgcBib5+y1LYcGB3EK3Y6R+OOxGKfJo42fDovadk1g@mail.gmail.com>
<CALA8mJqe0anNM8_V6cOeOQnCHUTQggn7iOQNyQr1VaN_xMjz+w@mail.gmail.com>
<CAMbWs48eE-s-jCicC8pSVfXk8Ws-ZvUKnsw8qH-DkVBdYv0eJQ@mail.gmail.com>
<CAMbWs483a7-8M0pDttG44r-+8Gevn9VG0xNceE3WpkEQxJXPZw@mail.gmail.com>
<CAHewXNmwdmf2DDYVfqySYKQ7DnxyUUDnaaUa6+bdfF-oUAh_Vg@mail.gmail.com>
Tender Wang <[email protected]> 于2024年9月4日周三 11:48写道：
>
>
> Richard Guo <[email protected]> 于2024年8月21日周三 15:11写道：
>
>> On Fri, Aug 16, 2024 at 4:14 PM Richard Guo <[email protected]>
>> wrote:
>> > I had a self-review of this patchset and made some refactoring,
>> > especially to the function that creates the RelAggInfo structure for a
>> > given relation. While there were no major changes, the code should
>> > now be simpler.
>>
>> I found a bug in v10 patchset: when we generate the GROUP BY clauses
>> for the partial aggregation that is pushed down to a non-aggregated
>> relation, we may produce a clause with a tleSortGroupRef that
>> duplicates one already present in the query's groupClause, which would
>> cause problems.
>>
>> Attached is the updated version of the patchset that fixes this bug
>> and includes further code refactoring.
>>
>
> The v11-0002 git am failed on HEAD(6c2b5edecc).
>
> tender@iZ2ze6la2dizi7df9q3xheZ:/workspace/postgres$ git am
> v11-0002-Implement-Eager-Aggregation.patch
> Applying: Implement Eager Aggregation
> error: patch failed: src/test/regress/parallel_schedule:119
> error: src/test/regress/parallel_schedule: patch does not apply
> Patch failed at 0001 Implement Eager Aggregation
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
>
Since MERGE/SPLIT partition has been reverted, the tests *partition_merge*
and *partition_split* should be removed
from parallel_schedule. After doing the above, the 0002 patch can be
applied.
--
Thanks,
Tender Wang
view thread (30+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Eager aggregation, take 3
In-Reply-To: <CAHewXNkUbvxiv+LVR1yDJf5zYD-MuMz2dEJfHSQYXW4u1E2zQw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox