MIME-Version: 1.0
References: 
 <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <CAPpHfdsh_jPZ6-2JtWoFeZravVQYY4cYCcnKXQW6KxEx+F5vxg@mail.gmail.com>
 <2643645f-2a02-43de-9321-c995ab1b7ef8@postgrespro.ru>
 <CACJufxF1Hfx1PST7pCLrKkGcjHEn2A51znXmYwVccnt5GDORcw@mail.gmail.com>
 <57a94d8a-d7b6-4c5e-9001-be1cd403b172@postgrespro.ru>
 <54414932-9E82-47AA-902B-2DED18F07F64@gmail.com>
 <e7da0ceb-8a01-4856-8c87-f87f09b4a9ad@postgrespro.ru>
 <CACJufxET9Qe-=zJtjGrKPr7-1QbVcP9y-vJU9CMEDfPGt_dbyg@mail.gmail.com>
 <3280c458-a886-4c58-8e2b-4d220b73161d@postgrespro.ru>
 <CACJufxEBvrtcOWyX2NMwOCvb2ZvaRGaGeiMQpUD=yxL6ncBFOg@mail.gmail.com>
 <dbe8e3ac-0b85-4809-bfaf-1d11f3c9d814@postgrespro.ru>
 <CAPpHfdvSBR+sbsRCAybN949tOGArQvMH2QeDXf2L=7NDMNbJfw@mail.gmail.com>
 <b96a16a5-02de-4cc2-afb4-fbccba43eb54@postgrespro.ru>
 <CAPpHfduQwwa4ytK-dGjRGN0fTWfpWNNysYuUKrOetsyGioBMfA@mail.gmail.com>
 <09414bf8-9326-431c-9422-b13bddf5f554@postgrespro.ru>
 <CAPpHfdvpzezTnuumpdJYge=x1TbhgAkjMGh2GHnScf5SFsf2ew@mail.gmail.com>
 <29ff27f5-d359-4479-b11c-ce28e525d806@postgrespro.ru>
 <CAPpHfdtBH5YhAiKhXPcLAE4CCRMaGKqupzx8u2RKEm2aQ_e3Xw@mail.gmail.com>
 <CA+gpmfLSELzEKEzSFXeLkRRMGkRfm2+7ewXHyW-8ZWPbWOywyg@mail.gmail.com>
 <CAPpHfdtnWkesztu4qq1m8RfuR2OYXd5tbPyaHk-3Db2szWrb=Q@mail.gmail.com>
 <CAPpHfdta0DMb3XjePJJWf1xbAndE8w2uYPaWEOFBGQ=xsDkfiQ@mail.gmail.com>
 <tencent_3661BB522D5466B33EA33666@qq.com>
 <CAPpHfdvt64X0F3thjC0q9vOTU-JqG2M_MJfEeA2-_=odNOA3Dg@mail.gmail.com>
 <tencent_6DB357447E187E6516DFD9C1@qq.com>
 <CAPpHfdu8wPv6hes7v95fF__N1pkPG1yS3YumKUGmS_jdF2RtrA@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdu8wPv6hes7v95fF__N1pkPG1yS3YumKUGmS_jdF2RtrA@mail.gmail.com>
From: Tender Wang <tndrwang@gmail.com>
Date: Sat, 20 Dec 2025 11:18:16 +0800
Message-ID: 
 <CAHewXNmBM+5qbrJMu60NxPn+0y-=2wXM-QVVs3xRp8NxFvDb9A@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000d86508064659a5af"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHewXNmBM%2B5qbrJMu60NxPn%2B0y-%3D2wXM-QVVs3xRp8NxFvDb9A%40mail.gmail.com>
Precedence: bulk

--000000000000d86508064659a5af
Content-Type: multipart/alternative; boundary="000000000000d86507064659a5ad"

--000000000000d86507064659a5ad
Content-Type: text/plain; charset="UTF-8"

 Hi Alexander,

I found this feature merged; thanks for this work.
I tested it and found that one place in the error errcode may need to be
changed.
In checkPartition():
...
if (get_partition_parent(partRelOid, false) != RelationGetRelid(rel))
    ereport(ERROR,
    errcode(ERRCODE_UNDEFINED_TABLE),
    errmsg("relation \"%s\" is not a partition of relation \"%s\"",
...

ERRCODE_UNDEFINED_TABLE usually means "table does not exist."
When entering here, the table should exist, otherwise table_open() already
reports an error.
I found another two errcode in checkPartition()
use ERRCODE_WRONG_OBJECT_TYPE,
In the attached patch, I replace ERRCODE_UNDEFINED_TABLE with
ERRCODE_WRONG_OBJECT_TYPE.

-- 
Thanks,
Tender Wang

--000000000000d86507064659a5ad
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div>=C2=
=A0Hi Alexander,</div><div><br></div><div>I found this feature merged; than=
ks for this work.</div><div>I tested it and found that one place in the err=
or errcode may need to be changed.</div><div>In=C2=A0checkPartition():</div=
><div>...</div><div>if (get_partition_parent(partRelOid, false) !=3D Relati=
onGetRelid(rel))<br>=C2=A0 =C2=A0 ereport(ERROR,<br>=C2=A0 =C2=A0 errcode(E=
RRCODE_UNDEFINED_TABLE),<br>=C2=A0 =C2=A0 errmsg(&quot;relation \&quot;%s\&=
quot; is not a partition of relation \&quot;%s\&quot;&quot;,</div><div>...<=
/div><div><br></div><div>ERRCODE_UNDEFINED_TABLE usually means &quot;table =
does not exist.&quot;</div><div>When entering here, the table should exist,=
 otherwise table_open() already reports an error.</div><div>I found another=
 two errcode in checkPartition() use=C2=A0ERRCODE_WRONG_OBJECT_TYPE,</div><=
div>In the attached patch, I replace ERRCODE_UNDEFINED_TABLE with ERRCODE_W=
RONG_OBJECT_TYPE.</div><div><br></div></div><span class=3D"gmail_signature_=
prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=
=3D"ltr"><div>Thanks,</div><div>Tender Wang</div></div></div></div>

--000000000000d86507064659a5ad--

--000000000000d86508064659a5af
Content-Type: application/octet-stream;
	name="0001-Adjust-errcode-in-checkPartition.patch"
Content-Disposition: attachment;
	filename="0001-Adjust-errcode-in-checkPartition.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mjdpri6q0>
X-Attachment-Id: f_mjdpri6q0

RnJvbSA2NzZjZGU4MWZkYTAxMjMzZWY3MDc3NjEzMzRkNmQ1OWM5MDZlZmUyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUZW5kZXIgV2FuZyA8dG5kcndhbmdAZ21haWwuY29tPgpEYXRl
OiBTYXQsIDIwIERlYyAyMDI1IDEwOjU2OjM2ICswODAwClN1YmplY3Q6IFtQQVRDSF0gQWRqdXN0
IGVycmNvZGUgaW4gY2hlY2tQYXJ0aXRpb24oKS4KClJlcGxhY2UgRVJSQ09ERV9VTkRFRklORURf
VEFCTEUgd2l0aCBFUlJDT0RFX1dST05HX09CSkVDVF9UWVBFLgotLS0KIHNyYy9iYWNrZW5kL3Bh
cnNlci9wYXJzZV91dGlsY21kLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o
KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wYXJzZXIvcGFyc2Vf
dXRpbGNtZC5jIGIvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX3V0aWxjbWQuYwppbmRleCAyYjdi
MDg0ZjIxNi4uM2FiZTU0MTBiNGMgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJz
ZV91dGlsY21kLmMKKysrIGIvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX3V0aWxjbWQuYwpAQCAt
MzU0NCw3ICszNTQ0LDcgQEAgY2hlY2tQYXJ0aXRpb24oUmVsYXRpb24gcmVsLCBPaWQgcGFydFJl
bE9pZCwgYm9vbCBpc01lcmdlKQogCiAJaWYgKGdldF9wYXJ0aXRpb25fcGFyZW50KHBhcnRSZWxP
aWQsIGZhbHNlKSAhPSBSZWxhdGlvbkdldFJlbGlkKHJlbCkpCiAJCWVyZXBvcnQoRVJST1IsCi0J
CQkJZXJyY29kZShFUlJDT0RFX1VOREVGSU5FRF9UQUJMRSksCisJCQkJZXJyY29kZShFUlJDT0RF
X1dST05HX09CSkVDVF9UWVBFKSwKIAkJCQllcnJtc2coInJlbGF0aW9uIFwiJXNcIiBpcyBub3Qg
YSBwYXJ0aXRpb24gb2YgcmVsYXRpb24gXCIlc1wiIiwKIAkJCQkJICAgUmVsYXRpb25HZXRSZWxh
dGlvbk5hbWUocGFydFJlbCksIFJlbGF0aW9uR2V0UmVsYXRpb25OYW1lKHJlbCkpLAogCQkJCWlz
TWVyZ2UKLS0gCjIuMzQuMQoK
--000000000000d86508064659a5af--