MIME-Version: 1.0
From: Tender Wang <tndrwang@gmail.com>
Date: Tue, 17 Mar 2026 13:24:16 +0800
Message-ID: 
 <CAHewXNmMMg9_5ko9Rybt-1Q45f+M5=01TwyPFuEAV5Xcip7tcw@mail.gmail.com>
Subject: [PATCH] Update HandleChildCrash comments
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000a5b968064d318c44"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHewXNmMMg9_5ko9Rybt-1Q45f%2BM5%3D01TwyPFuEAV5Xcip7tcw%40mail.gmail.com>
Precedence: bulk

--000000000000a5b968064d318c44
Content-Type: text/plain; charset="UTF-8"

Hello hackers,

The existing header comments for HandleChildCrash() in postmaster.c
are somewhat outdated,
as they only list a few auxiliary processes and miss several newer
ones added in recent versions, for example: walsummarizer, and
io_worker.

Instead of maintaining an exhaustive list of process names in the
comments, which can become stale.
This patch updates the comments to point directly to the
decision-making places: process_pm_child_exit() and CleanupBackend().

I have preserved the original description regarding the function's
objectives (cleaning up local state and signaling other children).

Please see the attached patch.

-- 
Thanks,
Tender Wang

--000000000000a5b968064d318c44
Content-Type: application/octet-stream;
	name="0001-Clarify-HandleChildCrash-comments-and-reference-its-.patch"
Content-Disposition: attachment;
	filename="0001-Clarify-HandleChildCrash-comments-and-reference-its-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmu5xfrx0>
X-Attachment-Id: f_mmu5xfrx0

RnJvbSAzNWUxNzFmZDM1ZDI1YTQ4MGY2NTkzMDRhMzgyNTNmY2U0N2QwN2I0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUZW5kZXIgV2FuZyA8dG5kcndhbmdAZ21haWwuY29tPgpEYXRl
OiBUdWUsIDE3IE1hciAyMDI2IDEzOjEwOjEzICswODAwClN1YmplY3Q6IFtQQVRDSF0gQ2xhcmlm
eSBIYW5kbGVDaGlsZENyYXNoIGNvbW1lbnRzIGFuZCByZWZlcmVuY2UgaXRzIGNhbGwKIHNpdGVz
LgoKVGhlIGV4aXN0aW5nIGhlYWRlciBjb21tZW50IGZvciBIYW5kbGVDaGlsZENyYXNoIGRlc2Ny
aWJlcyBpdHMgYWN0aW9ucwpidXQgbGFja3MgY29udGV4dCBvbiB3aGljaCBwcm9jZXNzIGV4aXRz
IGFyZSBjb25zaWRlcmVkIGNhdGFzdHJvcGhpYy4KSW5zdGVhZCBvZiBtYWludGFpbmluZyBhIHZv
bGF0aWxlIGxpc3Qgb2YgcHJvY2VzcyBuYW1lcywgdGhpcyBjb21taXQKdXBkYXRlcyB0aGUgY29t
bWVudHMgdG8gcG9pbnQgdG8gcHJvY2Vzc19wbV9jaGlsZF9leGl0KCkgYW5kCkNsZWFudXBCYWNr
ZW5kKCkuCgpUaGVzZSBmdW5jdGlvbnMgZW5jYXBzdWxhdGUgdGhlIGxvZ2ljIGZvciBkZXRlcm1p
bmluZyB3aGVuIGEgY2hpbGQncwphYm5vcm1hbCBleGl0IHJlcXVpcmVzIGEgY2x1c3Rlci13aWRl
IHJlc3RhcnQuIFRoZSBjb3JlIGRlc2NyaXB0aW9uCm9mIHRoZSBmdW5jdGlvbidzIG9iamVjdGl2
ZXMgaXMgcHJlc2VydmVkLgotLS0KIHNyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvcG9zdG1hc3Rlci5j
IHwgNyArKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u
cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvcG9zdG1hc3Rlci5jIGIv
c3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9wb3N0bWFzdGVyLmMKaW5kZXggM2ZhYzQ2YzQwMmIuLjE5
NmU0N2QwMWZjIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL3Bvc3RtYXN0ZXIu
YworKysgYi9zcmMvYmFja2VuZC9wb3N0bWFzdGVyL3Bvc3RtYXN0ZXIuYwpAQCAtMjc5NywxMyAr
Mjc5NywxNiBAQCBIYW5kbGVGYXRhbEVycm9yKFF1aXRTaWduYWxSZWFzb24gcmVhc29uLCBib29s
IGNvbnNpZGVyX3NpZ2FicnQpCiB9CiAKIC8qCi0gKiBIYW5kbGVDaGlsZENyYXNoIC0tIGNsZWFu
dXAgYWZ0ZXIgZmFpbGVkIGJhY2tlbmQsIGJnd3JpdGVyLCBjaGVja3BvaW50ZXIsCi0gKiB3YWx3
cml0ZXIsIGF1dG92YWN1dW0sIGFyY2hpdmVyLCBzbG90IHN5bmMgd29ya2VyLCBvciBiYWNrZ3Jv
dW5kIHdvcmtlci4KKyAqIEhhbmRsZUNoaWxkQ3Jhc2ggLS0gcHJvY2VzcyBhIGNyYXNoIG9mIGEg
Y2hpbGQgcHJvY2Vzcy4KICAqCiAgKiBUaGUgb2JqZWN0aXZlcyBoZXJlIGFyZSB0byBjbGVhbiB1
cCBvdXIgbG9jYWwgc3RhdGUgYWJvdXQgdGhlIGNoaWxkCiAgKiBwcm9jZXNzLCBhbmQgdG8gc2ln
bmFsIGFsbCBvdGhlciByZW1haW5pbmcgY2hpbGRyZW4gdG8gcXVpY2tkaWUuCiAgKgogICogVGhl
IGNhbGxlciBoYXMgYWxyZWFkeSByZWxlYXNlZCBpdHMgUE1DaGlsZCBzbG90LgorICoKKyAqIFRo
ZSBzcGVjaWZpYyBjb25kaXRpb25zIGFuZCBwcm9jZXNzIHR5cGVzIHRoYXQgdHJpZ2dlciB0aGlz
IGFyZQorICogbWFuYWdlZCBpbiBwcm9jZXNzX3BtX2NoaWxkX2V4aXQoKSAoZm9yIGF1eGlsaWFy
eSBwcm9jZXNzZXMpCisgKiBhbmQgQ2xlYW51cEJhY2tlbmQoKSAoZm9yIGJhY2tlbmRzKS4KICAq
Lwogc3RhdGljIHZvaWQKIEhhbmRsZUNoaWxkQ3Jhc2goaW50IHBpZCwgaW50IGV4aXRzdGF0dXMs
IGNvbnN0IGNoYXIgKnByb2NuYW1lKQotLSAKMi4zNC4xCgo=
--000000000000a5b968064d318c44--