MIME-Version: 1.0
References: 
 <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <CAPpHfdsh_jPZ6-2JtWoFeZravVQYY4cYCcnKXQW6KxEx+F5vxg@mail.gmail.com>
 <2643645f-2a02-43de-9321-c995ab1b7ef8@postgrespro.ru>
 <CACJufxF1Hfx1PST7pCLrKkGcjHEn2A51znXmYwVccnt5GDORcw@mail.gmail.com>
 <57a94d8a-d7b6-4c5e-9001-be1cd403b172@postgrespro.ru>
 <54414932-9E82-47AA-902B-2DED18F07F64@gmail.com>
 <e7da0ceb-8a01-4856-8c87-f87f09b4a9ad@postgrespro.ru>
 <CACJufxET9Qe-=zJtjGrKPr7-1QbVcP9y-vJU9CMEDfPGt_dbyg@mail.gmail.com>
 <3280c458-a886-4c58-8e2b-4d220b73161d@postgrespro.ru>
 <CACJufxEBvrtcOWyX2NMwOCvb2ZvaRGaGeiMQpUD=yxL6ncBFOg@mail.gmail.com>
 <dbe8e3ac-0b85-4809-bfaf-1d11f3c9d814@postgrespro.ru>
 <CAPpHfdvSBR+sbsRCAybN949tOGArQvMH2QeDXf2L=7NDMNbJfw@mail.gmail.com>
 <b96a16a5-02de-4cc2-afb4-fbccba43eb54@postgrespro.ru>
 <CAPpHfduQwwa4ytK-dGjRGN0fTWfpWNNysYuUKrOetsyGioBMfA@mail.gmail.com>
 <09414bf8-9326-431c-9422-b13bddf5f554@postgrespro.ru>
 <CAPpHfdvpzezTnuumpdJYge=x1TbhgAkjMGh2GHnScf5SFsf2ew@mail.gmail.com>
 <29ff27f5-d359-4479-b11c-ce28e525d806@postgrespro.ru>
 <CAPpHfdtBH5YhAiKhXPcLAE4CCRMaGKqupzx8u2RKEm2aQ_e3Xw@mail.gmail.com>
 <CA+gpmfLSELzEKEzSFXeLkRRMGkRfm2+7ewXHyW-8ZWPbWOywyg@mail.gmail.com>
 <CAPpHfdtnWkesztu4qq1m8RfuR2OYXd5tbPyaHk-3Db2szWrb=Q@mail.gmail.com>
 <CAPpHfdta0DMb3XjePJJWf1xbAndE8w2uYPaWEOFBGQ=xsDkfiQ@mail.gmail.com>
 <tencent_3661BB522D5466B33EA33666@qq.com>
 <CAPpHfdvt64X0F3thjC0q9vOTU-JqG2M_MJfEeA2-_=odNOA3Dg@mail.gmail.com>
 <tencent_6DB357447E187E6516DFD9C1@qq.com>
 <CAPpHfdu8wPv6hes7v95fF__N1pkPG1yS3YumKUGmS_jdF2RtrA@mail.gmail.com>
 <CAHewXNmBM+5qbrJMu60NxPn+0y-=2wXM-QVVs3xRp8NxFvDb9A@mail.gmail.com>
 <CAPpHfdvs-U0HQWnhe8e7B=K5k=c9FvvA39UcqnmNoLqbkgAfjw@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdvs-U0HQWnhe8e7B=K5k=c9FvvA39UcqnmNoLqbkgAfjw@mail.gmail.com>
From: Tender Wang <tndrwang@gmail.com>
Date: Sun, 21 Dec 2025 15:14:01 +0800
Message-ID: 
 <CAHewXNnBNVgj91xxm29nrJUeVcZd6WvUXAvnx1abJnC7vZgxAQ@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000073e38f0646711078"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHewXNnBNVgj91xxm29nrJUeVcZd6WvUXAvnx1abJnC7vZgxAQ%40mail.gmail.com>
Precedence: bulk

--00000000000073e38f0646711078
Content-Type: multipart/alternative; boundary="00000000000073e38e0646711076"

--00000000000073e38e0646711076
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Alexander Korotkov <aekorotkov@gmail.com> =E4=BA=8E2025=E5=B9=B412=E6=9C=88=
20=E6=97=A5=E5=91=A8=E5=85=AD 19:08=E5=86=99=E9=81=93=EF=BC=9A

> Hi Tender,
>
> On Sat, Dec 20, 2025 at 5:18=E2=80=AFAM Tender Wang <tndrwang@gmail.com> =
wrote:
> > I found this feature merged; thanks for this work.
> > I tested it and found that one place in the error errcode may need to b=
e
> changed.
> > In checkPartition():
> > ...
> > if (get_partition_parent(partRelOid, false) !=3D RelationGetRelid(rel))
> >     ereport(ERROR,
> >     errcode(ERRCODE_UNDEFINED_TABLE),
> >     errmsg("relation \"%s\" is not a partition of relation \"%s\"",
> > ...
> >
> > ERRCODE_UNDEFINED_TABLE usually means "table does not exist."
> > When entering here, the table should exist, otherwise table_open()
> already reports an error.
> > I found another two errcode in checkPartition() use
> ERRCODE_WRONG_OBJECT_TYPE,
> > In the attached patch, I replace ERRCODE_UNDEFINED_TABLE with
> ERRCODE_WRONG_OBJECT_TYPE.
>
> I agree with you that ERRCODE_UNDEFINED_TABLE is certainly wrong error
> code because the table actually exists.  ERRCODE_WRONG_OBJECT_TYPE is
> better.  For example, we throw it when trying to attach a partition to
> non-partitioned table.  So, the parent table type is wrong.  However,
> are objects in the situation under consideration really have wrong
> type?  The problem is that one table is not partition of another.
> However, it's possibly that they could be attached without changing of
> their types.  So, I think about
> ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE.  What do you think?
>

It's ok for me. Please check the v2 patch.

--=20
Thanks,
Tender Wang

--00000000000073e38e0646711076
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">Alexander Korot=
kov &lt;<a href=3D"mailto:aekorotkov@gmail.com">aekorotkov@gmail.com</a>&gt=
; =E4=BA=8E2025=E5=B9=B412=E6=9C=8820=E6=97=A5=E5=91=A8=E5=85=AD 19:08=E5=
=86=99=E9=81=93=EF=BC=9A<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Hi Tender,<br>
<br>
On Sat, Dec 20, 2025 at 5:18=E2=80=AFAM Tender Wang &lt;<a href=3D"mailto:t=
ndrwang@gmail.com" target=3D"_blank">tndrwang@gmail.com</a>&gt; wrote:<br>
&gt; I found this feature merged; thanks for this work.<br>
&gt; I tested it and found that one place in the error errcode may need to =
be changed.<br>
&gt; In checkPartition():<br>
&gt; ...<br>
&gt; if (get_partition_parent(partRelOid, false) !=3D RelationGetRelid(rel)=
)<br>
&gt;=C2=A0 =C2=A0 =C2=A0ereport(ERROR,<br>
&gt;=C2=A0 =C2=A0 =C2=A0errcode(ERRCODE_UNDEFINED_TABLE),<br>
&gt;=C2=A0 =C2=A0 =C2=A0errmsg(&quot;relation \&quot;%s\&quot; is not a par=
tition of relation \&quot;%s\&quot;&quot;,<br>
&gt; ...<br>
&gt;<br>
&gt; ERRCODE_UNDEFINED_TABLE usually means &quot;table does not exist.&quot=
;<br>
&gt; When entering here, the table should exist, otherwise table_open() alr=
eady reports an error.<br>
&gt; I found another two errcode in checkPartition() use ERRCODE_WRONG_OBJE=
CT_TYPE,<br>
&gt; In the attached patch, I replace ERRCODE_UNDEFINED_TABLE with ERRCODE_=
WRONG_OBJECT_TYPE.<br>
<br>
I agree with you that ERRCODE_UNDEFINED_TABLE is certainly wrong error<br>
code because the table actually exists.=C2=A0 ERRCODE_WRONG_OBJECT_TYPE is<=
br>
better.=C2=A0 For example, we throw it when trying to attach a partition to=
<br>
non-partitioned table.=C2=A0 So, the parent table type is wrong.=C2=A0 Howe=
ver,<br>
are objects in the situation under consideration really have wrong<br>
type?=C2=A0 The problem is that one table is not partition of another.<br>
However, it&#39;s possibly that they could be attached without changing of<=
br>
their types.=C2=A0 So, I think about<br>
ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE.=C2=A0 What do you think?<br></blo=
ckquote><div><br></div><div>It&#39;s ok for me. Please check the v2 patch.=
=C2=A0</div></div><div><br></div><span class=3D"gmail_signature_prefix">-- =
</span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div=
>Thanks,</div><div>Tender Wang</div></div></div></div>

--00000000000073e38e0646711076--

--00000000000073e38f0646711078
Content-Type: text/plain; charset="US-ASCII";
	name="v2-0001-Adjust-errcode-in-checkPartition.patch"
Content-Disposition: attachment;
	filename="v2-0001-Adjust-errcode-in-checkPartition.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mjfe5h7n0>
X-Attachment-Id: f_mjfe5h7n0

RnJvbSA0OTJjNTk1Y2Y0ODFjNjdlYjJiNDgyM2FlM2UzODlkMGE2ZmI3ZjgzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUZW5kZXIgV2FuZyA8dG5kcndhbmdAZ21haWwuY29tPgpEYXRl
OiBTYXQsIDIwIERlYyAyMDI1IDEwOjU2OjM2ICswODAwClN1YmplY3Q6IFtQQVRDSCB2Ml0gQWRq
dXN0IGVycmNvZGUgaW4gY2hlY2tQYXJ0aXRpb24oKS4KClJlcGxhY2UgRVJSQ09ERV9VTkRFRklO
RURfVEFCTEUgd2l0aCBFUlJDT0RFX09CSkVDVF9OT1RfSU5fUFJFUkVRVUlTSVRFX1NUQVRFLgot
LS0KIHNyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV91dGlsY21kLmMgfCAyICstCiAxIGZpbGUgY2hh
bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFj
a2VuZC9wYXJzZXIvcGFyc2VfdXRpbGNtZC5jIGIvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX3V0
aWxjbWQuYwppbmRleCAyYjdiMDg0ZjIxNi4uZGU4YzBhNTU2MGIgMTAwNjQ0Ci0tLSBhL3NyYy9i
YWNrZW5kL3BhcnNlci9wYXJzZV91dGlsY21kLmMKKysrIGIvc3JjL2JhY2tlbmQvcGFyc2VyL3Bh
cnNlX3V0aWxjbWQuYwpAQCAtMzU0NCw3ICszNTQ0LDcgQEAgY2hlY2tQYXJ0aXRpb24oUmVsYXRp
b24gcmVsLCBPaWQgcGFydFJlbE9pZCwgYm9vbCBpc01lcmdlKQogCiAJaWYgKGdldF9wYXJ0aXRp
b25fcGFyZW50KHBhcnRSZWxPaWQsIGZhbHNlKSAhPSBSZWxhdGlvbkdldFJlbGlkKHJlbCkpCiAJ
CWVyZXBvcnQoRVJST1IsCi0JCQkJZXJyY29kZShFUlJDT0RFX1VOREVGSU5FRF9UQUJMRSksCisJ
CQkJZXJyY29kZShFUlJDT0RFX09CSkVDVF9OT1RfSU5fUFJFUkVRVUlTSVRFX1NUQVRFKSwKIAkJ
CQllcnJtc2coInJlbGF0aW9uIFwiJXNcIiBpcyBub3QgYSBwYXJ0aXRpb24gb2YgcmVsYXRpb24g
XCIlc1wiIiwKIAkJCQkJICAgUmVsYXRpb25HZXRSZWxhdGlvbk5hbWUocGFydFJlbCksIFJlbGF0
aW9uR2V0UmVsYXRpb25OYW1lKHJlbCkpLAogCQkJCWlzTWVyZ2UKLS0gCjIuMzQuMQoK
--00000000000073e38f0646711078--