MIME-Version: 1.0
References: <CA+HiwqFpZ80UJKr4tZus4Omgg7YESzFXKSwSHRW2Ap2=XSVyUA@mail.gmail.com>
 <54c35fb9-da3a-4754-ab8c-46ed0b612465@vondra.me> <CA+HiwqH8N-SxEB6SysEBsYNgV_KJs66k9Z2SNmqVzbBP-60yWg@mail.gmail.com>
 <684c70d7-180e-461d-9377-600c2db581ba@vondra.me> <CA+HiwqEmG9YCQvG6uux7sO=jKFSAW6hA4Ea-ymfD+JhJAe4PWQ@mail.gmail.com>
 <CA+HiwqE2FfJfH=siLiR3kJ13tmXZORAGTWsZc2r52o1_5BDv+g@mail.gmail.com>
 <bfcc1b78-aa39-4356-8f42-b8cfb9733d6e@vondra.me> <CA+HiwqFhkpXHAA=4NY5SqYXX08uq=nYtXcSByNZF=2MAy1UA7A@mail.gmail.com>
 <CA+HiwqHCcSoYfpMjFshaU1bj6NjreiDvMSDpVSeBmqk-kbWrPw@mail.gmail.com>
 <CA+HiwqHOejJk0_qMuM5g38h70hY_JvHMAKwnH3k=urfTXauPQA@mail.gmail.com>
 <CA+HiwqFsGKM82oaMby3VWYXf_XFpDAMeT+6SXgj-45HpTrS1dA@mail.gmail.com>
 <CA+HiwqFA5hUWYktt3VMh4zQOYMxqH-MpdX8eemfM+o-9dY-zbQ@mail.gmail.com>
 <CA+HiwqEn7bbUXaXO=SmUujBjJSHfS31cwQroHRBwT0sR=66bgg@mail.gmail.com>
 <CA+HiwqGGLDTd1ZTK1c0zv4La7XOVSVMqBuNtscJeh6FyUQvFvA@mail.gmail.com>
 <CA+HiwqE2JFiqqrXdyJVQWY-fMGwzDkLqjXQdUKbPaCpDpxd_2g@mail.gmail.com> <74839af6-aadc-4f60-ae77-ae65f94bf607@gmail.com>
In-Reply-To: <74839af6-aadc-4f60-ae77-ae65f94bf607@gmail.com>
From: Tender Wang <tndrwang@gmail.com>
Date: Sun, 23 Feb 2025 01:02:56 +0800
Message-ID: <CAHewXNnEwVQoXBiR+nC09R20Psr2xXjOuhatC-kHfr0-B2pcVw@mail.gmail.com>
Subject: Re: generic plans and "initial" pruning
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>, Tomas Vondra <tomas@vondra.me>, 
	Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Andres Freund <andres@anarazel.de>, Daniel Gustafsson <daniel@yesql.se>, 
	David Rowley <dgrowleyml@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, 
	Thom Brown <thom@linux.com>, Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: multipart/alternative; boundary="000000000000cf54c3062ebe140a"
Archived-At: <https://www.postgresql.org/message-id/CAHewXNnEwVQoXBiR%2BnC09R20Psr2xXjOuhatC-kHfr0-B2pcVw%40mail.gmail.com>
Precedence: bulk

--000000000000cf54c3062ebe140a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Alexander Lakhin <exclusion@gmail.com> =E4=BA=8E2025=E5=B9=B42=E6=9C=8822=
=E6=97=A5=E5=91=A8=E5=85=AD 23:00=E5=86=99=E9=81=93=EF=BC=9A

> Hello Amit,
>
> 21.02.2025 05:40, Amit Langote wrote:
>
> I pushed the final piece yesterday.
>
>
> Please look at new error, produced by the following script,
> starting from 525392d57:
> CREATE TABLE t(id int) PARTITION BY RANGE (id);
> CREATE INDEX idx on t(id);
> CREATE TABLE tp_1 PARTITION OF t FOR VALUES FROM (10) TO (20);
> CREATE TABLE tp_2 PARTITION OF t FOR VALUES FROM (20) TO (30) PARTITION B=
Y
> RANGE(id);
> CREATE TABLE tp_2_1 PARTITION OF tp_2 FOR VALUES FROM (21) to (22);
> CREATE TABLE tp_2_2 PARTITION OF tp_2 FOR VALUES FROM (22) to (23);
> CREATE FUNCTION stable_one() RETURNS INT AS $$ BEGIN RETURN 1; END; $$
> LANGUAGE plpgsql STABLE;
>
> SELECT min(id) OVER (PARTITION BY id ORDER BY id) FROM t WHERE id >=3D
> stable_one();
>
> ERROR:  XX000: trying to open a pruned relation
> LOCATION:  ExecGetRangeTableRelation, execUtils.c:830
>
> This issue was discovered with SQLsmith.
>

The error message was added in commit  525392d57. In this case,
the estate->es_unpruned_relids only includes 1, which is the offset of
table t.
In register_partpruneinfo(), we collect glob->prunableRelids; in this case,
it contains 2,3,4,5. Then we will do:
result->unprunableRelids =3D bms_difference(glob->allRelids,
 glob->prunableRelids);
so the result->unprunableRelids only contains 1.

But tp_2 is also partition table, and its partpruneinfo created by
create_append_plan() is put into the head of global list.
So we first process it in ExecDoInitialPruning().  Then error reports
because we only contain 1 in estate->es_unpruned_relids.


--=20
Thanks,
Tender Wang

--000000000000cf54c3062ebe140a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">Alexander Lakhi=
n &lt;<a href=3D"mailto:exclusion@gmail.com">exclusion@gmail.com</a>&gt; =
=E4=BA=8E2025=E5=B9=B42=E6=9C=8822=E6=97=A5=E5=91=A8=E5=85=AD 23:00=E5=86=
=99=E9=81=93=EF=BC=9A<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex"><u></u>

 =20
   =20
 =20
  <div>
    <div>Hello Amit, <br>
      <br>
      21.02.2025 05:40, Amit Langote wrote:<br>
    </div>
    <blockquote type=3D"cite">
      <pre>I pushed the final piece yesterday.
</pre>
    </blockquote>
    <br>
    Please look at new error, produced by the following script,<br>
    starting from 525392d57:<br>
    CREATE TABLE t(id int) PARTITION BY RANGE (id);<br>
    CREATE INDEX idx on t(id);<br>
    CREATE TABLE tp_1 PARTITION OF t FOR VALUES FROM (10) TO (20);<br>
    CREATE TABLE tp_2 PARTITION OF t FOR VALUES FROM (20) TO (30)
    PARTITION BY RANGE(id);<br>
    CREATE TABLE tp_2_1 PARTITION OF tp_2 FOR VALUES FROM (21) to (22);<br>
    CREATE TABLE tp_2_2 PARTITION OF tp_2 FOR VALUES FROM (22) to (23);<br>
    CREATE FUNCTION stable_one() RETURNS INT AS $$ BEGIN RETURN 1; END;
    $$ LANGUAGE plpgsql STABLE;<br>
    <br>
    SELECT min(id) OVER (PARTITION BY id ORDER BY id) FROM t WHERE id
    &gt;=3D stable_one();<br>
    <br>
    ERROR:=C2=A0 XX000: trying to open a pruned relation<br>
    LOCATION:=C2=A0 ExecGetRangeTableRelation, execUtils.c:830<br>
    <br>
    This issue was discovered with SQLsmith.<br></div></blockquote><div><br=
></div><div>The error message was added in commit=C2=A0 525392d57. In this =
case, the=C2=A0estate-&gt;es_unpruned_relids only includes 1, which is the =
offset of table t.</div><div>In=C2=A0register_partpruneinfo(), we collect g=
lob-&gt;prunableRelids; in this case, it contains 2,3,4,5. Then we will do:=
</div><div>result-&gt;unprunableRelids =3D bms_difference(glob-&gt;allRelid=
s,<br>											 =C2=A0glob-&gt;prunableRelids);</div><div>so the result-&=
gt;unprunableRelids only contains 1.</div><div><br></div><div>But tp_2 is a=
lso partition table, and its partpruneinfo created by create_append_plan() =
is put into the head of global list.=C2=A0</div><div>So we first process it=
 in=C2=A0ExecDoInitialPruning().=C2=A0 Then error reports because we only c=
ontain 1 in=C2=A0estate-&gt;es_unpruned_relids.</div><div><br></div><div><b=
r></div></div><div><br></div><span class=3D"gmail_signature_prefix">-- </sp=
an><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>Tha=
nks,</div><div>Tender Wang</div></div></div></div>

--000000000000cf54c3062ebe140a--