MIME-Version: 1.0
References: 
 <CAHg+QDf+fJsyT_Oj6xDCGkyKWMQ=oEjLdxZ_K4WmKApQWP8hjA@mail.gmail.com>
In-Reply-To: 
 <CAHg+QDf+fJsyT_Oj6xDCGkyKWMQ=oEjLdxZ_K4WmKApQWP8hjA@mail.gmail.com>
From: Tender Wang <tndrwang@gmail.com>
Date: Sat, 25 Apr 2026 15:53:31 +0800
Message-ID: 
 <CAHewXNnFeWk6oLm39rCS4YvZg8x_hFOzz1XDDXXK+VB6Up0Qtw@mail.gmail.com>
Subject: Re: Discarded adjust_relid_set() return values in
 remove_self_join_rel
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHewXNnFeWk6oLm39rCS4YvZg8x_hFOzz1XDDXXK%2BVB6Up0Qtw%40mail.gmail.com>
Precedence: bulk

Hi,

SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com> =E4=BA=8E2026=E5=B9=B4=
4=E6=9C=8825=E6=97=A5=E5=91=A8=E5=85=AD 15:44=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi hackers,
>
> I found that remove_self_join_rel() in analyzejoins.c discards the
> return values of two adjust_relid_set() calls when updating
> root->all_result_relids and root->leaf_result_relids:
>
>     adjust_relid_set(root->all_result_relids, toRemove->relid, toKeep->re=
lid);
>     adjust_relid_set(root->leaf_result_relids, toRemove->relid, toKeep->r=
elid);
>
> adjust_relid_set() does not modify its input in-place.  When it finds
> the old relid in the set, it calls bms_copy() to create a new
> Bitmapset, performs the substitution on the copy, and returns the new
> pointer.  Without capturing the return value, the original sets are
> never updated. Every other call site in the file  analyzejoins.c correctl=
y
> assigns the return value.
>
> I am not able to craft a query to show it as a problem.
> For the current release, these two lines appears to be a no-op?
>
> Attached a patch to assign the returned values.

The topic in [1] seems to be the same issue as your report.
You can take a look at [1] to double-check.

[1] https://www.postgresql.org/message-id/CAMbWs49fYQcqJfJ_Gtn8r1GFNoYtb1%3=
D2AUab4ieuqY4Zid9ocQ%40mail.gmail.com
(Sorry for not adding pgsql-hackers mail  in the last email)


--=20
Thanks,
Tender Wang