MIME-Version: 1.0
From: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Date: Fri, 10 Apr 2026 08:41:58 -0700
Message-ID: 
 <CAHg+QDc4aaiufYSgrwMMPMMRTPtQ66SghcrPFbWJFZMqNaG+BA@mail.gmail.com>
Subject: Bug: Missing collation assignment for GRAPH_TABLE COLUMNS expressions
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Type: multipart/mixed; boundary="000000000000e995b2064f1cf92a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHg%2BQDc4aaiufYSgrwMMPMMRTPtQ66SghcrPFbWJFZMqNaG%2BBA%40mail.gmail.com>
Precedence: bulk

--000000000000e995b2064f1cf92a
Content-Type: multipart/alternative; boundary="000000000000e995b1064f1cf928"

--000000000000e995b1064f1cf928
Content-Type: text/plain; charset="UTF-8"

Hi hackers,

GRAPH_TABLE COLUMNS expressions that involve collation-dependent functions
or operators fail with:

  ERROR: could not determine which collation to use for upper() function
  HINT: Use the COLLATE clause to set the collation explicitly.

Setup:

  CREATE TABLE vtx (id int PRIMARY KEY, name text);
  CREATE TABLE edg (id int PRIMARY KEY,
                    src int REFERENCES vtx(id),
                    dst int REFERENCES vtx(id));
  INSERT INTO vtx VALUES (1,'Alice'),(2,'Bob'),(3,'Carol');
  INSERT INTO edg VALUES (1,1,2),(2,2,3);

  CREATE PROPERTY GRAPH g
    VERTEX TABLES (vtx KEY (id))
    EDGE TABLES (edg KEY (id)
      SOURCE KEY (src) REFERENCES vtx (id)
      DESTINATION KEY (dst) REFERENCES vtx (id));

postgres=# SELECT * FROM GRAPH_TABLE (g
  MATCH (a IS vtx)-[e IS edg]->(b IS vtx) COLUMNS (upper(a.name) AS
src_upper));
ERROR:  could not determine which collation to use for upper() function
HINT:  Use the COLLATE clause to set the collation explicitly.


In transformRangeGraphTable(), the COLUMNS transformation loop calls
transformExpr()
on each column expression but omits the subsequent assign_expr_collations()
call.  Both
WHERE clause transformation sites in parse_graphtable.c correctly include
it.

Attached a patch to fix this.

Thanks,
Satya

--000000000000e995b1064f1cf928
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi hackers,<br><br>GRAPH_TABLE COLUMNS expressions that in=
volve collation-dependent functions or operators fail with:<br><br>=C2=A0 E=
RROR: could not determine which collation to use for upper() function<br>=
=C2=A0 HINT: Use the COLLATE clause to set the collation explicitly.<br><br=
>Setup:=C2=A0<div><br>=C2=A0 CREATE TABLE vtx (id int PRIMARY KEY, name tex=
t);<br>=C2=A0 CREATE TABLE edg (id int PRIMARY KEY,<br>=C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 src int REFERENCES vtx(id=
),<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 dst int REFERENCES vtx(id));<br>=C2=A0 INSERT INTO vtx VALUES (1,&#39;Alic=
e&#39;),(2,&#39;Bob&#39;),(3,&#39;Carol&#39;);<br>=C2=A0 INSERT INTO edg VA=
LUES (1,1,2),(2,2,3);<br><br>=C2=A0 CREATE PROPERTY GRAPH g<br>=C2=A0 =C2=
=A0 VERTEX TABLES (vtx KEY (id))<br>=C2=A0 =C2=A0 EDGE TABLES (edg KEY (id)=
<br>=C2=A0 =C2=A0 =C2=A0 SOURCE KEY (src) REFERENCES vtx (id)<br>=C2=A0 =C2=
=A0 =C2=A0 DESTINATION KEY (dst) REFERENCES vtx (id));<br><br>postgres=3D# =
SELECT * FROM GRAPH_TABLE (g<br>=C2=A0 MATCH (a IS vtx)-[e IS edg]-&gt;(b I=
S vtx) COLUMNS (upper(<a href=3D"http://a.name">a.name</a>) AS src_upper));=
<br>ERROR: =C2=A0could not determine which collation to use for upper() fun=
ction<br>HINT: =C2=A0Use the COLLATE clause to set the collation explicitly=
.<br><br><br>In transformRangeGraphTable(), the COLUMNS transformation loop=
 calls transformExpr()=C2=A0<div>on each column expression but omits the su=
bsequent assign_expr_collations() call.=C2=A0 Both=C2=A0</div><div>WHERE cl=
ause transformation sites in parse_graphtable.c correctly include it.<br></=
div><div><br></div><div>Attached a patch to fix this.</div></div><div><br><=
/div><div>Thanks,</div><div>Satya</div></div>

--000000000000e995b1064f1cf928--

--000000000000e995b2064f1cf92a
Content-Type: application/octet-stream;
	name="0001-fix-graph-table-columns-collation.patch"
Content-Disposition: attachment;
	filename="0001-fix-graph-table-columns-collation.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnt2pd0c0>
X-Attachment-Id: f_mnt2pd0c0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYyBiL3NyYy9iYWNr
ZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYwppbmRleCA5NjdlZWE0NC4uNDJkMzVhMTggMTAwNjQ0
Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYworKysgYi9zcmMvYmFja2Vu
ZC9wYXJzZXIvcGFyc2VfY2xhdXNlLmMKQEAgLTk4MCw2ICs5ODAsNyBAQCB0cmFuc2Zvcm1SYW5n
ZUdyYXBoVGFibGUoUGFyc2VTdGF0ZSAqcHN0YXRlLCBSYW5nZUdyYXBoVGFibGUgKnJndCkKIAkJ
Y2hhcgkgICAqY29sbmFtZTsKIAogCQljb2xleHByID0gdHJhbnNmb3JtRXhwcihwc3RhdGUsIHJ0
LT52YWwsIEVYUFJfS0lORF9TRUxFQ1RfVEFSR0VUKTsKKwkJYXNzaWduX2V4cHJfY29sbGF0aW9u
cyhwc3RhdGUsIGNvbGV4cHIpOwogCiAJCWlmIChydC0+bmFtZSkKIAkJCWNvbG5hbWUgPSBydC0+
bmFtZTsKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZ3JhcGhfdGFibGUu
b3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ncmFwaF90YWJsZS5vdXQKaW5kZXggYjU3
OWUzZGYuLjI2YmE5NWU1IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dy
YXBoX3RhYmxlLm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3RhYmxl
Lm91dApAQCAtMTAyMiw0ICsxMDIyLDUzIEBAIFNFTEVDVCBzbmFtZSwgZG5hbWUgRlJPTSBHUkFQ
SF9UQUJMRSAoZzEgTUFUQ0ggKHNyYyktPihkZXN0KSBXSEVSRSBzcmMudnByb3AxID4KIEVSUk9S
OiAgc3VicXVlcmllcyB3aXRoaW4gR1JBUEhfVEFCTEUgcmVmZXJlbmNlIGFyZSBub3Qgc3VwcG9y
dGVkCiBTRUxFQ1Qgc25hbWUsIGRuYW1lIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChzcmMp
LT4oZGVzdCkgV0hFUkUgb3V0X2RlZ3JlZShzcmMudm5hbWUpID4gKFNFTEVDVCBtYXgob3V0X2Rl
Z3JlZShubmFtZSkpIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChub2RlKSBDT0xVTU5TIChu
b2RlLnZuYW1lIEFTIG5uYW1lKSkpIENPTFVNTlMoc3JjLnZuYW1lIEFTIHNuYW1lLCBkZXN0LnZu
YW1lIEFTIGRuYW1lKSk7CiBFUlJPUjogIHN1YnF1ZXJpZXMgd2l0aGluIEdSQVBIX1RBQkxFIHJl
ZmVyZW5jZSBhcmUgbm90IHN1cHBvcnRlZAorLS0gY29sbGF0aW9uIGFzc2lnbm1lbnQgZm9yIENP
TFVNTlMgZXhwcmVzc2lvbnMKK1NFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChz
cmMpLT4oZGVzdCkgQ09MVU1OUyAodXBwZXIoc3JjLnZuYW1lKSBBUyB1KSkgT1JERVIgQlkgdTsK
KyAgdSAgCistLS0tLQorIFYxMQorIFYxMQorIFYxMQorIFYxMgorIFYxMworIFYyMQorIFYyMgor
IFYyMworIFYzMgorIFYzMworIFYzMworKDExIHJvd3MpCisKK1NFTEVDVCAqIEZST00gR1JBUEhf
VEFCTEUgKGcxIE1BVENIIChzcmMpLT4oZGVzdCkgQ09MVU1OUyAoc3JjLnZuYW1lIHx8IGRlc3Qu
dm5hbWUgQVMgY29tYmluZWQpKSBPUkRFUiBCWSBjb21iaW5lZDsKKyBjb21iaW5lZCAKKy0tLS0t
LS0tLS0KKyB2MTF2MjIKKyB2MTF2MzEKKyB2MTF2MzMKKyB2MTJ2MjEKKyB2MTN2MjMKKyB2MjF2
MTIKKyB2MjJ2MzIKKyB2MjN2MTMKKyB2MzJ2MjIKKyB2MzN2MzMKKyB2MzN2MzMKKygxMSByb3dz
KQorCitTRUxFQ1QgKiBGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoc3JjKS0+KGRlc3QpIENP
TFVNTlMgKHJlcGxhY2Uoc3JjLnZuYW1lLCAnUycsICdYJykgQVMgcmVwbGFjZWQpKSBPUkRFUiBC
WSByZXBsYWNlZDsKKyByZXBsYWNlZCAKKy0tLS0tLS0tLS0KKyB2MTEKKyB2MTEKKyB2MTEKKyB2
MTIKKyB2MTMKKyB2MjEKKyB2MjIKKyB2MjMKKyB2MzIKKyB2MzMKKyB2MzMKKygxMSByb3dzKQor
CiAtLSBsZWF2ZSB0aGUgb2JqZWN0cyBiZWhpbmQgZm9yIHBnX3VwZ3JhZGUvcGdfZHVtcCB0ZXN0
cwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsIGIvc3Jj
L3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsCmluZGV4IDRmZjk4ODE3Li4xM2VjZTZk
OCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsCisrKyBi
L3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbApAQCAtNTgyLDQgKzU4Miw5IEBA
IFNFTEVDVCAqIEZST00gY3VzdG9tZXJzIGNvIFdIRVJFIGNvLmN1c3RvbWVyX2lkID0gKFNFTEVD
VCBjdXN0b21lcl9pZCBGUk9NIEdSQVBICiBTRUxFQ1Qgc25hbWUsIGRuYW1lIEZST00gR1JBUEhf
VEFCTEUgKGcxIE1BVENIIChzcmMpLT4oZGVzdCkgV0hFUkUgc3JjLnZwcm9wMSA+IChTRUxFQ1Qg
bWF4KHYxLnZwcm9wMSkgRlJPTSB2MSkgQ09MVU1OUyhzcmMudm5hbWUgQVMgc25hbWUsIGRlc3Qu
dm5hbWUgQVMgZG5hbWUpKTsKIFNFTEVDVCBzbmFtZSwgZG5hbWUgRlJPTSBHUkFQSF9UQUJMRSAo
ZzEgTUFUQ0ggKHNyYyktPihkZXN0KSBXSEVSRSBvdXRfZGVncmVlKHNyYy52bmFtZSkgPiAoU0VM
RUNUIG1heChvdXRfZGVncmVlKG5uYW1lKSkgRlJPTSBHUkFQSF9UQUJMRSAoZzEgTUFUQ0ggKG5v
ZGUpIENPTFVNTlMgKG5vZGUudm5hbWUgQVMgbm5hbWUpKSkgQ09MVU1OUyhzcmMudm5hbWUgQVMg
c25hbWUsIGRlc3Qudm5hbWUgQVMgZG5hbWUpKTsKIAorLS0gY29sbGF0aW9uIGFzc2lnbm1lbnQg
Zm9yIENPTFVNTlMgZXhwcmVzc2lvbnMKK1NFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUgKGcxIE1B
VENIIChzcmMpLT4oZGVzdCkgQ09MVU1OUyAodXBwZXIoc3JjLnZuYW1lKSBBUyB1KSkgT1JERVIg
QlkgdTsKK1NFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChzcmMpLT4oZGVzdCkg
Q09MVU1OUyAoc3JjLnZuYW1lIHx8IGRlc3Qudm5hbWUgQVMgY29tYmluZWQpKSBPUkRFUiBCWSBj
b21iaW5lZDsKK1NFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChzcmMpLT4oZGVz
dCkgQ09MVU1OUyAocmVwbGFjZShzcmMudm5hbWUsICdTJywgJ1gnKSBBUyByZXBsYWNlZCkpIE9S
REVSIEJZIHJlcGxhY2VkOworCiAtLSBsZWF2ZSB0aGUgb2JqZWN0cyBiZWhpbmQgZm9yIHBnX3Vw
Z3JhZGUvcGdfZHVtcCB0ZXN0cwo=
--000000000000e995b2064f1cf92a--